Skip to content
GitLab
  1. 16 Jan, 2015 1 commit
  3. 12 Jan, 2015 1 commit
  5. 07 Jan, 2015 1 commit
  7. 17 Sep, 2014 2 commits
    • Gabriele Mazzotta's avatar
      Use ABS_MT events for the palm detection when supported · a897147b
      Gabriele Mazzotta authored and Peter Hutterer's avatar Peter Hutterer committed 
      

Use ABS_MT_TOUCH_MAJOR and ABS_MT_PRESSURE instead of ABS_TOOL_WIDTH
and ABS_PRESSURE when supported so that the pressure and the width of
all the fingers is taken into account for the palm detection.

This also fixes the palm detection for those touchpads for which the
kernel only sends ABS_MT_TOUCH_MAJOR and not ABS_TOOL_WIDTH.

Signed-off-by: Gabriele Mazzotta's avatarGabriele Mazzotta <gabriele.mzt@gmail.com>
Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      a897147b
    • Peter Hutterer's avatar
      Limit the movement to 20 mm per event · 41b2312c
      Peter Hutterer authored 
      

Touchpads are limited by a fixed sampling rate (usually 80Hz). Some finger
changes may happen too fast for this sampling rate, resulting in two distinct
event sequences:
* finger 1 up and finger 2 down in the same EV_SYN frame. Synaptics sees one
  finger down before and after and the changed coordinates
* finger 1 up and finger 2 down _between_ two EV_SYN frames. Synaptics sees one
  touchpoint move from f1 position to f2 position.

That move causes a large cursor jump. The former could be solved (with
difficulty) by adding fake EV_SYN handling after releasing touchpoints but
that won't fix the latter case.

So as a solution for now limit the finger movement to 20mm per event.
Tests on a T440 and an x220 showed that this is just above what a reasonable
finger movement would trigger. If a movement is greater than that limit, reset
it to 0/0.

On devices without resolution, use 0.25 of the touchpad's diagonal instead.

Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      41b2312c
  9. 16 Sep, 2014 1 commit
  11. 05 Sep, 2014 5 commits
  13. 03 Sep, 2014 1 commit
    • Peter Hutterer's avatar
      eventcomm: ensure we're on the same clock as the server · 90d19302
      Peter Hutterer authored 
      

Default on evdev devices is CLOCK_REALTIME. If that clock falls behind the
server's CLOCK_MONOTONIC, motion after a clickpad click may be delayed by the
difference in the clocks.

In detail:
When the timer func is triggered, GetTimeInMillis() which is CLOCK_MONOTONIC,
is stored as hwState->millis. The eventcomm backend uses struct
input_event time (CLOCK_REALTIME).

When we read events from the device, if the evdev time is less than the server
time, the fix for (#48777) sets the current event time to hwState->millis.
Until the evdev time overtakes that stored time, all events have the
hwState->millis time.

If during that time a clickpad triggers a physical click,
clickpad_click_millis is set to hwState->millis + the ignore-motion timeout.
Thus, all motion is ignored until the event time overtakes that stored
time.

The whole issue is further enhanced by us unconditionally setting the timer
func if we get any events, which is a separate issue anyway.

Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      90d19302
  15. 28 Aug, 2014 2 commits
  17. 14 Aug, 2014 1 commit
  19. 08 Aug, 2014 3 commits
  21. 20 May, 2014 1 commit
  23. 13 May, 2014 1 commit
  25. 30 Apr, 2014 4 commits
  27. 29 Apr, 2014 1 commit
  29. 22 Apr, 2014 2 commits
  31. 09 Apr, 2014 4 commits
  33. 23 Mar, 2014 1 commit
    • Peter Hutterer's avatar
      Disable GrabEventDevice by default · f1948e08
      Peter Hutterer authored 
      

This was required when we started supporting hotplugging to avoid duplicate
events. These days the drawback of not being able to record events in the case
of a bug is significant.

Check the configuration source on init. If the device was hotplugged through a
a server config backend, disable the grab. If the device was statically
configured through an xorg.conf then leave the default grab enabled to avoid
a duplicate device.

Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      f1948e08
  35. 17 Mar, 2014 2 commits
  37. 14 Mar, 2014 1 commit
  39. 13 Mar, 2014 2 commits
  41. 12 Mar, 2014 3 commits