GitLab

configure.ac:130: warning: AC_OUTPUT should be used without arguments.
configure.ac:130: You should run autoupdate.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Found by using:
    codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Andrew Savchenko authored Feb 16, 2018 and Alan Coopersmith committed Mar 23, 2018

https://bugs.freedesktop.org/show_bug.cgi?id=105136

Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Mihail Konev authored Jan 26, 2017 and Peter Hutterer committed Jan 26, 2017

Signed-off-by: Mihail Konev <k.mvc@ya.ru>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

See http://people.gnome.org/~walters/docs/build-api.txt

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Julien Cristau <jcristau@debian.org>

Greg Turner authored Mar 24, 2014 and Julien Cristau committed Mar 24, 2014

Replicates Alan Coopersmith's fix for xinit.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74031

Signed-off-by: Julien Cristau <jcristau@debian.org>

Fix build failure with -Werror=format-security:
imake.c:1008:5: error: format not a string literal and no format arguments [-Werror=format-security]
     fprintf (inFile, command);
     ^
Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Add missing AC_CONFIG_SRCDIR
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Simply removing the definition lets the path found by configure be used,
seems to be the simplest way to handle the move from /usr/ccs/lib/cpp on
Solaris 10 and older to /usr/lib/cpp on Solaris 11 & later.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Another instance of the can-return-in-rare-cases nature of LogFatal()
raising red flags in static analysis.

Resolves warning from Parfait 1.0.1:
Error: File Leak
   File Leak: Leaked File inFile
        at line 1719 of imake.c in function 'cppit'.
          inFile initialized at line 1699 with fopen
          inFile leaks when inFile != NULL at line 1700
              and fprintf(inFile, "%s\n", "/* imake - temporary file */") < 0 at line 1702.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Imake's LogFatal() checks if it's being re-entered and if so, returns,
so we can't mark it NORETURN, leading to static analyzers believing it
can return even in call paths it shouldn't.

Resolves warning from Parfait 1.0.1:
Error: File Invalid
   File not Initialized: The value inFile is not initialized as a file.
        at line 748 of imake.c in function 'CheckImakefileC'.
          inFile initialized at line 738 with fopen(masterc, "r").
          inFile destroyed at line 745 with fclose(inFile).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Now that the log functions take variable arguments, don't need to pass
empty strings when there is no argument for the format string.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Allows use of printf attributes for checking format strings/arguments,
gets rid of LogFatalI wrapper just used for casting int to char *.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Adam Jackson authored Nov 01, 2010 and Peter Hutterer committed Nov 02, 2010

"find: warning: you have specified the -depth option after a non-option
argument -type, but options are not positional (-depth affects tests
specified before it as well as those specified after it).  Please specify
options before other arguments."
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Gaetan Nadon authored Oct 30, 2010 and Alan Coopersmith committed Oct 30, 2010

Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.

ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

We no longer need to maintain compatibility with the monolith
Imakefile -D flags in the sources.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

AC_PROG_CC, AC_PROG_SED, & AC_PROG_INSTALL are provided by
 XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

The '-p' option to mkdir(1) is required by SUSv2/Unix98, so we should be
able to rely on it on all systems we support.  Some parts need to be
left in place in order to not alter some of its ancient, shall we say,
quirks.
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Reviewed-by: Gaetan Nadon <gaetan.nadon@videotron.ca>