Skip to content
  • Keith Packard's avatar
    dix: Call screen block/wakeup handlers closest to blocking [v3] · fb1edccf
    Keith Packard authored
    
    
    The screen block and wakeup handlers are the only ones which provide a
    well known ordering between the wrapping layers; placing these as
    close as possible to the server blocking provides a way for the driver
    to control the flow of execution correctly.
    
    Switch the shadow code to run in the screen block handler so that it
    now occurrs just before the server goes to sleep.
    
    Switch glamor to call down to the driver after it has executed its own
    block handler piece, in case the driver needs to perform additional
    flushing work after glamor has called glFlush.
    
    These changes ensure that the following modules update the screen in
    the correct order:
    
    animated cursors        (uses RegisterBlockAndWakeupHandlers dynamically)
    composite               (dynamic wrapping)
    misprite                (dynamic wrapping)
    shadow                  (static wrapping)
    glamor                  (static wrapping)
    driver                  (static wrapping)
    
    It looks like there's still a bit of confusion between composite and
    misprite; if composite updates after misprite, then it's possible
    you'd exit the block handler chain with the cursor left hidden. To fix
    that, misprite should be wrapping during ScreenInit time and not
    unwrapping. And composite might as well join in that fun, just to make
    things consistent.
    
    [v2] Unwrap BlockHandler in shadowCloseScreen (ajax)
    [v3] ephyr: Use screen block handler for flushing changes
    
    ephyr needs to make sure it calls glXSwapBuffers after glamor finishes
    its rendering. As the screen block handler is now called last, we have
    to use that instead of a registered block/wakeup handler to make sure
    the GL rendering is done before we copy it to the front buffer.
    
    Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
    Reviewed-by: default avatarAdam Jackson <ajax@redhat.com>
    fb1edccf