1. 08 Feb, 2017 1 commit
    • Michael Thayer's avatar
      xfree86: Immediately handle failure to set HW cursor, v5 · c02f6a68
      Michael Thayer authored
      Based on v4 by Alexandre Courbot <acourbot@nvidia.com>
      
      There is currently no reliable way to report failure to set a HW
      cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM
      ioctl fails (which currently happens at least with modesetting on Tegra
      for format incompatibility reasons).
      
      As failures are currently handled by setting the HW cursor size to
      (0,0), the fallback to SW cursor will not happen until the next time the
      cursor changes and xf86CursorSetCursor() is called again. In the
      meantime, the cursor will be invisible to the user.
      
      This patch addresses that by adding _xf86CrtcFuncs::set_cursor_check and
      _xf86CursorInfoRec::ShowCursorCheck hook variants that return booleans.
      This allows to propagate errors up to xf86CursorSetCursor(), which can
      then fall back to using the SW cursor immediately.
      
      v5: Updated the patch to apply to current git HEAD, split up into two
      patches (server and modesetting driver) and adjusted the code slightly
      to match surrounding code.  I also removed the new exported function
      ShowCursorCheck(), as instead just changing ShowCursor() to return Bool
      should not affect its current callers.
      Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      Signed-off-by: Michael Thayer's avatarMichael Thayer <michael.thayer@oracle.com>
      c02f6a68
  2. 06 Feb, 2017 3 commits
  3. 28 Oct, 2016 1 commit
  4. 13 Oct, 2016 2 commits
    • Michel Dänzer's avatar
      xf86Cursor: Take the input lock in xf86Set/MoveCursor · 9cf0bd4d
      Michel Dänzer authored
      Prevents the HW cursor from intermittently jumping around when the
      cursor image is changed while the cursor is being moved. This is hardly
      noticeable in normal operation but can be quite confusing when stepping
      through these codepaths in a debugger.
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      9cf0bd4d
    • Michel Dänzer's avatar
      xf86Cursor: Use PRIME master xf86CursorScreenRec::HotX/Y for slaves · 011ce329
      Michel Dänzer authored
      xf86CursorScreenRec::HotX/Y contain 0 for PRIME slave screens.
      
      Fixes incorrect HW cursor position on PRIME slave screens.
      
      Also hoist the hotspot translation out from xf86ScreenSet/MoveCursor to
      xf86Set/MoveCursor, since the hotspot position is a property of the
      cursor, not the screen.
      
      v2:
      * Squash patches 1 & 2 of the v1 series, since it's basically the same
        problem
      * Use the master screen's xf86CursorScreenRec::HotX/Y instead of
        CursorRec::bits->x/yhot, since CursorRec::bits can be NULL (Hans de
        Goede)
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      011ce329
  5. 13 Sep, 2016 2 commits
  6. 30 Jun, 2015 1 commit
  7. 12 Nov, 2014 1 commit
  8. 25 Apr, 2014 1 commit
  9. 03 Apr, 2014 1 commit
  10. 12 Jan, 2014 1 commit
  11. 10 Jul, 2012 1 commit
  12. 21 May, 2012 1 commit
  13. 21 Mar, 2012 1 commit
    • Keith Packard's avatar
      Introduce a consistent coding style · 9838b703
      Keith Packard authored
      This is strictly the application of the script 'x-indent-all.sh'
      from util/modular. Compared to the patch that Daniel posted in
      January, I've added a few indent flags:
      
      	-bap
      	-psl
      	-T PrivatePtr
      	-T pmWait
      	-T _XFUNCPROTOBEGIN
      	-T _XFUNCPROTOEND
      	-T _X_EXPORT
      
      The typedefs were needed to make the output of sdksyms.sh match the
      previous output, otherwise, the code is formatted badly enough that
      sdksyms.sh generates incorrect output.
      
      The generated code was compared with the previous version and found to
      be essentially identical -- "assert" line numbers and BUILD_TIME were
      the only differences found.
      
      The comparison was done with this script:
      
      dir1=$1
      dir2=$2
      
      for dir in $dir1 $dir2; do
      	(cd $dir && find . -name '*.o' | while read file; do
      		dir=`dirname $file`
      		base=`basename $file .o`
      		dump=$dir/$base.dump
      		objdump -d $file > $dump
      	done)
      done
      
      find $dir1 -name '*.dump' | while read dump; do
      	otherdump=`echo $dump | sed "s;$dir1;$dir2;"`
      	diff -u $dump $otherdump
      done
      Signed-off-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
      Acked-by: Daniel Stone's avatarDaniel Stone <daniel@fooishbar.org>
      Acked-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      9838b703
  14. 20 Sep, 2011 1 commit
  15. 12 May, 2010 1 commit
  16. 06 Oct, 2008 1 commit
  17. 27 Aug, 2008 1 commit
  18. 06 May, 2008 1 commit
  19. 30 Aug, 2007 1 commit
  20. 28 Aug, 2007 1 commit
  21. 18 Dec, 2006 1 commit
  22. 17 Nov, 2006 1 commit
    • Peter Hutterer's avatar
      dix: moved isMPdev field to end of _DeviceIntRec structure · 94e106a8
      Peter Hutterer authored
      mi:
              added miMPPointers array to mipointer.c
              added DeviceIntPtr to all miPointerSpriteFuncs. Coming from miPointer
              we use inputInfo.pointer as standard value. ABI BREAK!
      
      ramdac:
              forcing failed HW Cursor initialisation. MPX needs software rendering.
              changes to use new miPointerSpriteFunc (this required externing
              inputInfo, should probably be fixed at a later point).
      
      RAC: changes to use new miPointerSpriteFuncs.
      94e106a8
  23. 21 Jul, 2006 1 commit
  24. 10 Feb, 2006 1 commit
  25. 03 Jul, 2005 2 commits
  26. 01 Jul, 2005 1 commit
  27. 20 Apr, 2005 1 commit
    • Daniel Stone's avatar
      Fix includes right throughout the Xserver tree: · 292c4cff
      Daniel Stone authored
      change "foo.h" to <X11/foo.h> for core headers, e.g. X.h, Xpoll.h;
      change "foo.h", "extensions/foo.h" and "X11/foo.h" to
          <X11/extensions/foo.h> for extension headers, e.g. Xv.h;
      change "foo.[ch]" to <X11/Xtrans/foo.[ch]> for Xtrans files.
      292c4cff
  28. 23 Apr, 2004 1 commit
  29. 14 Mar, 2004 1 commit
  30. 05 Mar, 2004 1 commit
  31. 03 Mar, 2004 1 commit
  32. 26 Feb, 2004 2 commits
  33. 26 Nov, 2003 1 commit
  34. 25 Nov, 2003 1 commit