- 08 Feb, 2017 3 commits
-
-
Michael Thayer authored
Based on v4 by Alexandre Courbot <acourbot@nvidia.com> There is currently no reliable way to report failure to set a HW cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM ioctl fails (which currently happens at least with modesetting on Tegra for format incompatibility reasons). As failures are currently handled by setting the HW cursor size to (0,0), the fallback to SW cursor will not happen until the next time the cursor changes and xf86CursorSetCursor() is called again. In the meantime, the cursor will be invisible to the user. This patch addresses that by adding _xf86CrtcFuncs::set_cursor_check and _xf86CursorInfoRec::ShowCursorCheck hook variants that return booleans. This allows to propagate errors up to xf86CursorSetCursor(), which can then fall back to using the SW cursor immediately. v5: Updated the patch to apply to current git HEAD, split up into two patches (server and modesetting driver) and adjusted the code slightly to match surrounding code. I also removed the new exported function ShowCursorCheck(), as instead just changing ShowCursor() to return Bool should not affect its current callers. Reviewed-by:
Adam Jackson <ajax@redhat.com> Signed-off-by:
Michael Thayer <michael.thayer@oracle.com>
-
Mihail Konev authored
Reviewed-by: -
Adam Jackson authored
Signed-off-by:
Michel Dänzer <michel.daenzer@amd.com>
-
- 07 Feb, 2017 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Olivier Fourdan <ofourdan@redhat.com>
-
- 06 Feb, 2017 3 commits
-
-
Chris Wilson authored
-
Chris Wilson authored
-
Chris Wilson authored
xf86RecolorCursor() may be called directly from XRecolorCursor as well as from xf86ScreenSetCursor(). In the latter case, the input lock is already held, but not for the former and so we need to add a wrapper function that acquires the input lock before performing xf86RecolorCursor() References: https://bugs.freedesktop.org/show_bug.cgi?id=99358
-
- 01 Feb, 2017 2 commits
-
-
Qiang Yu authored
This prevents the tearing of moving window in a composite WM desktop when output slave is attached but none of its crtc is really active. Signed-off-by:
Qiang Yu <Qiang.Yu@amd.com> Reviewed-by:
-
Michel Dänzer authored
This can happen when a module fails to load: Program received signal SIGSEGV, Segmentation fault. UnloadModule (_mod=0x5555559d9280) at ../../../../hw/xfree86/loader/loadmod.c:848 848 name = mod->VersionInfo->modname; (gdb) bt #0 UnloadModule (_mod=0x5555559d9280) at ../../../../hw/xfree86/loader/loadmod.c:848 #1 0x00005555555ddd1b in LoadModule (module=module@entry=0x5555559c7ce0 "fbdev", options=0x0, modreq=modreq@entry=0x0, errmaj=errmaj@entry=0x7fffffffe8ec) at ../../../../hw/xfree86/loader/loadmod.c:824 #2 0x00005555555edfe9 in xf86LoadModules (list=list@entry=0x5555559dcf50, optlist=optlist@entry=0x0) at ../../../../hw/xfree86/common/xf86Init.c:1506 #3 0x00005555555ee7bc in InitOutput (pScreenInfo=pScreenInfo@entry=0x5555559abf80 <screenInfo>, argc=argc@entry=4, argv=argv@entry=0x7fffffffeb18) at ../../../../hw/xfree86/common/xf86Init.c:484 #4 0x00005555555a885c in dix_main (argc=4, argv=0x7fffffffeb18, envp=<optimized out>) at ../../dix/main.c:197 #5 0x00007ffff5d582b1 in __libc_start_main (main=0x555555593130 <main>, argc=4, argv=0x7fffffffeb18, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffeb08) at ../csu/libc-start.c:291 #6 0x000055555559316a in _start () Fixes: 8e83eacb ("loader: Remove unused path and name from ModuleDescPtr") Signed-off-by:
-
- 25 Jan, 2017 24 commits
-
-
Qiang Yu authored
V2: 1. update comment 2. check bustype if PCI 3. configure add libdrm version check for drmGetDevice Get PCI information from info->fd with drmGetDevice instead of assuming the info->fd is the first entity of scrn which is not true for multi entities scrn. Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com>
-
Martin Peres authored
Classic GNU ld resolves symbol dependencies only forward, while GOLD seems to work regardless of the specified library order. Suggested-by:
Eero Tamminen <eero.t.tamminen@intel.com> Reviewed-by:
Mihail Konev <k.mvc@ya.ru> Signed-off-by:
Martin Peres <martin.peres@linux.intel.com>
-
Adam Jackson authored
Reviewed-by:
Julien Cristau <jcristau@debian.org> Signed-off-by:
-
Adam Jackson authored
Just a waste of memory. Path was never referenced at all, and name was only used when unloading the module; we can just as well get the module's internal idea of its name from VersionInfo. Reviewed-by:
-
Adam Jackson authored
Nobody was ever calling this with a non-null argument for subdir list or pattern list. Having done this, InitSubdirs is only ever called with a NULL argument, so it's really just a complicated way of duplicating the default list; we can remove that and just walk the list directly. The minor error code was only ever used to distinguish among two cases of LDR_BADUSAGE. Whatever. Reviewed-by:
-
Adam Jackson authored
Callers only ever use this for a single directory anyway. While we're at it, also move xf86DriverListFromCompile near its only user in the X -configure code (and inline it out of existence), and remove LoaderFreeDirList as it's unused (since X -configure is just going to exit anyway, none of that code cares about cleanup). Reviewed-by:
-
Adam Jackson authored
There's no reason a driver should ever care about this. Reviewed-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
-
Adam Jackson authored
Reviewed-by:
-
Adam Jackson authored
indent(1) gets confused by function-like macros with no trailing semicolon, which is fair enough really. Reviewed-by:
-
Adam Jackson authored
The idea here is that the driver might have once been old enough to not have the driverFunc slot in DriverRec, with the module ABI not having changed when it was added. That was ages ago, and drivers always declare themselves with DriverRec not DriverRec1, so uninitialized slots will simply be zero. Reviewed-by:
-
Adam Jackson authored
Everybody using this functionality specifies a major version, which makes sense. If you don't care about a minor version, that's equivalent to saying you require minor >= 0, so just say so; likewise patch level. Likewise ABI class is always specified. Reviewed-by:
-
Adam Jackson authored
The enum has been unused since at least the removal of elfloader. Reviewed-by:
-
Adam Jackson authored
This looks like more, but only if you don't compare it to the number pulled in by misc.h. Reviewed-by:
-
Adam Jackson authored
Reviewed-by:
-
Adam Jackson authored
This API is dumb. uname(3) exists, feel free to use it, but ideally write to the interface not to the OS. There are a couple of drivers using this API, they could all reasonably just not. This also removes the OS name from the loader subdirectory path search. Having /usr/lib/xorg shared across OSes is a non-goal here. Reviewed-by:
-
Adam Jackson authored
Reviewed-by:
-
Emil Velikov authored
Now that users can set the path only via LoaderSetPath(), we can simplify things. Reviewed-by:
-
Emil Velikov authored
Reviewed-by:
-
Emil Velikov authored
Afaics the argument hasn't been part of the API since the documentation has been converted to xml with commit fc6ebe1e "Convert LinuxDoc documents to DocBook/XML" Reviewed-by:
-
Emil Velikov authored
Similar to its little brother - LoadSubModule. Currently all call sites provide NULL anyway ;-) Reviewed-by:
Aaron Plattner <aplattner@nvidia.com> Reviewed-by:
-
Adam Jackson authored
Should you find yourself using a 16bpp display while also using a compositor, you poor soul, you may find that your GLX applications behave strangely; in particular, glxgears will be transparent. This is because it clears to (0,0,0,0) which is transparent if you honor alpha, and it will choose the synthetic visual because it has the most available r/g/b bits. To avoid this, bump synthetic visuals to a higher (less-preferred) select group. Unless the client explicitly asks for non-zero alpha bits, this will prefer any rgb565 visual ahead of the argb8888 visual. Reviewed-by:
-
Adam Jackson authored
We already send this for fbconfigs. Mesa happens to implement glXChooseVisual relative to the fbconfig data, but that might not be true of NVIDIA's libGL. Reviewed-by:
-
Adam Jackson authored
Reviewed-by:
-
Adam Jackson authored
This comment is above compIsAlternateVisual, which used to be the only thing determining whether implicit redirect was needed. It's not anymore due to the redirection exception list. That job is now performed by compImplicitRedirect, whose code is self-explanitory. Reviewed-by:
-
- 24 Jan, 2017 1 commit
-
-
Olivier Fourdan authored
When selecting "CA_TWO_PASS" in glamor_composite_clipped_region() when the hardware does not support "GL_ARB_blend_func_extended", we call glamor_composite_choose_shader() twice in a row, which in turn calls glamor_pixmap_ensure_fbo(). On memory pixmaps, the first call will set the FBO and the second one will fail an assertion in glamor_upload_picture_to_texture() because the FBO is already set. Bail out earlier when the mask pixmap is in memory and the hardware capabilities would require to use two pass, so that the assertion is not failed and the rendering is correct. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99346Signed-off-by:
-
- 19 Jan, 2017 2 commits
-
-
Adam Jackson authored
Use evdev. Reviewed-by:
-
Adam Jackson authored
Use evdev. Reviewed-by:
-
- 16 Jan, 2017 4 commits
-
-
Mihail Konev authored
Remove redundrant/incorrect automake assignment. Buglink: https://lists.x.org/archives/xorg-devel/2017-January/052320.htmlReported-by:
Jon Turney <jon.turney@dronecode.org.uk>
-
Giuseppe Bilotta authored
Signed-off-by:
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Reviewed-by:
-
Adam Jackson authored
Pushed the wrong thing. This reverts commit 730fd8c0.
-
Mihail Konev authored
-
