From bad94e88cef8b692982ed0af112e7b2191ba558b Mon Sep 17 00:00:00 2001
From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Date: Sun, 24 Mar 2019 02:06:59 +0300
Subject: [PATCH] xkbtext: fix copy-paste error
As can be seen in diff, nOut is always 0 here. The code was likely
copy-pasted from comparisons further below.
Fixes LGTM warning "Comparison is always false because nOut <= 0."
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
---
xkb/xkbtext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xkb/xkbtext.c b/xkb/xkbtext.c
index 00a26c5767..fb17f513e8 100644
--- a/xkb/xkbtext.c
+++ b/xkb/xkbtext.c
@@ -967,8 +967,7 @@ CopySetLockControlsArgs(XkbDescPtr xkb, XkbAction *action, char *buf, int *sz)
int nOut = 0;
if (tmp & XkbRepeatKeysMask) {
- snprintf(tbuf, sizeof(tbuf), "%sRepeatKeys", (nOut > 0 ? "+" : ""));
- TryCopyStr(buf, tbuf, sz);
+ TryCopyStr(buf, "RepeatKeys", sz);
nOut++;
}
if (tmp & XkbSlowKeysMask) {
--
GitLab