Commit a5dc3531 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Keith Packard
Browse files

Revert "composite: Convert compWindowUpdate to use TraverseTree"

TraverseTree visits the parent before the children. When performing
the automatic redirection updates, the children must be visited before
the parent.

If there are automatically redirected windows on multiple levels of the
tree, updating the parents before the children would cause the parent
updates to use stale data for areas covered by the children. Also
updating the damaged children would re-damage the parent, which would
cause additional walks over the tree.

In the worst case with an unbroken chain of automatically redirected
subwindows, all of which are damaged, only the leaf window would be
properly updated on the first round. Then it's parent would be properly
updated on the second round, and so on. And on every round all of the
ancestor windows would be updated as well, but with stale data.
So with N damaged windows you would end up with (N^2+N)/2 updates,
instead of the expected N.

This reverts commit 648c8871

Signed-off-by: default avatarVille Syrjälä <>
Reviewed-by: Keith Packard's avatarKeith Packard <>
Reviewed-by: Daniel Stone's avatarDaniel Stone <>
Signed-off-by: Keith Packard's avatarKeith Packard <>
parent 09985746
......@@ -653,9 +653,10 @@ compWindowFormat (WindowPtr pWin)
static void
compWindowUpdateAutomatic (WindowPtr pWin, ScreenPtr pScreen)
compWindowUpdateAutomatic (WindowPtr pWin)
CompWindowPtr cw = GetCompWindow (pWin);
ScreenPtr pScreen = pWin->drawable.pScreen;
WindowPtr pParent = pWin->parent;
PixmapPtr pSrcPixmap = (*pScreen->GetWindowPixmap) (pWin);
PictFormatPtr pSrcFormat = compWindowFormat (pWin);
......@@ -678,7 +679,8 @@ compWindowUpdateAutomatic (WindowPtr pWin, ScreenPtr pScreen)
* First move the region from window to screen coordinates
RegionTranslate(pRegion, pWin->drawable.x, pWin->drawable.y);
pWin->drawable.x, pWin->drawable.y);
* Clip against the "real" border clip
......@@ -688,7 +690,8 @@ compWindowUpdateAutomatic (WindowPtr pWin, ScreenPtr pScreen)
* Now translate from screen to dest coordinates
RegionTranslate(pRegion, -pParent->drawable.x, -pParent->drawable.y);
-pParent->drawable.x, -pParent->drawable.y);
* Clip the picture
......@@ -717,26 +720,23 @@ compWindowUpdateAutomatic (WindowPtr pWin, ScreenPtr pScreen)
DamageEmpty (cw->damage);
static int
compWindowUpdateVisit(WindowPtr pWin, void *data)
compWindowUpdate (WindowPtr pWin)
WindowPtr pChild;
for (pChild = pWin->lastChild; pChild; pChild = pChild->prevSib)
compWindowUpdate (pChild);
if (pWin->redirectDraw != RedirectDrawNone)
CompWindowPtr cw = GetCompWindow(pWin);
CompWindowPtr cw = GetCompWindow(pWin);
if (cw->damaged)
compWindowUpdateAutomatic(pWin, data);
compWindowUpdateAutomatic (pWin);
cw->damaged = FALSE;
compWindowUpdate (WindowPtr pWin)
TraverseTree(pWin, compWindowUpdateVisit, pWin->drawable.pScreen);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment