Commit 55c87444 authored by Adam Jackson's avatar Adam Jackson 🎧
Browse files

wip: leave myself some notes

parent 6db8fabd
Pipeline #321772 failed with stages
in 2 minutes and 7 seconds
......@@ -79,6 +79,23 @@ egl_screen_destroy(__GLXscreen *_screen)
free(_screen);
}
static __GLXcontext *
egl_create_context(__GLXscreen *screen, __GLXconfig *modes,
__GLXcontext *shareContext, unsigned num_attribs,
const uint32_t *attribs, int *error)
{
// biggest question i guess is whether to share with the glamor
// context or not. i feel like no, otherwise every context shares
// with every other and that seems bad, and we should have a sharing
// api for dri3 already.
//
// should set it up so the egl context is always no-flush and we manage
// the glx flushes explicitly.
*error = BadImplementation;
return NULL;
}
static void
egl_drawable_destroy(__GLXdrawable *draw)
{
......@@ -105,6 +122,13 @@ egl_drawable_wait_x(__GLXdrawable *draw)
static void
egl_drawable_wait_gl(__GLXdrawable *draw)
{
// this should be something like
//
// if draw->drawCurrentContext->indirect
// make that current and flush it
//
//
// note that the above back pointer does not exist
}
static __GLXdrawable *
......@@ -167,7 +191,13 @@ translate_eglconfig(struct egl_screen *screen, EGLConfig hc,
c->base.sRGBCapable = 0;
c->base.swapMethod = GLX_SWAP_UNDEFINED_OML;
/* this is... suspect */
/*
* this is... definitely wrong. if you have float-pixel egl configs
* this will say they can be turned into glx windows, which is super
* not right. what you'd really like here is ARB_internalformat_query2,
* which has enough of a subset working in gles3 but there's no gles2
* extension for it even in Mesa, which is annoying.
*/
c->base.drawableType = GLX_WINDOW_BIT | GLX_PIXMAP_BIT | GLX_PBUFFER_BIT;
/* hmm */
......@@ -353,6 +383,7 @@ egl_screen_probe(ScreenPtr pScreen)
base = &screen->base;
base->destroy = egl_screen_destroy;
base->createDrawable = egl_create_glx_drawable;
base->createContext = egl_create_context;
/* base.swapInterval = NULL; */
screen->display = glamor_screen->ctx.display;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment