This requires adding new protocol to pass the width/height/layers/sample
default values from the host.

enable fb no attach 31

Add a capability and some queries to expose compute shaders
to the host.

compute add one more check

This adds protocol for dispatch compute shaders using
the launch grid command from gallium.

For compute shaders we put the req local memory into the streamout
places in the protocol, and we create compute shaders in a separate
lookup function

This mostly consists of adding local memory support, and
support for the compute system values.

The req_local_mem need to be gotten from the host side
and passed into the shader compile so we can size the
shared memory correctly.

This should expose GL4.2 on the host now.

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

GL4.2/GLES3.1 adds glMemoryBarrier so make sure we can handle it.

v2: add a cap bit for this for guest

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

This lets the guest know it can use the TXQS opcode

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

This adds support for the TXQS opcode, and RESQ	w channel

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

This adds support for tracking images, and binding them
to the GL context.

includes:
vrend_renderer: create texture when TBO is used as image
vrend_renderer: specify correct access to glBindImageTexture

v2:
vrend_renderer: invert glBindImageTexture layered logic

v3: fix decode macros (Gert pointed out for ssbo)

v4: add max image samples to the caps.
add image arrays.
use mask var outside loop (Gert)
change img_locs type to GLint and printf on fail (Gert)

Co-authors: Gurchetan Singh <gurchetansingh@chromium.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

As part of shader image support we need to support this property.

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

This converts the image related opcodes, and tracks the used
images.

Images need some extensions for extra features:
ES_3_1_compatability is needed for r32f image support
shader_image_size for image size support

v2: image: fix missing emit for atomic,
use a shader req for images extension
extend cas_str - we overflowed this
v2.1: drop extra breaks, use decl last for range check (Tomeu)
v3: add indirect support,
    drop pointless debug print (Gert)

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

This just brings over some defines from the gallium codebase.

Co-authors: Gurchetan Singh <gurchetansingh@chromium.org>

Reviewed-By: Gert Wollny <gert.wollny@collabora.com>

This avois them overflowing when we have long swizzled gl_
which happens more with compute shaders and images

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

v3: Correct gl_ver parameter for vrend_renderer_fill_caps_gl (Gurchetan)
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
[airlied: remove some extra whitespace]
Signed-off-by: Dave Airlie <airlied@redhat.com>

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

The values are set to zero by clearing the structure, no need to set
them individually.

v2: - Don't remove max_viewports initialization (Erik)
    - remove some more zero-initializations

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

Gert Wollny authored Jul 26, 2018 and Jakob Bornecrantz committed Jul 26, 2018

If the client sends vrend_transfer_send_readpixels a stride (and vtest does),
then it is in bytes, but glPixelStorei(GL_PACK_ROW_LENGTH, stride) expects
the value to be pixels.

Fixes:
   42e2a4ca
   vrend: use the row-stride when directly reading back to an IOV

Tested-by: Jakob Bornecrantz <jakob@collabora.com>
Reviewed-by: Jakob Bornecrantz <jakob@collabora.com>
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Signed-off-by: Jakob Bornecrantz <jakob@collabora.com>

Currently based on feat_multisample, but glSampleMaski isn't supported
with the same versions.

v2: Update to use new feature code.

Signed-off-by: David Riley <davidriley@chromium.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>

Pointed out by Gert on the mesa review.

Gert Wollny authored Jul 18, 2018 and Jakob Bornecrantz committed Jul 26, 2018

When guest mesa does a glReadPixel call, it expects the data to be placed
with correct row strides into the readback buffer. While for calls that
invert or require more then one IOV this is done in write_transfer_data,
for a read that only uses a small area and offset making it fit into the
first IOV this was not done. Consequently, in this case configure the
PACK_ROW_LENGTH accordingly.

v2: fix whitespace issues

This fixes a number of piglits:
   arb_copy_image-targets (for texture_2d source or dest, non-compressed)
   arb_get_texture_multisample/sample_position
   arb_texture_rectangle/fbo-blit rect
   arb_get_texture__sub_image-cubemap

Reviewed-by: Elie Tournier <elie.tournier@collabora.com>
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Signed-off-by: Jakob Bornecrantz <jakob@collabora.com>

We forgot to set scissor_state_dirty when we disable GL_SCISSOR_TEST
in vrend_renderer_blit_int. This fixes bug mentioned in
https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001230.html



Signed-off-by: Lepton Wu <lepton@chromium.org>
Reviewed-by: Dave Airlie <airlied@redhat.com>

These VREND_BIND_*-flags here are basically a subset of the
VIRGL_BIND_*-flags, with one custom flag added. So let's just use
those, and use an unused big from the others for the swizzle-flag.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>

This copy of the bind-flags should not be used, as they are a duplicate
set of what can already be found in virgl_hw.h.

But to avoid breaking theoretical, unknown users, we shouldn't remove
them either. So let's just add a comment to tell people not to use
them.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>

These are identical to the corresponding VIRGL_BIND-flags,
so let's get rid of this duplicate definition.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>

Mesa have these in it's virgl_hw.h copy, and the values needs to
stay in sync between mesa and virglrenderer here. So let's add this
definition here, where it can be defined only once.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>

fix inverted logic (Gert)

don't bind ubos if we don't have feature

v2: fix inverted logic (Gert)

This just stops us binding any transform feedback if we don't support it

v2: gles fixups (Gert)

Don't allow multisample texture creation without feature

Don't allow cube map array creation unless feature supported.

v2: add exts (Gert)

Don't allow array textures to be created if we don't support the feature

Protect against inverted enums getting used without feature enabled.

Reviewed-By: Gert Wollny <gert.wollny@collabora.com>

Also remove a double break; while here.

Reviewed-by: Gert Wollny <gert.wollny@collabora.com>