- 04 Apr, 2019 1 commit
-
-
Emma Anholt authored
Fixes #678 Signed-off-by:
Eric Anholt <eric@anholt.net>
-
- 02 Apr, 2019 2 commits
-
-
If the user sets Option "Enable" "TRUE" for a monitor, the X server will connect the connector a crtc but tell the user it is disconnected. However the user in this case is mutter, when it gets it's view of the output configuration it sees the output is disconnected and never sets it up again, which seems like the right thing to do. If we let the user enable a monitor, lets just set it as always connected. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com> Signed-off-by:
Dave Airlie <airlied@redhat.com>
-
Jon Turney authored
-
- 01 Apr, 2019 3 commits
-
-
Up to twice, for a total of 3 attempts maximum. This will hopefully avoid spurious CI pipeline failures due to intermittent GitLab/docker infrastructure issues. Inspired by mesa/mesa@6140ed3d Reviewed-by:
Eric Anholt <eric@anholt.net>
-
Drop the verbose test log output, matching the meson job script. Reviewed-by:
Eric Anholt <eric@anholt.net>
-
This way, the second ninja command line will be visible again as well in the job output. Reviewed-by:
Eric Anholt <eric@anholt.net>
-
- 29 Mar, 2019 2 commits
-
-
This cleans up some code duplication. No functional change. Signed-off-by:
Roman Gilg <subdiff@gmail.com> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com>
-
Peter Hutterer authored
Terms: dev->last.valuator[] is the last value given to us by the driver dev->valuator.axisVal[] is the last value sent to the client dev->last.scroll[] is the abs value of the scroll axis as given by the driver, used for button emulation calculation (and the remainder) This function updates the device's last.valuator state based on the current master axis state. This way, relative motion continues fluidly when switching between devices. Before mouse 2 comes into effect, it's valuator state is updated to wherever the pointer currently is so the relative event applies on top of that. This can only work for x/y axes, all other axes aren't guaranteed to have the same meaning and/or may not be present: - xtest device: no valuator 2 - mouse: valuator 2 is horizontal scroll axis - tablet: valuator 2 is pressure Scaling the current value from the pressure range into the range for horizontal scrolling makes no sense. And it causes scroll jumps: - scroll down, last.valuator == axisVal == 20 - xdotool click 1, the XTest device doesn't have that valuator - scroll up - updateSlaveDeviceCoords reset last.valuator to 0 (axisVal == 20) - DeviceClassesChangedEvent includes value 20 for the axis - event is processed, last.value changes from 0 to -1 - axisVal is updated to -1, causing a jump of -21 The same applies when we switch from tablet to mouse wheel if the pressure value is 0 on proximity out (basically guaranteed). So let's drop this code altogether and only leave the scaling for the relative x/y motion. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 28 Mar, 2019 8 commits
-
-
Emma Anholt authored
Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
I keep wanting this when reviewing people's glamor patches. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
For really testing glamor, we want it installed. Use master instead of whatever version is in repos, because we'll want to update when new tests are added. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
We only check out master, and delete .git when we're done, so save the bandwidth. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
We don't use any of piglit's tests, just the framework. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
We need the DRI swrast driver (for GLX in vfb), and also libgl (for libepoxy in glamor) Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
We cover all Render ops under the "blend" group, so when we're doing the cross products of some formats for the masking operation, skip most of the ops (covering just zero, one, and src/dst alpha blend factors along with a definitely non-glamor-accelerated one) . All the tests now complete in <20s of runtime on my skylake. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
This gets us parallelism between rendercheck tests at the cost of spinning up more Xvfbs, and nicer logging of the tests that are run. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
- 27 Mar, 2019 6 commits
-
-
Emma Anholt authored
I've found that it's hard to find the original error in a dump full of xserver debug spam for the passing cases, and when I needed to look at this I end up using a proper editor on the file from the artifacts view anyway. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
Michel noted that I could do this instead of bumping the tag as I developed, so leave that note for the next person. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
For testing xephyr-glamor on top of Xvfb in CI better, I want to be able to make one command line describing the nested server invocation, but that means I need to get two simple-xinits to split client/server on different "--" arguments. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
Emma Anholt authored
Early fatal errors may leave us with nothing in the displayfd pipe, and we'd block forever. Signed-off-by:
Eric Anholt <eric@anholt.net>
-
There shouldn't be a difference for users, but this way we do manage all of our containers from freedesktop.org Signed-off-by:
Benjamin Tissoires <benjamin.tissoires@gmail.com> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com>
-
- 20 Mar, 2019 2 commits
-
-
Michael Biebl authored
systemd-logind since version 234 (released 2017-07-12) supports being restarted without losing state [1]. From the systemd NEWS file [2]: * systemd-logind may now be restarted without losing state. It stores the file descriptors for devices it manages in the system manager using the FDSTORE= mechanism. Please note that further changes in other components may be required to make use of this (for example Xorg has code to listen for stops of systemd-logind and terminate itself when logind is stopped or restarted, in order to avoid using stale file descriptors for graphical devices, which is now counterproductive and must be reverted in order for restarts of systemd-logind to be safe. See https://cgit.freedesktop.org/xorg/xserver/commit/?id=dc48bd653c7e101.) This reverts commit dc48bd65. Closes: #531 [1] https://github.com/systemd/systemd/pull/5600 [2] https://github.com/systemd/systemd/commit/9f09a95a7e6127f526c0ef7b6fd060cc0b01cdcc
-
Applying get_pkgconfig_variable() to a not-found dependency was always documented as an error, but meson 0.49 now actually raises an error[1]: meson.build:110:4: ERROR: 'xkbcomp' is not a pkgconfig dependency Check xkbcomp_dep is a suitable dependency type before applying get_pkgconfig_variable() to it. [1] but this is more by accident than design (see the discusssion at [2] et seq.), so who knows where things will come to rest... [2] https://github.com/mesonbuild/meson/pull/4444#issuecomment-442443301
-
- 15 Mar, 2019 1 commit
-
-
If they don't, flipping will result in corrupted display. Test case: * Run Xorg at 1920x1080 with no window manager * glxgears -geometry 2048x1080
-
- 14 Mar, 2019 1 commit
-
-
Drop some code conditional on meson version, which is not needed since 7e046b94 bumped the minimum meson version
-
- 13 Mar, 2019 2 commits
-
-
Jon Turney authored
stub os support also needs to provide xf86OSInputThreadInit, omitted in ea1527a8
-
xwl_present_cleanup frees the struct xwl_present_window memory, so if there's a pending callback, we have to destroy it to prevent use-after-free in xwl_present_sync_callback. Should fix issue #645. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com>
-
- 11 Mar, 2019 3 commits
-
-
This is maybe one more comparison, but it catches FullyObscured windows slightly earlier, so it's kind of a wash. The important thing is this allows for paintable but unmapped windows, which will have non-empty clipList.
-
No functional change, just folding some conditionals together.
-
If `_glamor_create_tex()` fails to allocate the FBO because of GL_OUT_OF_MEMORY error, the `pixmap_priv->fbo` is NULL. However, `glamor_get_pixmap_texture()` doesn't actually check whether the `pixmap_priv->fbo` is NULL and will segfault with a NULL pointer dereference trying to access the `pixmap_priv->fbo->tex`. Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Closes: xorg/xserver#647
-
- 08 Mar, 2019 4 commits
-
-
Paul Kocialkowski authored
We currently support two modes of operation for RW PBO buffers: one that allocates a pack buffer with GL memory and one that uses system memory when the former is not supported. Since allocation with system memory is less likely to fail, add a fallback to system memory when GL memory failed instead of bailing out. Signed-off-by:
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
-
Paul Kocialkowski authored
glamor_prepare_access can fail for a few reasons, especially when failing to allocate a PBO buffer. Take this in account and bail in the copy helpers that call the helper when a failure happens. Signed-off-by:
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
-
Paul Kocialkowski authored
Packed buffer allocation (which happens at glBufferData time with the buffer bound) can fail when there is no GL memory left. Pick up the error when it happens, print a proper error message, do some cleanup and bail. Signed-off-by:
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
-
Paul Kocialkowski authored
When uploading a picture to a texture, glamor_upload_picture_to_texture calls glamor_pixmap_ensure_fbo to ensure that there is backing FBO. The FBO will be allocated if the picture's drawable pixmap does not have one already, which can fail when there is no GL memory left. glamor_upload_picture_to_texture checks that the call succeeded and will enter the failure path if it did not. However, unlike many other functions in glamor, this one has ret set to TRUE initially, so it needs to be set to FALSE when a failure happens. Otherwise, the error is not propagated and the failure path return TRUE. This leads to a fault when trying to access the FBO pointer later on. Signed-off-by:
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
-
- 06 Mar, 2019 1 commit
-
-
Normally, the X server infers the initial screen size based on any connected outputs. However, if no outputs are connected, the X server picks a default screen size of 1024 x 768. This option overrides the default screen size to use when no outputs are connected. In contrast to the "Virtual" Display SubSection entry, which applies unconditionally, "NoOutputInitialSize" is only used if no outputs are detected when the X server starts. Parse this option in the new exported helper function xf86AssignNoOutputInitialSize(), so that other XFree86 loadable drivers can use it, even if they don't use xf86InitialConfiguration(). Signed-off-by:
Andy Ritger <aritger@nvidia.com> Reviewed-by:
Keith Packard <keithp@keithp.com>
-
- 05 Mar, 2019 1 commit
-
-
Adam Jackson authored
We were being naughty: WARNING: Project specifies a minimum meson_version '>= 0.42.0' but uses features which were added in newer versions: * 0.46.0: {'compiler.has_multi_link_argument', 'compiler.has_link_argument'}
-
- 27 Feb, 2019 1 commit
-
-
This reverts commit 8694395f. Some scenarios have come to light where this failed to ensure the docker image exists: * If the master branch of a forked repository is used for an MR which doesn't modify .gitlab-ci.yml, the docker-image job may not run. * If the docker-image job of the first pipeline in a forked repository is cancelled or fails for any reason, and .gitlab-ci.yml isn't modified for the next pipeline run.
-
- 25 Feb, 2019 2 commits
-
-
Since the Solaris kernel tracks IOPL per thread, and doesn't inherit raised IOPL levels when creating a new thread, we need to turn it on in the input thread for input drivers like vmmouse that need register access to work correctly. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Allows os backends to run additional code as necessary to set up the input thread. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-