• Tobias Deiminger's avatar
    More review fixes · d4b4be23
    Tobias Deiminger authored
    Text color is indicated by nonstroking color in graphics state
    	Assumption: Text rendering mode is 'fill'.
    
    Increase color precision for lossless roundtrip of 16 bit integers
    	Our API takes QColor from user. We want to support a lossless roundtrip
    	of QColor (16 bit per channel internally) through document save and
    	load, and empirically found .5f is best match.
    
    Check only .5f case of color channel roundtrip. Include 65535.
    	We check if precision == 5 is sufficient, and fail if not. We know that
    	precision < 5 will never work, because target set contains less numbers
    	than uint16 range.
    
    Use smart pointer in textFont and textColor
    
    Add test for CMYK QColor roundtrip
    
    Support QColor::Cmyk to AnnotColor::colorCMYK conversion
    
    Add simple test for font size. Fix actual/expected args.
    
    Model font name as class Object, type objName
    	Take into account that ISO 32000 says Tf operand is always an object of
    	PDF type "name". Further benefit: class Object introduces ownership
    	semantcis.
    
    Use more std::unique_ptr and fix some coding syle
    	Some places assumed ownership implicitely. Make it more explicit.
    
    Move parse/constructAppearanceString into DefaultAppearance
    	We gain cohesion and automatic memory management.
    
    Fix minor styling issues
    
    Use std::make_unique from C++14
    d4b4be23
Name
Last commit
Last update
cmake/modules Loading commit data...
cpp Loading commit data...
fofi Loading commit data...
glib Loading commit data...
goo Loading commit data...
poppler Loading commit data...
qt5 Loading commit data...
regtest Loading commit data...
splash Loading commit data...
test Loading commit data...
utils Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
AUTHORS Loading commit data...
CMakeLists.txt Loading commit data...
COPYING Loading commit data...
COPYING3 Loading commit data...
ConfigureChecks.cmake Loading commit data...
INSTALL Loading commit data...
NEWS Loading commit data...
README Loading commit data...
README-XPDF Loading commit data...
README.contributors Loading commit data...
config.h.cmake Loading commit data...
gtkdoc.py Loading commit data...
make-glib-api-docs Loading commit data...
poppler-cairo.pc.cmake Loading commit data...
poppler-cpp.pc.cmake Loading commit data...
poppler-glib.pc.cmake Loading commit data...
poppler-qt5.pc.cmake Loading commit data...
poppler-splash.pc.cmake Loading commit data...
poppler.pc.cmake Loading commit data...