1. 21 Sep, 2018 2 commits
  2. 02 Sep, 2018 4 commits
    • Albert Astals Cid's avatar
      Add missing (C) · 042d2483
      Albert Astals Cid authored
      And minor style change by Albert
      042d2483
    • Tobias Deiminger's avatar
      More review fixes · d4b4be23
      Tobias Deiminger authored
      Text color is indicated by nonstroking color in graphics state
      	Assumption: Text rendering mode is 'fill'.
      
      Increase color precision for lossless roundtrip of 16 bit integers
      	Our API takes QColor from user. We want to support a lossless roundtrip
      	of QColor (16 bit per channel internally) through document save and
      	load, and empirically found .5f is best match.
      
      Check only .5f case of color channel roundtrip. Include 65535.
      	We check if precision == 5 is sufficient, and fail if not. We know that
      	precision < 5 will never work, because target set contains less numbers
      	than uint16 range.
      
      Use smart pointer in textFont and textColor
      
      Add test for CMYK QColor roundtrip
      
      Support QColor::Cmyk to AnnotColor::colorCMYK conversion
      
      Add simple test for font size. Fix actual/expected args.
      
      Model font name as class Object, type objName
      	Take into account that ISO 32000 says Tf operand is always an object of
      	PDF type "name". Further benefit: class Object introduces ownership
      	semantcis.
      
      Use more std::unique_ptr and fix some coding syle
      	Some places assumed ownership implicitely. Make it more explicit.
      
      Move parse/constructAppearanceString into DefaultAppearance
      	We gain cohesion and automatic memory management.
      
      Fix minor styling issues
      
      Use std::make_unique from C++14
      d4b4be23
    • Tobias Deiminger's avatar
      Fix open review comments from #50 · db0451ab
      Tobias Deiminger authored
      Make fontTag optional for AnnotFreeText::parseAppearanceString.
      Handle fontColor == nullptr in AnnotFreeText::constructAppearanceString.
      Use AnnotAppearanceBuilder in AnnotFreeText::constructAppearanceString.
      Delete copy assignment operator for DefaultAppearance.
      Rename setAppearanceString to setDefaultAppearance.
      db0451ab
    • Dileep Sankhla's avatar
      Add annotation font color · 64531344
      Dileep Sankhla authored
      64531344
  3. 24 Apr, 2018 1 commit
  4. 06 Apr, 2018 1 commit
  5. 05 Apr, 2018 3 commits
  6. 23 Mar, 2018 1 commit
  7. 08 Jan, 2018 1 commit
    • Albert Astals Cid's avatar
      Delete lots of copy constructors and copy assignment operators · 8794789a
      Albert Astals Cid authored
      Fixes rule-of-three and copyable-polymorphic warnings reported by clazy.
      
      The default copy constructor and copy assignment operator are
      only valid for simple classes so we delete them (i.e. make then not exist)
      when we have either a virtual class or a destructor, the code still compiles
      so this doesn't fix any bug, it is more a protection for when you think you
      can copy a class and don't realize the default copy constrcutor is not doing
      what you want and you get crashes. Hopefully this helps us in the future :)
      8794789a
  8. 03 Nov, 2017 1 commit
  9. 21 Oct, 2017 1 commit
  10. 12 May, 2017 1 commit
  11. 08 May, 2017 1 commit
    • Albert Astals Cid's avatar
      New Object API · 9773c153
      Albert Astals Cid authored
      Implement the move operators and copy construtor
      
      Almost all the init() functions are gone and we just have simple
      constructors now
      
      Also made free() public since you're not supposed to call it anymore,
      unless you're being evil and malloc'ing Objects like Array/Dict/XRef
      
      This has a huge reaction chain, most importantly we
      don't get objects by passing a pointer Object parameter, we
      just get the object as a return value, which is a much clearer API
       -  aobj->copy(&obj);
       +  obj = aobj->copy();
      before I was never sure what was being copied into what
      
      Comes with a huge diff, I probably made some mistake in the porting
      since there was lots of copy & paste involved
      9773c153
  12. 08 Mar, 2017 1 commit
  13. 06 Sep, 2016 1 commit
  14. 01 Jun, 2016 1 commit
  15. 13 Aug, 2015 2 commits
  16. 14 May, 2015 1 commit
  17. 18 Apr, 2015 1 commit
  18. 05 Dec, 2013 3 commits
  19. 24 Aug, 2013 2 commits
  20. 01 Jul, 2013 2 commits
  21. 30 Jun, 2013 3 commits
    • Fabio D'Urso's avatar
      qt4: FixedRotation annotations' coordinate conversion · cf950a2b
      Fabio D'Urso authored
      FixedRotation(=flagNoRotate) annotations use a different coordinate
      system than regular annotations. This patch implements transparent
      conversion so that qt4 clients don't notice the difference.
      
      Important! When dealing with FixedRotation annotations, poppler-qt4
      clients will need to set geometry-related annotation properties in
      the following order:
       1) flags (because we need to know if this is a FixedRotation
          annotation or not)
       2) boundary (because we need to know what the topleft corner is,
          so that we can construct the conversion matrix)
       3) anything else
      
      This requirement will be documented in the next patch
      cf950a2b
    • Fabio D'Urso's avatar
      core: Remove geometry-related arguments from annotation constructors · 4b130855
      Fabio D'Urso authored
      Removed arguments from annotation constructors related to the geometry
      of the annotation. This change will make it easier to support creating
      annotations with flag NoRotate in the next patch (because no special
      cases will be needed: coordinate conversion code will be able to always
      assume that the underlying annotation object already exists).
      
      Data that used to be taken from these arguments is now replaced by dummy
      values, which can be modified using appropriate setter methods after
      the annotation object is created.
      
      Affected annotation types:
       - AnnotLine
       - AnnotTextMarkup
       - AnnotPolygon
       - AnnotInk
      4b130855
    • Fabio D'Urso's avatar
      core: Support for rendering annotations with flagNoRotate · 74ea15cc
      Fabio D'Urso authored
      Gfx::drawAnnot now makes a counter-rotation if flagNoRotate is set
      74ea15cc
  22. 06 Apr, 2013 1 commit
  23. 03 Mar, 2013 2 commits
    • Albert Astals Cid's avatar
      Small improvements over locker class · 677e5b26
      Albert Astals Cid authored
       * Remove the namespace (we don't use much/any namespaces in poppler core)
       * Rename the class and defines from lock to locker since lock and be either the action "to lock" or the "thing that locks", with locker it is more clear (i think) that is "the thing" than "the action"
       * Make Annot::decRefCnt use gLockMutex since we the object itself is being deleted in the if and not sure the locker would be happy with that
       * change the getNumPages() param to be DoNotLockMutex since previously it was a gFalse (i guess Thomas made a c&p typo here)
       * Have only one constructor like Adam suggested.
      677e5b26
    • Thomas Freitag's avatar
      Add a locker helper and a bool -> enum changes · d5c929fc
      Thomas Freitag authored
      Bug #59933
      d5c929fc
  24. 20 Feb, 2013 1 commit
  25. 16 Oct, 2012 2 commits