1. 22 Jun, 2018 1 commit
  2. 17 Apr, 2018 1 commit
  3. 06 Apr, 2018 1 commit
  4. 05 Apr, 2018 1 commit
  5. 08 Jan, 2018 1 commit
    • Albert Astals Cid's avatar
      Delete lots of copy constructors and copy assignment operators · 8794789a
      Albert Astals Cid authored
      Fixes rule-of-three and copyable-polymorphic warnings reported by clazy.
      The default copy constructor and copy assignment operator are
      only valid for simple classes so we delete them (i.e. make then not exist)
      when we have either a virtual class or a destructor, the code still compiles
      so this doesn't fix any bug, it is more a protection for when you think you
      can copy a class and don't realize the default copy constrcutor is not doing
      what you want and you get crashes. Hopefully this helps us in the future :)
  6. 13 Sep, 2017 1 commit
  7. 08 May, 2017 1 commit
    • Albert Astals Cid's avatar
      New Object API · 9773c153
      Albert Astals Cid authored
      Implement the move operators and copy construtor
      Almost all the init() functions are gone and we just have simple
      constructors now
      Also made free() public since you're not supposed to call it anymore,
      unless you're being evil and malloc'ing Objects like Array/Dict/XRef
      This has a huge reaction chain, most importantly we
      don't get objects by passing a pointer Object parameter, we
      just get the object as a return value, which is a much clearer API
       -  aobj->copy(&obj);
       +  obj = aobj->copy();
      before I was never sure what was being copied into what
      Comes with a huge diff, I probably made some mistake in the porting
      since there was lots of copy & paste involved
  8. 02 Oct, 2013 1 commit
  9. 30 Jun, 2013 1 commit
  10. 04 Jun, 2013 1 commit
  11. 25 Apr, 2013 3 commits
  12. 25 Jan, 2013 1 commit
    • Albert Astals Cid's avatar
      A few Goffsets we missed · 1bb3ddc2
      Albert Astals Cid authored
      charactersRead is returned in BaseCryptStream::getPos thus should be a Goffset
      Gfx::getPos returns Parser::getPos and thus should be a Goffset too
  13. 19 Jan, 2013 1 commit
  14. 13 Nov, 2012 1 commit
  15. 13 May, 2012 2 commits
  16. 15 Jan, 2012 1 commit
    • Albert Astals Cid's avatar
      [xpdf] More Splash and Gfx changes from Thomas · 9c092e17
      Albert Astals Cid authored
      1. merge of blend changes
      Here I had not only merged the changed in blend modes, I made also a few
      changes in the SPLASH_CMYK area, so that the already sent PDF now also
      be rendered correctly with the -jpegcmyk option
      2. merge of font handling in SplashOutputDev.cc
      There were a few changes left in font handling, I took them over
      3. merge of getcolor-changes
      The getcolor changes win a price for well defined C++ code. I wouldn't
      have merged them, if there were not a lot of other things to merge.
      4. merge of image handling in SplashOutputDev.cc
      I merged the left changes in image handling including colorizing masks
      in pattern colorspace
      5. cleanup of overprint
      I tested the overprint implementation of Derek. They succeed only in 70
      % percent of the PDF where my solution had success, but Derek's solution
      is much cleaner, and I'm sure that I could also fix the rest in it. BUT:
      as I already considered, when I implemented overprint, there are some
      overprint situations, which can not be solved in a CMYK colorspace, we
      have to implement a DeviceN colorpace when also overprint from CMYK
      colors over spot colors should work. Therefore I decided to remove my
      overprint implementation completely from the code and let Derek's
      solution in, even if there could be done some enhancements in it.
      6. colorizing text in pattern colorspace
      When I saw Derek's implementation with a clean interface only at one
      place in Gfx.cc, I first was very surprised. My solution had a lot of
      places in Gfx.cc, where I looked if the current colorspace is a pattern
      colorspace. Therefore I first had a look into the PDF specification
      again, and really, it can be done in the way of Derek. Therefore I
      merged it and removed the fragments of my code.
      On this step I started a regtest against the version after the fourth
      patch. There were a lot of enhancements, especially in texts with
      symbolic chars like mathematical and so on, but there was one (and ONLY
      one) regression, shown in bug-poppler27482.pdf
      I examined that (that is also the reason for the delay) and encountered
      that on merging I removed my solution for this bug, therefore
      7. insert enhancements for colorizing masks in pattern colorspace
      I adapt the bug fix from bug 27482 to the merge.
  17. 10 Jan, 2012 1 commit
  18. 01 Sep, 2011 1 commit
  19. 30 Aug, 2011 1 commit
  20. 11 Jul, 2011 1 commit
    • Albert Astals Cid's avatar
      Sanitize headers a big · a8fca630
      Albert Astals Cid authored
       * Remove includes to config.h as that file does not exist
       * Add to poppler-config.h all the defines we define in the
         configure/cmake process and are used in headers
       * Include poppker-config.h where needed
  21. 10 Nov, 2010 1 commit
    • Albert Astals Cid's avatar
      Kill GooVector · 6296c289
      Albert Astals Cid authored
      std::vector does the same and GooVector is not part of xpdf so we don't
      need to maintain it in case we ever get a new xpdf release we want to
      merge with
  22. 14 Oct, 2010 1 commit
  23. 10 Jul, 2010 1 commit
  24. 21 Apr, 2010 1 commit
  25. 27 Jan, 2010 3 commits
    • David Benjamin's avatar
      Allow commands to abort the current stream · 30922840
      David Benjamin authored
      In many instances, the sensible response (and what acroread does) in
      case of an error is abort the PDF stream. To avoid changing the return
      value of every function and using C++ exceptions, we communicate via a
      commandAborted variable.
      This patch, matching acroread's behavior aborts the current stream when
      there are too few arguments or we pop too many times. Implementation
      note 39 in Appendix H of the PDF reference contradicts the former, but
      hand-crafted test PDFs as well as the file in #24575 suggest otherwise.
      Unlike all the other attempts, this patch actually fixes the PDF in
      bug #24575.
    • David Benjamin's avatar
      Add a stack of stateGuards to Gfx · 8284008a
      David Benjamin authored
      While a stack of states is a good way to maintain graphics contexts, if
      the command stream you are interpreting is untrusted, we must place
      appropriate guards to be sure that, not only do we not pop past the end
      of the stack, but we do not pop past the stack as it was when we began
    • David Benjamin's avatar
      Maintain the height of the stack in Gfx · 4ae84c83
      David Benjamin authored
      Introduces a new variable Gfx::stackHeight that maintains up-to-date
      information about the current height of the stack.
  26. 24 Jan, 2010 2 commits
  27. 14 Dec, 2009 1 commit
    • Carlos Garcia Campos's avatar
      [annots] Use opacity when drawing Markup Annotations · c6195472
      Carlos Garcia Campos authored
      According to the spec:
      "The constant opacity value that shall be used in painting the
      annotation. This value shall apply to all visible elements of the
      annotation in its closed state (including its background and border) but
      not to the pop-up window that appears when the annotation is opened.
      The specified value shall not used if the annotation has an appearance
      stream in that case, the appearance stream shall specify any
      If no explicit appearance stream is defined for the annotation, it may
      be painted by implementation-dependent means that do not necessarily
      conform to the PDF imaging model; in this case, the effect of this entry
      is implementation-dependent as well."
  28. 23 Oct, 2009 1 commit
  29. 02 Jun, 2009 1 commit
    • Thomas Freitag's avatar
      Support colorizing text in pattern colorspace · 104f9286
      Thomas Freitag authored
      This implements commits the final patches for bug 19670 and 19994
      Also fixes bugs 15819 and 2807
      Also implements blending for SPLASH_CMYK in Splash
      It's a quite big change but i've done regression testing over my whole
      pdf suite and did not fit anything that went worse, just improvements
      Missing the Cairo support
  30. 04 Jan, 2009 1 commit
  31. 09 Nov, 2008 1 commit
  32. 08 Nov, 2008 1 commit
  33. 01 Sep, 2008 1 commit
    • Albert Astals Cid's avatar
      All poppler commiters to these files agreed to GPLv2+ · 0c11d390
      Albert Astals Cid authored
      Still missing to answer
      Marco Pesenti Gritti
      Kjartan Maraas
      Timothy Lee
      Carl Worth
      Ed Catmur
  34. 24 Aug, 2008 1 commit
    • Albert Astals Cid's avatar
      Add more correct copyright statements on fofi, goo, poppler and util... · 47f54ad4
      Albert Astals Cid authored
      Add more correct copyright statements on fofi, goo, poppler and util directories to be more compliant with GPL that requires such modification statements to be present. Meanwhile i did that, i did qt and qt4 dirs too, glib is missing if someone wants to fix it, but it's not crucial as it's not a fork of some other GPL software