1. 22 Sep, 2018 1 commit
    • Adam Reichold's avatar
      Include unit test cases from separate test repository · 21a3941b
      Adam Reichold authored
      As the only users of the TESTDATADIR parameter seem to be the Qt5 frontend
      unit tests, this change includes the test data necessary to run them and
      hence `make test` successfully directly in this repository. The configuration
      parameter is thereby removed. The data is marked as non-exportable to avoid
      bloating the source tarballs.
      21a3941b
  2. 21 Sep, 2018 5 commits
  3. 20 Sep, 2018 6 commits
  4. 19 Sep, 2018 2 commits
    • Tobias Deiminger's avatar
      Compile Qt5 frontend with -DQT_STRICT_ITERATORS · 5dadcc93
      Tobias Deiminger authored
      QT_STRICT_ITERATORS prevents conversion from non-const iterator to const iterator.
      
      It helps detecting situations where we waste resources due to
      needless detach from implicitely shared container data (i.e. deep copy).
      
      If anyone should run into problems, they can disable strict iterators
      using a global cache variable:
      
      $ cmake DENABLE_QT_STRICT_ITERATORS=OFF [...]
      5dadcc93
    • Albert Astals Cid's avatar
      Update (C) · 3105b61e
      Albert Astals Cid authored
      3105b61e
  5. 18 Sep, 2018 4 commits
  6. 17 Sep, 2018 2 commits
  7. 08 Sep, 2018 3 commits
  8. 05 Sep, 2018 1 commit
  9. 04 Sep, 2018 1 commit
  10. 02 Sep, 2018 8 commits
    • Albert Astals Cid's avatar
      7c6c1fef
    • Sanchit Anand's avatar
      e8e95d2c
    • Albert Astals Cid's avatar
      qt5: test: Compile with old qt · 09cc5fd1
      Albert Astals Cid authored
      09cc5fd1
    • Albert Astals Cid's avatar
      Add missing (C) · 042d2483
      Albert Astals Cid authored
      And minor style change by Albert
      042d2483
    • Tobias Deiminger's avatar
      More review fixes · d4b4be23
      Tobias Deiminger authored
      Text color is indicated by nonstroking color in graphics state
      	Assumption: Text rendering mode is 'fill'.
      
      Increase color precision for lossless roundtrip of 16 bit integers
      	Our API takes QColor from user. We want to support a lossless roundtrip
      	of QColor (16 bit per channel internally) through document save and
      	load, and empirically found .5f is best match.
      
      Check only .5f case of color channel roundtrip. Include 65535.
      	We check if precision == 5 is sufficient, and fail if not. We know that
      	precision < 5 will never work, because target set contains less numbers
      	than uint16 range.
      
      Use smart pointer in textFont and textColor
      
      Add test for CMYK QColor roundtrip
      
      Support QColor::Cmyk to AnnotColor::colorCMYK conversion
      
      Add simple test for font size. Fix actual/expected args.
      
      Model font name as class Object, type objName
      	Take into account that ISO 32000 says Tf operand is always an object of
      	PDF type "name". Further benefit: class Object introduces ownership
      	semantcis.
      
      Use more std::unique_ptr and fix some coding syle
      	Some places assumed ownership implicitely. Make it more explicit.
      
      Move parse/constructAppearanceString into DefaultAppearance
      	We gain cohesion and automatic memory management.
      
      Fix minor styling issues
      
      Use std::make_unique from C++14
      d4b4be23
    • Adam Reichold's avatar
    • Tobias Deiminger's avatar
      Fix open review comments from #50 · db0451ab
      Tobias Deiminger authored
      Make fontTag optional for AnnotFreeText::parseAppearanceString.
      Handle fontColor == nullptr in AnnotFreeText::constructAppearanceString.
      Use AnnotAppearanceBuilder in AnnotFreeText::constructAppearanceString.
      Delete copy assignment operator for DefaultAppearance.
      Rename setAppearanceString to setDefaultAppearance.
      db0451ab
    • Dileep Sankhla's avatar
      Add annotation font color · 64531344
      Dileep Sankhla authored
      64531344
  11. 01 Sep, 2018 4 commits
  12. 31 Aug, 2018 3 commits