Commit 7f20ace4 authored by Adam Reichold's avatar Adam Reichold

Remove usage of pragmas interface and implementation

GCC recommends not using them for a long time and its documentation says:
> These #pragmas have been superceded as of GCC 2.7.2 by COMDAT support
> and the “key method” heuristic mentioned in Vague Linkage.
> Using them can actually cause your program to grow due to
> unnecessary out-of-line copies of inline functions.

Also nobody seems to set USE_GCC_PRAGMAS and sometimes they were
guarded by just __GNUC__ which upsets Clang.
parent e1501603
Pipeline #5557 passed with stage
in 2 minutes and 58 seconds
......@@ -24,10 +24,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdio.h>
#include <limits.h>
#include "goo/gmem.h"
......
......@@ -23,10 +23,6 @@
#ifndef FOFIBASE_H
#define FOFIBASE_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
//------------------------------------------------------------------------
......
......@@ -22,10 +22,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include "FoFiEncodings.h"
......
......@@ -23,10 +23,6 @@
#ifndef FOFIENCODINGS_H
#define FOFIENCODINGS_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
//------------------------------------------------------------------------
......
......@@ -21,10 +21,6 @@
//
//========================================================================
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdio.h>
#include <string.h>
#include <limits.h>
......
......@@ -23,10 +23,6 @@
#ifndef FOFIIDENTIFIER_H
#define FOFIIDENTIFIER_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
//------------------------------------------------------------------------
// FoFiIdentifier
//------------------------------------------------------------------------
......
......@@ -32,10 +32,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <string.h>
#include <limits.h>
......
......@@ -28,10 +28,6 @@
#ifndef FOFITRUETYPE_H
#define FOFITRUETYPE_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "stddef.h"
#include <unordered_map>
#include <string>
......
......@@ -27,10 +27,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <string.h>
#include <limits.h>
......
......@@ -23,10 +23,6 @@
#ifndef FOFITYPE1_H
#define FOFITYPE1_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
#include "FoFiBase.h"
......
......@@ -24,10 +24,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <string.h>
#include <math.h>
......
......@@ -25,10 +25,6 @@
#ifndef FOFITYPE1C_H
#define FOFITYPE1C_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
#include "FoFiBase.h"
......
......@@ -26,10 +26,6 @@
#ifdef USE_FIXEDPOINT
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "FixedPoint.h"
#define ln2 ((FixedPoint)0.69314718)
......
......@@ -30,10 +30,6 @@
#ifdef USE_FIXEDPOINT
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <stdio.h>
#include <stdlib.h>
#include "gtypes.h"
......
......@@ -35,10 +35,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <stddef.h>
#include <string.h>
......
......@@ -33,10 +33,6 @@
#ifndef GooString_H
#define GooString_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <stdarg.h>
#include <stdlib.h> // for NULL
#include <string>
......
......@@ -13,10 +13,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "GooTimer.h"
#include <string.h>
......
......@@ -17,10 +17,6 @@
#ifndef GOOTIMER_H
#define GOOTIMER_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "poppler-config.h"
#include "gtypes.h"
#ifdef HAVE_GETTIMEOFDAY
......
......@@ -50,10 +50,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <math.h>
#include <assert.h>
......
......@@ -39,10 +39,6 @@
#ifndef ANNOT_H
#define ANNOT_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <memory>
#include <atomic>
#include <mutex>
......
......@@ -27,10 +27,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <cassert>
#include "Object.h"
......
......@@ -28,10 +28,6 @@
#ifndef ARRAY_H
#define ARRAY_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <atomic>
#include <mutex>
#include <vector>
......
......@@ -8,10 +8,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <string.h>
#include "goo/gmem.h"
......
......@@ -23,10 +23,6 @@
#ifndef BUILTINFONT_H
#define BUILTINFONT_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
struct BuiltinFont;
......
......@@ -25,10 +25,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
......
......@@ -25,10 +25,6 @@
#ifndef CMAP_H
#define CMAP_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <atomic>
#include "poppler-config.h"
......
......@@ -56,10 +56,6 @@
#define CAN_CHECK_OPEN_FACES 1
#endif
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
//------------------------------------------------------------------------
// CairoFont
//------------------------------------------------------------------------
......
......@@ -29,10 +29,6 @@
#ifndef CAIROFONTENGINE_H
#define CAIROFONTENGINE_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <mutex>
#include "poppler-config.h"
......
......@@ -38,10 +38,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <cstdint>
#include <string.h>
#include <math.h>
......
......@@ -34,10 +34,6 @@
#ifndef CAIROOUTPUTDEV_H
#define CAIROOUTPUTDEV_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
#include <cairo-ft.h>
#include "OutputDev.h"
......
......@@ -43,10 +43,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stddef.h>
#include <stdlib.h>
#include "goo/gmem.h"
......
......@@ -37,10 +37,6 @@
#ifndef CATALOG_H
#define CATALOG_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "poppler-config.h"
#include "Object.h"
......
......@@ -35,10 +35,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdio.h>
#include <string.h>
#include "goo/glibc.h"
......
......@@ -30,10 +30,6 @@
#ifndef CHARCODETOUNICODE_H
#define CHARCODETOUNICODE_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <atomic>
#include "poppler-config.h"
......
......@@ -16,15 +16,6 @@
#ifndef DCTSTREAM_H
#define DCTSTREAM_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "poppler-config.h"
#include <stdio.h>
#include <stdlib.h>
......
......@@ -29,10 +29,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <cstdint>
#include <string.h>
#include "goo/gmem.h"
......
......@@ -28,10 +28,6 @@
#ifndef DECRYPT_H
#define DECRYPT_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
#include "goo/GooString.h"
#include "Object.h"
......
......@@ -31,10 +31,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <algorithm>
#include "XRef.h"
......
......@@ -30,10 +30,6 @@
#ifndef DICT_H
#define DICT_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <atomic>
#include <mutex>
#include <string>
......
......@@ -27,10 +27,6 @@
#include <config.h>
#include <poppler-config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdio.h>
#include <stddef.h>
#include <stdarg.h>
......
......@@ -27,10 +27,6 @@
#ifndef ERROR_H
#define ERROR_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <stdarg.h>
#include "poppler-config.h"
#include "goo/gtypes.h"
......
......@@ -16,10 +16,6 @@
#ifndef FILE_SPEC_H
#define FILE_SPEC_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "Object.h"
class EmbFile {
......
......@@ -11,10 +11,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "FlateEncoder.h"
//------------------------------------------------------------------------
......
......@@ -12,10 +12,6 @@
#ifndef FLATEENCODE_H
#define FLATEENCODE_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "poppler-config.h"
#include <stdio.h>
#include <stdlib.h>
......
......@@ -13,10 +13,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "poppler-config.h"
#ifdef ENABLE_ZLIB_UNCOMPRESS
......
......@@ -12,15 +12,6 @@
#ifndef FLATESTREAM_H
#define FLATESTREAM_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "poppler-config.h"
#include <stdio.h>
#include <stdlib.h>
......
......@@ -28,10 +28,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <set>
#include <limits>
#include <stddef.h>
......
......@@ -24,10 +24,6 @@
#ifndef FORM_H
#define FORM_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/GooList.h"
#include "Object.h"
#include "Annot.h"
......
......@@ -28,10 +28,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
......
......@@ -27,10 +27,6 @@
#ifndef FUNCTION_H
#define FUNCTION_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
#include "Object.h"
#include <set>
......
......@@ -49,10 +49,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdlib.h>
#include <stdio.h>
#include <stddef.h>
......
......@@ -32,10 +32,6 @@
#ifndef GFX_H
#define GFX_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "poppler-config.h"
#include "goo/gtypes.h"
#include "goo/GooList.h"
......
......@@ -42,10 +42,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
......
......@@ -33,10 +33,6 @@
#ifndef GFXFONT_H
#define GFXFONT_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
#include "goo/GooString.h"
#include "Object.h"
......
......@@ -41,10 +41,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <algorithm>
#include <memory>
#include <stddef.h>
......
......@@ -33,10 +33,6 @@
#ifndef GFXSTATE_H
#define GFXSTATE_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "poppler-config.h"
#include "goo/gtypes.h"
......
......@@ -47,10 +47,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <string.h>
#include <stdio.h>
#include <ctype.h>
......
......@@ -36,10 +36,6 @@
#ifndef GLOBALPARAMS_H
#define GLOBALPARAMS_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include <assert.h>
#include "poppler-config.h"
#include <stdio.h>
......
......@@ -21,10 +21,6 @@ description for all fonts available in Windows. That's how MuPDF works.
#include <config.h>
#endif
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include <windows.h>
#if !(_WIN32_IE >= 0x0500)
#error "_WIN32_IE must be defined >= 0x0500 for SHGFP_TYPE_CURRENT from shlobj.h"
......
......@@ -8,10 +8,6 @@
#include <config.h>
#ifdef USE_GCC_PRAGMAS
#pragma implementation
#endif
#include "Object.h"
#include "Stream.h"
#include "JArithmeticDecoder.h"
......
......@@ -25,10 +25,6 @@
#ifndef JARITHMETICDECODER_H
#define JARITHMETICDECODER_H
#ifdef USE_GCC_PRAGMAS
#pragma interface
#endif
#include "goo/gtypes.h"
class Stream;
......