We are currently experiencing downtime impacting viewing & cloning the Mesa repo, and some GitLab pages returning 503. Please see #freedesktop on IRC for more updates.

Commit d5847d8d authored by Matthew Leeds's avatar Matthew Leeds Committed by Ray Strode

Check GDBusMessage for INTERACTIVE_AUTHORIZATION flag

Currently we always use the flag
POLKIT_CHECK_AUTHORIZATION_FLAGS_ALLOW_USER_INTERACTION when checking if
a subject is authorized for an action, meaning that we cause polkit to
create an interactive dialog box. However since GLib 2.46, there has
been a flag G_DBUS_MESSAGE_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION which
indicates if the caller is prepared to have the user authenticate (e.g.
it's a user-facing program not a daemon). So, check for this flag in
daemon_local_check_auth().

The impetus for this patch is that in the Endles fork of
gnome-control-center we use the library malcontent, and call
mct_manager_get_app_filter() even when we don't have permission to
actually read the user's app filter, since it shouldn't cause a dialog
without MCT_GET_APP_FILTER_FLAGS_INTERACTIVE being passed to it. However
because accountsservice doesn't respect
G_DBUS_MESSAGE_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION, polkit attempts to
create an auth dialog anyway (and hits an error but that's a separate
gnome-shell bug).

In libaccountsservice, we use code generated by gdbus-codegen to call
D-Bus methods implemented by the daemon, and that generated code
unconditionally uses G_DBUS_CALL_FLAGS_NONE, which would mean that users
of libaccountsservice can't use interactive auth. The solution is to
bump our GLib requirement to 2.63.5 (2.64 hasn't been released yet) and
pass --glib-min-required 2.64 to gdbus-codegen, which causes the
generated code to have two more arguments for each method call: one for
GDBusCallFlags and one for a timeout value.

For now we always use G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION
in libaccountsservice, to maintain compatibility. It might make sense to
add API in the future so that users of the library can specify if they
want to allow interactive auth.

This commit also makes us use
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION for method calls
implemented by ConsoleKit, even though presumably no problems are caused
by the current behavior of using G_DBUS_CALL_FLAGS_NONE. In theory
ConsoleKit could check for
G_DBUS_MESSAGE_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION one day (although
in practice I think it's deprecated and inactive), and I think the whole
of libaccountsservice should assume interactive auth is allowed until we
have API to distinguish the no-interactive-auth case.
parent eb1cac46
Pipeline #106335 passed with stage
in 1 minute and 3 seconds
build-fedora: build-fedora:
image: fedora:latest image: fedora:rawhide
before_script: before_script:
- dnf install -y gcc meson ninja-build gobject-introspection-devel glib-devel gtk-doc gettext-devel make polkit-devel redhat-rpm-config systemd-devel dbus-devel vala - dnf install -y gcc meson ninja-build gobject-introspection-devel glib-devel gtk-doc gettext-devel make polkit-devel redhat-rpm-config systemd-devel dbus-devel vala
script: script:
......
...@@ -138,9 +138,12 @@ endif ...@@ -138,9 +138,12 @@ endif
add_project_arguments(common_flags, language: 'c') add_project_arguments(common_flags, language: 'c')
gio_dep = dependency('gio-2.0', version: '>= 2.37.3') # Ensure we have the changes from https://gitlab.gnome.org/GNOME/glib/merge_requests/1286
# and https://gitlab.gnome.org/GNOME/glib/merge_requests/1342
glib_min_version = '2.63.5'
gio_dep = dependency('gio-2.0', version: '>= ' + glib_min_version)
gio_unix_dep = dependency('gio-unix-2.0') gio_unix_dep = dependency('gio-unix-2.0')
glib_dep = dependency('glib-2.0', version: '>= 2.44') glib_dep = dependency('glib-2.0', version: '>= ' + glib_min_version)
polkit_gobject_dep = dependency('polkit-gobject-1') polkit_gobject_dep = dependency('polkit-gobject-1')
crypt_dep = cc.find_library('crypt') crypt_dep = cc.find_library('crypt')
......
...@@ -1165,7 +1165,6 @@ daemon_create_user (AccountsAccounts *accounts, ...@@ -1165,7 +1165,6 @@ daemon_create_user (AccountsAccounts *accounts,
daemon_local_check_auth (daemon, daemon_local_check_auth (daemon,
NULL, NULL,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
daemon_create_user_authorized_cb, daemon_create_user_authorized_cb,
context, context,
data, data,
...@@ -1217,7 +1216,6 @@ daemon_cache_user (AccountsAccounts *accounts, ...@@ -1217,7 +1216,6 @@ daemon_cache_user (AccountsAccounts *accounts,
daemon_local_check_auth (daemon, daemon_local_check_auth (daemon,
NULL, NULL,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
daemon_cache_user_authorized_cb, daemon_cache_user_authorized_cb,
context, context,
g_strdup (user_name), g_strdup (user_name),
...@@ -1267,7 +1265,6 @@ daemon_uncache_user (AccountsAccounts *accounts, ...@@ -1267,7 +1265,6 @@ daemon_uncache_user (AccountsAccounts *accounts,
daemon_local_check_auth (daemon, daemon_local_check_auth (daemon,
NULL, NULL,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
daemon_uncache_user_authorized_cb, daemon_uncache_user_authorized_cb,
context, context,
g_strdup (user_name), g_strdup (user_name),
...@@ -1363,7 +1360,6 @@ daemon_delete_user (AccountsAccounts *accounts, ...@@ -1363,7 +1360,6 @@ daemon_delete_user (AccountsAccounts *accounts,
daemon_local_check_auth (daemon, daemon_local_check_auth (daemon,
NULL, NULL,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
daemon_delete_user_authorized_cb, daemon_delete_user_authorized_cb,
context, context,
data, data,
...@@ -1433,11 +1429,28 @@ check_auth_cb (PolkitAuthority *authority, ...@@ -1433,11 +1429,28 @@ check_auth_cb (PolkitAuthority *authority,
check_auth_data_free (data); check_auth_data_free (data);
} }
static gboolean
get_allow_interaction (GDBusMethodInvocation *invocation)
{
/* GLib 2.46 is when G_DBUS_MESSAGE_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION
* was first released.
*/
#if GLIB_CHECK_VERSION(2, 46, 0)
GDBusMessage *message = g_dbus_method_invocation_get_message (invocation);
GDBusMessageFlags message_flags = g_dbus_message_get_flags (message);
if (message_flags & G_DBUS_MESSAGE_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION)
return TRUE;
else
return FALSE;
#else
return TRUE;
#endif
}
void void
daemon_local_check_auth (Daemon *daemon, daemon_local_check_auth (Daemon *daemon,
User *user, User *user,
const gchar *action_id, const gchar *action_id,
gboolean allow_interaction,
AuthorizedCallback authorized_cb, AuthorizedCallback authorized_cb,
GDBusMethodInvocation *context, GDBusMethodInvocation *context,
gpointer authorized_cb_data, gpointer authorized_cb_data,
...@@ -1447,6 +1460,7 @@ daemon_local_check_auth (Daemon *daemon, ...@@ -1447,6 +1460,7 @@ daemon_local_check_auth (Daemon *daemon,
CheckAuthData *data; CheckAuthData *data;
PolkitSubject *subject; PolkitSubject *subject;
PolkitCheckAuthorizationFlags flags; PolkitCheckAuthorizationFlags flags;
gboolean allow_interaction = get_allow_interaction (context);
data = g_new0 (CheckAuthData, 1); data = g_new0 (CheckAuthData, 1);
data->daemon = g_object_ref (daemon); data->daemon = g_object_ref (daemon);
......
...@@ -83,7 +83,6 @@ typedef void (*AuthorizedCallback) (Daemon *daemon, ...@@ -83,7 +83,6 @@ typedef void (*AuthorizedCallback) (Daemon *daemon,
void daemon_local_check_auth (Daemon *daemon, void daemon_local_check_auth (Daemon *daemon,
User *user, User *user,
const gchar *action_id, const gchar *action_id,
gboolean allow_interaction,
AuthorizedCallback auth_cb, AuthorizedCallback auth_cb,
GDBusMethodInvocation *context, GDBusMethodInvocation *context,
gpointer data, gpointer data,
......
This diff is collapsed.
...@@ -1297,6 +1297,8 @@ act_user_get_password_expiration_policy (ActUser *user, ...@@ -1297,6 +1297,8 @@ act_user_get_password_expiration_policy (ActUser *user,
g_return_if_fail (ACCOUNTS_IS_USER (user->accounts_proxy)); g_return_if_fail (ACCOUNTS_IS_USER (user->accounts_proxy));
if (!accounts_user_call_get_password_expiration_policy_sync (user->accounts_proxy, if (!accounts_user_call_get_password_expiration_policy_sync (user->accounts_proxy,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
expiration_time, expiration_time,
last_change_time, last_change_time,
min_days_between_changes, min_days_between_changes,
...@@ -1331,6 +1333,8 @@ act_user_set_email (ActUser *user, ...@@ -1331,6 +1333,8 @@ act_user_set_email (ActUser *user,
if (!accounts_user_call_set_email_sync (user->accounts_proxy, if (!accounts_user_call_set_email_sync (user->accounts_proxy,
email, email,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetEmail call failed: %s", error->message); g_warning ("SetEmail call failed: %s", error->message);
...@@ -1359,6 +1363,8 @@ act_user_set_language (ActUser *user, ...@@ -1359,6 +1363,8 @@ act_user_set_language (ActUser *user,
if (!accounts_user_call_set_language_sync (user->accounts_proxy, if (!accounts_user_call_set_language_sync (user->accounts_proxy,
language, language,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetLanguage for language %s failed: %s", language, error->message); g_warning ("SetLanguage for language %s failed: %s", language, error->message);
...@@ -1387,6 +1393,8 @@ act_user_set_x_session (ActUser *user, ...@@ -1387,6 +1393,8 @@ act_user_set_x_session (ActUser *user,
if (!accounts_user_call_set_xsession_sync (user->accounts_proxy, if (!accounts_user_call_set_xsession_sync (user->accounts_proxy,
x_session, x_session,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetXSession call failed: %s", error->message); g_warning ("SetXSession call failed: %s", error->message);
...@@ -1415,6 +1423,8 @@ act_user_set_session (ActUser *user, ...@@ -1415,6 +1423,8 @@ act_user_set_session (ActUser *user,
if (!accounts_user_call_set_session_sync (user->accounts_proxy, if (!accounts_user_call_set_session_sync (user->accounts_proxy,
session, session,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetSession call failed: %s", error->message); g_warning ("SetSession call failed: %s", error->message);
...@@ -1443,6 +1453,8 @@ act_user_set_session_type (ActUser *user, ...@@ -1443,6 +1453,8 @@ act_user_set_session_type (ActUser *user,
if (!accounts_user_call_set_session_type_sync (user->accounts_proxy, if (!accounts_user_call_set_session_type_sync (user->accounts_proxy,
session_type, session_type,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetSessionType call failed: %s", error->message); g_warning ("SetSessionType call failed: %s", error->message);
...@@ -1471,6 +1483,8 @@ act_user_set_location (ActUser *user, ...@@ -1471,6 +1483,8 @@ act_user_set_location (ActUser *user,
if (!accounts_user_call_set_location_sync (user->accounts_proxy, if (!accounts_user_call_set_location_sync (user->accounts_proxy,
location, location,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetLocation call failed: %s", error->message); g_warning ("SetLocation call failed: %s", error->message);
...@@ -1499,6 +1513,8 @@ act_user_set_user_name (ActUser *user, ...@@ -1499,6 +1513,8 @@ act_user_set_user_name (ActUser *user,
if (!accounts_user_call_set_user_name_sync (user->accounts_proxy, if (!accounts_user_call_set_user_name_sync (user->accounts_proxy,
user_name, user_name,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetUserName call failed: %s", error->message); g_warning ("SetUserName call failed: %s", error->message);
...@@ -1527,6 +1543,8 @@ act_user_set_real_name (ActUser *user, ...@@ -1527,6 +1543,8 @@ act_user_set_real_name (ActUser *user,
if (!accounts_user_call_set_real_name_sync (user->accounts_proxy, if (!accounts_user_call_set_real_name_sync (user->accounts_proxy,
real_name, real_name,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetRealName call failed: %s", error->message); g_warning ("SetRealName call failed: %s", error->message);
...@@ -1555,6 +1573,8 @@ act_user_set_icon_file (ActUser *user, ...@@ -1555,6 +1573,8 @@ act_user_set_icon_file (ActUser *user,
if (!accounts_user_call_set_icon_file_sync (user->accounts_proxy, if (!accounts_user_call_set_icon_file_sync (user->accounts_proxy,
icon_file, icon_file,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetIconFile call failed: %s", error->message); g_warning ("SetIconFile call failed: %s", error->message);
...@@ -1581,9 +1601,11 @@ act_user_set_account_type (ActUser *user, ...@@ -1581,9 +1601,11 @@ act_user_set_account_type (ActUser *user,
g_return_if_fail (ACCOUNTS_IS_USER (user->accounts_proxy)); g_return_if_fail (ACCOUNTS_IS_USER (user->accounts_proxy));
if (!accounts_user_call_set_account_type_sync (user->accounts_proxy, if (!accounts_user_call_set_account_type_sync (user->accounts_proxy,
account_type, account_type,
NULL, G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
&error)) { -1,
NULL,
&error)) {
g_warning ("SetAccountType call failed: %s", error->message); g_warning ("SetAccountType call failed: %s", error->message);
return; return;
} }
...@@ -1646,6 +1668,8 @@ act_user_set_password (ActUser *user, ...@@ -1646,6 +1668,8 @@ act_user_set_password (ActUser *user,
if (!accounts_user_call_set_password_sync (user->accounts_proxy, if (!accounts_user_call_set_password_sync (user->accounts_proxy,
crypted, crypted,
hint, hint,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetPassword call failed: %s", error->message); g_warning ("SetPassword call failed: %s", error->message);
...@@ -1674,6 +1698,8 @@ act_user_set_password_hint (ActUser *user, ...@@ -1674,6 +1698,8 @@ act_user_set_password_hint (ActUser *user,
if (!accounts_user_call_set_password_hint_sync (user->accounts_proxy, if (!accounts_user_call_set_password_hint_sync (user->accounts_proxy,
hint, hint,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetPasswordHint call failed: %s", error->message); g_warning ("SetPasswordHint call failed: %s", error->message);
...@@ -1704,6 +1730,8 @@ act_user_set_password_mode (ActUser *user, ...@@ -1704,6 +1730,8 @@ act_user_set_password_mode (ActUser *user,
if (!accounts_user_call_set_password_mode_sync (user->accounts_proxy, if (!accounts_user_call_set_password_mode_sync (user->accounts_proxy,
(gint) password_mode, (gint) password_mode,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetPasswordMode call failed: %s", error->message); g_warning ("SetPasswordMode call failed: %s", error->message);
...@@ -1728,6 +1756,8 @@ act_user_set_locked (ActUser *user, ...@@ -1728,6 +1756,8 @@ act_user_set_locked (ActUser *user,
if (!accounts_user_call_set_locked_sync (user->accounts_proxy, if (!accounts_user_call_set_locked_sync (user->accounts_proxy,
locked, locked,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetLocked call failed: %s", error->message); g_warning ("SetLocked call failed: %s", error->message);
...@@ -1757,6 +1787,8 @@ act_user_set_automatic_login (ActUser *user, ...@@ -1757,6 +1787,8 @@ act_user_set_automatic_login (ActUser *user,
if (!accounts_user_call_set_automatic_login_sync (user->accounts_proxy, if (!accounts_user_call_set_automatic_login_sync (user->accounts_proxy,
enabled, enabled,
G_DBUS_CALL_FLAGS_ALLOW_INTERACTIVE_AUTHORIZATION,
-1,
NULL, NULL,
&error)) { &error)) {
g_warning ("SetAutomaticLogin call failed: %s", error->message); g_warning ("SetAutomaticLogin call failed: %s", error->message);
......
...@@ -45,6 +45,7 @@ foreach iface: ifaces ...@@ -45,6 +45,7 @@ foreach iface: ifaces
'@0@.@1@.xml'.format(prefix, iface), '@0@.@1@.xml'.format(prefix, iface),
interface_prefix: prefix, interface_prefix: prefix,
namespace: namespace, namespace: namespace,
extra_args: ['--glib-min-required', '2.64'],
) )
endforeach endforeach
......
...@@ -13,6 +13,7 @@ foreach iface: ifaces ...@@ -13,6 +13,7 @@ foreach iface: ifaces
join_paths(data_dir, iface[1] + iface[2] + '.xml'), join_paths(data_dir, iface[1] + iface[2] + '.xml'),
interface_prefix: iface[1], interface_prefix: iface[1],
namespace: 'Accounts', namespace: 'Accounts',
extra_args: ['--glib-min-required', '2.64'],
) )
sources += gdbus_sources sources += gdbus_sources
gdbus_headers += gdbus_sources[1] gdbus_headers += gdbus_sources[1]
......
...@@ -611,7 +611,7 @@ user_extension_method_call (GDBusConnection *connection, ...@@ -611,7 +611,7 @@ user_extension_method_call (GDBusConnection *connection,
user_extension_authentication_done (user->daemon, user, invocation, iface_info); user_extension_authentication_done (user->daemon, user, invocation, iface_info);
} }
else { else {
daemon_local_check_auth (user->daemon, user, action_id, TRUE, daemon_local_check_auth (user->daemon, user, action_id,
user_extension_authentication_done, user_extension_authentication_done,
invocation, iface_info, NULL); invocation, iface_info, NULL);
} }
...@@ -884,7 +884,6 @@ user_set_real_name (AccountsUser *auser, ...@@ -884,7 +884,6 @@ user_set_real_name (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_real_name_authorized_cb, user_change_real_name_authorized_cb,
context, context,
g_strdup (real_name), g_strdup (real_name),
...@@ -943,7 +942,6 @@ user_set_user_name (AccountsUser *auser, ...@@ -943,7 +942,6 @@ user_set_user_name (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
user_change_user_name_authorized_cb, user_change_user_name_authorized_cb,
context, context,
g_strdup (user_name), g_strdup (user_name),
...@@ -994,7 +992,6 @@ user_set_email (AccountsUser *auser, ...@@ -994,7 +992,6 @@ user_set_email (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_email_authorized_cb, user_change_email_authorized_cb,
context, context,
g_strdup (email), g_strdup (email),
...@@ -1045,7 +1042,6 @@ user_set_language (AccountsUser *auser, ...@@ -1045,7 +1042,6 @@ user_set_language (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_language_authorized_cb, user_change_language_authorized_cb,
context, context,
g_strdup (language), g_strdup (language),
...@@ -1094,7 +1090,6 @@ user_set_session (AccountsUser *auser, ...@@ -1094,7 +1090,6 @@ user_set_session (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_session_authorized_cb, user_change_session_authorized_cb,
context, context,
g_strdup (session), g_strdup (session),
...@@ -1143,7 +1138,6 @@ user_set_session_type (AccountsUser *auser, ...@@ -1143,7 +1138,6 @@ user_set_session_type (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_session_type_authorized_cb, user_change_session_type_authorized_cb,
context, context,
g_strdup (session_type), g_strdup (session_type),
...@@ -1192,7 +1186,6 @@ user_set_x_session (AccountsUser *auser, ...@@ -1192,7 +1186,6 @@ user_set_x_session (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_x_session_authorized_cb, user_change_x_session_authorized_cb,
context, context,
g_strdup (x_session), g_strdup (x_session),
...@@ -1244,7 +1237,6 @@ user_get_password_expiration_policy (AccountsUser *auser, ...@@ -1244,7 +1237,6 @@ user_get_password_expiration_policy (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_get_password_expiration_policy_authorized_cb, user_get_password_expiration_policy_authorized_cb,
context, context,
NULL, NULL,
...@@ -1294,7 +1286,6 @@ user_set_location (AccountsUser *auser, ...@@ -1294,7 +1286,6 @@ user_set_location (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_location_authorized_cb, user_change_location_authorized_cb,
context, context,
g_strdup (location), g_strdup (location),
...@@ -1351,7 +1342,6 @@ user_set_home_directory (AccountsUser *auser, ...@@ -1351,7 +1342,6 @@ user_set_home_directory (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
user_change_home_dir_authorized_cb, user_change_home_dir_authorized_cb,
context, context,
g_strdup (home_dir), g_strdup (home_dir),
...@@ -1405,7 +1395,6 @@ user_set_shell (AccountsUser *auser, ...@@ -1405,7 +1395,6 @@ user_set_shell (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
user_change_shell_authorized_cb, user_change_shell_authorized_cb,
context, context,
g_strdup (shell), g_strdup (shell),
...@@ -1575,7 +1564,6 @@ user_set_icon_file (AccountsUser *auser, ...@@ -1575,7 +1564,6 @@ user_set_icon_file (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_icon_file_authorized_cb, user_change_icon_file_authorized_cb,
context, context,
g_strdup (filename), g_strdup (filename),
...@@ -1653,7 +1641,6 @@ user_set_locked (AccountsUser *auser, ...@@ -1653,7 +1641,6 @@ user_set_locked (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
user_change_locked_authorized_cb, user_change_locked_authorized_cb,
context, context,
GINT_TO_POINTER (locked), GINT_TO_POINTER (locked),
...@@ -1762,7 +1749,6 @@ user_set_account_type (AccountsUser *auser, ...@@ -1762,7 +1749,6 @@ user_set_account_type (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
user_change_account_type_authorized_cb, user_change_account_type_authorized_cb,
context, context,
GINT_TO_POINTER (account_type), GINT_TO_POINTER (account_type),
...@@ -1878,7 +1864,6 @@ user_set_password_mode (AccountsUser *auser, ...@@ -1878,7 +1864,6 @@ user_set_password_mode (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_password_mode_authorized_cb, user_change_password_mode_authorized_cb,
context, context,
GINT_TO_POINTER (mode), GINT_TO_POINTER (mode),
...@@ -1964,7 +1949,6 @@ user_set_password (AccountsUser *auser, ...@@ -1964,7 +1949,6 @@ user_set_password (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_password_authorized_cb, user_change_password_authorized_cb,
context, context,
data, data,
...@@ -2019,7 +2003,6 @@ user_set_password_hint (AccountsUser *auser, ...@@ -2019,7 +2003,6 @@ user_set_password_hint (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
action_id, action_id,
TRUE,
user_change_password_hint_authorized_cb, user_change_password_hint_authorized_cb,
context, context,
g_strdup (hint), g_strdup (hint),
...@@ -2065,7 +2048,6 @@ user_set_automatic_login (AccountsUser *auser, ...@@ -2065,7 +2048,6 @@ user_set_automatic_login (AccountsUser *auser,
daemon_local_check_auth (user->daemon, daemon_local_check_auth (user->daemon,
user, user,
"org.freedesktop.accounts.user-administration", "org.freedesktop.accounts.user-administration",
TRUE,
user_change_automatic_login_authorized_cb, user_change_automatic_login_authorized_cb,
context, context,
GINT_TO_POINTER (enabled), GINT_TO_POINTER (enabled),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment