GitLab

These warnings are not helpful for libbsd.

Windows does not provide <err.h>. Allow these interfaces to be disabled
to get the Windows build working.

tcsetattr() and other functions might not be available on Windows. Allow
this interface to be disabled to get the Windows build working.

The current implementation is ELF-specific, so disable this for now to
get the Windows build working.

fopencookie() might not be available on Windows. Allow this interface to
be disabled to get the Windows build working.

__fpurge() might not be available on Windows. Allow this interface to be
disabled to get the Windows build working.

flock() might not be available on Windows. Allow these interfaces to be
disabled to get the Windows build working.

getline() might not be available on Windows. Allow these interfaces to
be disabled to get the Windows build working.

getopt() might not be available on Windows. Allow this interface to be
disabled to get the Windows build working.

This is useless on Windows and does not compile due to setenv() missing.

There isn't any practical way to implement this.

Windows does not support these types natively, so these are
unimplementable and must be guarded in headers to prevent errors.

Disable script-based tests and add an (initially empty) list of tests
that will need to be disabled by future commits.

Extend the host OS checks to define a WINDOWS automake conditional if
the host is MinGW-like. This will be useful for future Windows-specific
build tweaks.

.symver is an ELF-only directive. On non-ELF platforms, work around this
with __attribute__((alias)).

Windows does not provide warnx().

Windows doesn't provide <sys/param.h>. Several libbsd sources require it
for MIN(), and these are useful non-system-specific macros anyway.

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

Clang's __GNUC__ and __GNUC_MINOR__ definitions are not reliable and may
not be defined at all when targeting the MSVC ABI. Use feature-checking
macros when possible or check for __clang__.

[guillem@hadrons.org: Update for __ protected keyword change. ]
Signed-off-by: Guillem Jover <guillem@hadrons.org>

This should make their usage safer against user macros.

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

These headers are not available on Windows. <bsd/sys/cdefs.h> ensures
that __has_include() and __has_include_next() are defined.
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

<io.h> provides the necessary file I/O functions.

[guillem@hadrons.org: Move include before <hashinc>. ]
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

This is only used in the overlay test and Windows does not provide it.
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

Windows doesn't provide S_ISVTX. Prefer not defining it rather than
defining it to something invalid.
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

<sys/param.h> is not available on Windows.
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Aaron Dierking authored Jun 14, 2018 and Guillem Jover committed Jun 18, 2018

This fixes a regression caused by 2d7de186. These types are not available
on all systems.

Fixes: commit 2d7de186

Signed-off-by: Guillem Jover <guillem@hadrons.org>

The loop only executes while len > 0, and the trinary operator in the
function argument is checking against len >= 1 which will always be
true.

Warned-by: coverity

The code uses an internal helper function to avoid code repetition. But
to get there, the function takes a pointer to a pointer, so that the few
functions that require returning an allocated buffer can get hold of it
this way.

The problem is that the user might pass a NULL pointer and trigger an
internal allocation even if the functions are not expected to do so.

Add a new internal helper for non-allocations, that will assert that
condition, and make any other function that requires this behavior call
this one instead.

Warned-by: coverity

Baruch Siach authored Jun 05, 2018 and Guillem Jover committed Jun 17, 2018

Commit 993828d8 (Add flopenat() function from FreeBSD) dropped the
fcntl.h header. This breaks the build with musl libc:

flopen.c: In function ‘vflopenat’:
flopen.c:60:14: error: ‘O_CREAT’ undeclared (first use in this function)
  if (flags & O_CREAT) {
              ^~~~~~~

Restore the fcntl.h header include to fix the build.

Fixes: commit 993828d8

Submitted-also-by: parazyd <parazyd@dyne.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Guillem Jover <guillem@hadrons.org>

Merge all stages so that we do not need to pass artifacts around.
Quiesce «apt install».

Run «apt install» in non-interactive mode, and do not install
Recommends. Replace build-essential, which is rather fat, with gcc
and make. Execute autogen instead of autoreconf directly.

Jakub Wilk authored May 22, 2018 and Guillem Jover committed May 23, 2018

Signed-off-by: Guillem Jover <guillem@hadrons.org>

Jakub Wilk authored May 22, 2018 and Guillem Jover committed May 23, 2018

Signed-off-by: Guillem Jover <guillem@hadrons.org>

The NetBSD implementations have different prototypes to the ones coming
from OpenBSD, which will break builds, and have caused segfaults at
run-time. We provide now both interfaces with different prototypes as
different version nodes allow selecting them at compile-time, defaulting
for now to the OpenBSD one to avoid build-time breakage, while emitting
a compile-time warning. Later on, in 0.10.0, we will be switching the
compile-time default to the NetBSD version.

Ref: http://gnats.netbsd.org/44977
Fixes: https://bugs.debian.org/899282

We need this to be able to select different version symbols at
compile-time.

We cannot refer to a License short-name if that is not on its own
License paragraph. Split several other common License fields into
their own paragraphs to avoid this problem in the future.