Commit ff924fbd authored by Edward Hervey's avatar Edward Hervey 🤘 Committed by Edward Hervey

adaptivedemux: Check live seeking range more often

The live seeking range was only checked when doing actual seeks. This was
assuming that the rate would always be 1.0 (i.e. the playback would
advance in realtime, and therefore fragments would always be available
since the seeking window moves at the same rate).

With non-1.0 rates, this no longer becomes valid, and therefore we need
to check whether we are still within the live seeking range when advancing.
parent e1bbea83
......@@ -1439,6 +1439,25 @@ gst_adaptive_demux_get_live_seek_range (GstAdaptiveDemux * demux,
return klass->get_live_seek_range (demux, range_start, range_stop);
/* must be called with manifest_lock taken */
static gboolean
gst_adaptive_demux_stream_in_live_seek_range (GstAdaptiveDemux * demux,
GstAdaptiveDemuxStream * stream)
gint64 range_start, range_stop;
if (gst_adaptive_demux_get_live_seek_range (demux, &range_start, &range_stop)) {
GST_LOG_OBJECT (stream->pad,
"stream position %" GST_STIME_FORMAT " live seek range %"
GST_STIME_ARGS (stream->segment.position), GST_STIME_ARGS (range_start),
GST_STIME_ARGS (range_stop));
return (stream->segment.position >= range_start
&& stream->segment.position <= range_stop);
return FALSE;
/* must be called with manifest_lock taken */
static gboolean
gst_adaptive_demux_can_seek (GstAdaptiveDemux * demux)
......@@ -3567,7 +3586,8 @@ gst_adaptive_demux_stream_download_loop (GstAdaptiveDemuxStream * stream)
GST_DEBUG_OBJECT (stream->pad, "EOS, checking to stop download loop");
/* we push the EOS after releasing the object lock */
if (gst_adaptive_demux_is_live (demux)) {
if (gst_adaptive_demux_is_live (demux)
&& gst_adaptive_demux_stream_in_live_seek_range (demux, stream)) {
GstAdaptiveDemuxClass *demux_class =
......@@ -3974,7 +3994,15 @@ gst_adaptive_demux_stream_advance_fragment_unlocked (GstAdaptiveDemux * demux,
if (gst_adaptive_demux_is_live (demux)
/* When advancing with a non 1.0 rate on live streams, we need to check
* the live seeking range again to make sure we can still advance to
* that position */
if (demux->segment.rate != 1.0 && gst_adaptive_demux_is_live (demux)) {
if (!gst_adaptive_demux_stream_in_live_seek_range (demux, stream))
ret = klass->stream_advance_fragment (stream);
} else if (gst_adaptive_demux_is_live (demux)
|| gst_adaptive_demux_stream_has_next_fragment (demux, stream)) {
ret = klass->stream_advance_fragment (stream);
} else {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment