Commit 51547bbc authored by Caio Oliveira's avatar Caio Oliveira
Browse files

nir: keep the phi order when splitting blocks

All things being equal is better to keep the original order.  Since
the new block is empty, push the phis in order to tail.
Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <>
Reviewed-by: Daniel Schürmann's avatarDaniel Schürmann <>
parent 38f54278
......@@ -195,8 +195,7 @@ split_block_beginning(nir_block *block)
/* Any phi nodes must stay part of the new block, or else their
* sourcse will be messed up. This will reverse the order of the phis, but
* order shouldn't matter.
* sources will be messed up.
nir_foreach_instr_safe(instr, block) {
if (instr->type != nir_instr_type_phi)
......@@ -204,7 +203,7 @@ split_block_beginning(nir_block *block)
instr->block = new_block;
exec_list_push_head(&new_block->instr_list, &instr->node);
exec_list_push_tail(&new_block->instr_list, &instr->node);
return new_block;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment