1. 21 Mar, 2021 3 commits
  2. 06 Feb, 2021 7 commits
    • Patrick Ohly's avatar
      1.99.2 pre-release · 9b7a9ed7
      Patrick Ohly authored
      9b7a9ed7
    • Patrick Ohly's avatar
      C++: better types for loop variables · bf14e339
      Patrick Ohly authored
      This addresses two different warnings from Fedora Rawhide:
      
      /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp: In member function 'std::string SyncEvo::XMLFiles::get(SyncEvo::XMLFiles::Category)':
      /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp:2390:28: error: loop variable 'entry' of type 'const StringPair&' {aka 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&'} binds to a temporary constructed from type 'std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >' [-Werror=range-loop-construct]
       2390 |     for (const StringPair &entry: m_files[category]) {
            |                            ^~~~~
      /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp:2390:28: note: use non-reference type 'const StringPair' {aka 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >'} to make the copy explicit or 'const std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&' to prevent copying
      
      This fails because StringPair has non-const members. By using "auto",
      we get rid of the need to define and pick exactly the right type.
      
      /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp: In member function 'void SyncEvo::SyncConfig::removeSyncSource(const string&)':
      /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp:2552:36: error: loop variable 'peer' creates a copy from type 'const string' {aka 'const std::__cxx11::basic_string<char>'} [-Werror=range-loop-construct]
       2552 |             for (const std::string peer: m_tree->getChildren(m_contextPath + "/peers")) {
            |                                    ^~~~
      /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp:2552:36: note: use reference type to prevent copying
       2552 |             for (const std::string peer: m_tree->getChildren(m_contextPath + "/peers")) {
            |                                    ^~~~
            |                                    &
      
      We could have used "auto" also instead of "std::string", but here it
      doesn't save that much typing and is more readable. We just have to
      use a reference.
      Signed-off-by: default avatarPatrick Ohly <patrick.ohly@intel.com>
      bf14e339
    • Patrick Ohly's avatar
      test: prefer more recent D-Bus config · 28ee02b0
      Patrick Ohly authored
      On Fedora Rawhide the old location is unusable.
      Signed-off-by: default avatarPatrick Ohly <patrick.ohly@intel.com>
      28ee02b0
    • Patrick Ohly's avatar
      GTK UI: avoid G_TYPE_INSTANCE_GET_PRIVATE · d4ed6cae
      Patrick Ohly authored
      G_TYPE_INSTANCE_GET_PRIVATE was deprecated.
      Signed-off-by: default avatarPatrick Ohly <patrick.ohly@intel.com>
      d4ed6cae
    • Patrick Ohly's avatar
      test: remove unchecked dynamic cast · 39685620
      Patrick Ohly authored
      Recent g++ on Fedora Rawhide warns that the dynamic cast result
      is used without NULL check. We know that the cast must succeed,
      so a static cast is more appropriate.
      Signed-off-by: default avatarPatrick Ohly <patrick.ohly@intel.com>
      39685620
    • Patrick Ohly's avatar
      gnome: remove libsecret include hack · e1324102
      Patrick Ohly authored
      Some older version of libsecret.h lacked `extern "C"`. Adding
      that manually now causes compile errors on Fedora Rawhide and thus
      has to be removed:
      
      /usr/include/c++/11/type_traits:480:3: error: template with C linkage
        480 |   template<typename _Tp>
            |   ^~~~~~~~
      /srv/runtests/work/sources/syncevolution/src/backends/gnome/GNOMEPlatform.cpp:24:1: note: 'extern "C"' linkage started here
         24 | extern "C" {
            | ^~~~~~~~~~
      In file included from /usr/include/glib-2.0/glib/gmacros.h:241,
                       from /usr/lib64/glib-2.0/include/glibconfig.h:9,
                       from /usr/include/glib-2.0/glib/gtypes.h:32,
                       from /usr/include/glib-2.0/glib/galloca.h:32,
                       from /usr/include/glib-2.0/glib.h:30,
                       from /usr/include/libsecret-1/libsecret/secret.h:18,
                       from /srv/runtests/work/sources/syncevolution/src/backends/gnome/GNOMEPlatform.cpp:25:
      Signed-off-by: default avatarPatrick Ohly <patrick.ohly@intel.com>
      e1324102
    • Patrick Ohly's avatar
      akonadi: avoid link error on Fedora Rawhide · 0a64fbad
      Patrick Ohly authored
      At least on Fedora Rawhide -lkdeui and -lkdecore
      are not found and not needed.
      Signed-off-by: default avatarPatrick Ohly <patrick.ohly@intel.com>
      0a64fbad
  3. 24 Jan, 2021 1 commit
  4. 28 Dec, 2020 2 commits
  5. 22 Dec, 2020 5 commits
  6. 19 Dec, 2020 1 commit
  7. 18 Dec, 2020 1 commit
    • Patrick Ohly's avatar
      tde: fix "make dist" issue · 64c62b53
      Patrick Ohly authored
      "make dist" tries to include all source files in the archive, which
      does not work for the generated files.
      64c62b53
  8. 17 Dec, 2020 1 commit
  9. 06 Dec, 2020 1 commit
  10. 05 Dec, 2020 18 commits