- 21 Mar, 2021 3 commits
-
-
Patrick Ohly authored
Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
When invoked during automated testing, stdout is not automatically configured to support UTF-8. We know that our encoding is UTF-8, so we can enable that unconditionally. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
This reverts commit 7d527c6d. It causes link errors on Fedora, see https://bugzilla.redhat.com/show_bug.cgi?id=1926932 This might be a compiler bug, but as this is a not particular important size optimization, removing it is the easiest fix. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
- 06 Feb, 2021 7 commits
-
-
Patrick Ohly authored
-
Patrick Ohly authored
This addresses two different warnings from Fedora Rawhide: /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp: In member function 'std::string SyncEvo::XMLFiles::get(SyncEvo::XMLFiles::Category)': /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp:2390:28: error: loop variable 'entry' of type 'const StringPair&' {aka 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&'} binds to a temporary constructed from type 'std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >' [-Werror=range-loop-construct] 2390 | for (const StringPair &entry: m_files[category]) { | ^~~~~ /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp:2390:28: note: use non-reference type 'const StringPair' {aka 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >'} to make the copy explicit or 'const std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&' to prevent copying This fails because StringPair has non-const members. By using "auto", we get rid of the need to define and pick exactly the right type. /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp: In member function 'void SyncEvo::SyncConfig::removeSyncSource(const string&)': /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp:2552:36: error: loop variable 'peer' creates a copy from type 'const string' {aka 'const std::__cxx11::basic_string<char>'} [-Werror=range-loop-construct] 2552 | for (const std::string peer: m_tree->getChildren(m_contextPath + "/peers")) { | ^~~~ /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp:2552:36: note: use reference type to prevent copying 2552 | for (const std::string peer: m_tree->getChildren(m_contextPath + "/peers")) { | ^~~~ | & We could have used "auto" also instead of "std::string", but here it doesn't save that much typing and is more readable. We just have to use a reference. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
On Fedora Rawhide the old location is unusable. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
G_TYPE_INSTANCE_GET_PRIVATE was deprecated. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Recent g++ on Fedora Rawhide warns that the dynamic cast result is used without NULL check. We know that the cast must succeed, so a static cast is more appropriate. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Some older version of libsecret.h lacked `extern "C"`. Adding that manually now causes compile errors on Fedora Rawhide and thus has to be removed: /usr/include/c++/11/type_traits:480:3: error: template with C linkage 480 | template<typename _Tp> | ^~~~~~~~ /srv/runtests/work/sources/syncevolution/src/backends/gnome/GNOMEPlatform.cpp:24:1: note: 'extern "C"' linkage started here 24 | extern "C" { | ^~~~~~~~~~ In file included from /usr/include/glib-2.0/glib/gmacros.h:241, from /usr/lib64/glib-2.0/include/glibconfig.h:9, from /usr/include/glib-2.0/glib/gtypes.h:32, from /usr/include/glib-2.0/glib/galloca.h:32, from /usr/include/glib-2.0/glib.h:30, from /usr/include/libsecret-1/libsecret/secret.h:18, from /srv/runtests/work/sources/syncevolution/src/backends/gnome/GNOMEPlatform.cpp:25: Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
At least on Fedora Rawhide -lkdeui and -lkdecore are not found and not needed. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
- 24 Jan, 2021 1 commit
-
-
Milan Crha authored
On Fedora, Boost placeholders are now in their own namespace. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
- 28 Dec, 2020 2 commits
-
-
Patrick Ohly authored
This GitHub action will run periodically and mirror the entire repository content. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
A lot of the old suppressions are no longer needed (determined by running valgrind with -v during a full nightly test run) and some new ones are needed after updating to new Linux distros.
-
- 22 Dec, 2020 5 commits
-
-
Patrick Ohly authored
The builtin GtkApplication support is almost equivalent and allows getting rid of the deprecated libunique which isn't available anymore in recent Linux distros. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
This no longer works when running tests in Docker containers because the wrapper script for starting there only accepts a simple command, not something that must be interpreted by a shell. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
The --as-needed linker flag didn't work anymore on recent Linux distros, with the result that libcppunit became a library dependency of the syncevolution binaries although they didn't need it. A better approach anyway is to only link the lib when it is expected to be used (unit testing or in client-test). Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
The KDE backends is now typically disabled and thus a separate KDE deb is not needed anymore. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
The soname is different on more recent Linux distros, so better leave it out. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
- 19 Dec, 2020 1 commit
-
-
Patrick Ohly authored
-
- 18 Dec, 2020 1 commit
-
-
Patrick Ohly authored
"make dist" tries to include all source files in the archive, which does not work for the generated files.
-
- 17 Dec, 2020 1 commit
-
-
Patrick Ohly authored
-
- 06 Dec, 2020 1 commit
-
-
deloptes authored
Submitted by deloptes via private email. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
- 05 Dec, 2020 18 commits
-
-
Patrick Ohly authored
This shows more clearly when OBEX function calls are made, which is relevant for libopenobex2 (OBEX_HandleInput must be called after OBEX_Request).
-
Patrick Ohly authored
-
Patrick Ohly authored
-Wno-deprecated-declarations is needed everywhere (i.e. not just in certain modules, like SYNCEVO_WFLAGS_DEPRECATED) because EDS on Ubuntu Eon uses the deprecated GDateTime in its header, which we included through our EDS/libical wrapper even when not actually used.
-
Patrick Ohly authored
-
Milan Crha authored
Developed originally by Milan Crha for Fedora, copied and updated by Patrick Ohly. From Milan: There are going to be made huge libecal API changes, as huge as it deserved a version bump from 1.2 to 2.0, and together with it a small libebook API changes, most likely being part of the evolution-data- server 3.33.2 release, which is planned for May 20. More about this can be found here: https://mail.gnome.org/archives/desktop-devel-list/2019-April/msg00016.html Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Clang complained about "exec" being uninitialized. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Found via cppcheck. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Newer clang (or was it gcc?) warn about catching exceptions by value which have virtual methods. This shouldn't have mattered here because the exception values where not really used, but using a const reference is better nonetheless. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
The signond pipe helper class uses deprecated glib methods. Not sure whether that wasn't an option at the time that it was written, but nowadays glib has classes which can be used instead. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Having to specify the type of an iterator is annoying and does not really add clarity to the code. With C++11 we can use "auto" instead and in some cases remove helper typedefs. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
This saves some space (total number of blocks for SyncEvolution object files when building statically down from 421588 to 413300) and presumably also build times (not measured). However, it did not work for all templates, leading to link errors when trying to add std::map and std::pair of strings. It probably also does not make sense for templates where only some functionality is used. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
It pulled sstream into many compilation units. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
NULL is ambiguous (can be integer and pointer) and using it as terminator for vararg list of pointers without explicit casting to a pointer was downright incorrect. nullptr fixes that. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
decltype does the same thing. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
Several headers were no longer needed resp. could be replaced by more specific ones like noncopyable.hpp. boost::assign mostly can be replaced with initialization lists and boost::tuple with std::tuple. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
This allows us to get rid of an external dependency. Mostly std::regex works, but there are limitations that have to be worked around: - no multiline support in C++11 - conversion of groups to non-string types has to be done manually While at it, use raw strings to get rid of excessive backslash escaping. pcrecpp::StringPiece was used as a general-purpose utility class. Now we have our own implementation. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
std::unique_ptr usually can be used instead. std::vector also works for arrays and even has a data() method as part of the official API in C++11. For historic reasons, the functions creating SyncSources returned plain pointers. We are breaking the API now, so we might as well fix that. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-
Patrick Ohly authored
This was committed to SVN, probably because it might have become relevant again. Now it is long obsolete. Signed-off-by:
Patrick Ohly <patrick.ohly@intel.com>
-