1. 19 Jul, 2021 1 commit
  2. 08 Jul, 2021 2 commits
  3. 26 Jun, 2021 3 commits
    • orbea's avatar
      hw/dmx/config: Link directly with libdmxconfig.a · b7adbac7
      orbea authored
      When building xserver with slibtool (https://dev.midipix.org/cross/slibtool
      
      )
      the build will fail.
      
        /usr/bin/ld: cannot find -ldmxconfig
      
      This is because xserver creates libdmxconfig.a internally and then links with
      the linker flag -ldmxconfig. However according to automake documentation the
      -lfoo linker flags should only be used for external dependencies and all
      internal libraries should be linked with the libtool archive file (.la) or
      the static archive (.a) when the former is not available.
      
      GNU libtool is far more permissive and happens to silently obscure this issue
      while slibtool fails because it instead sees '-L./.libs -ldmxconfig'.
      Signed-off-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
      (cherry picked from commit 2531ee02)
      b7adbac7
    • Zoltán Böszörményi's avatar
      xfree86: Fix NULL pointer dereference crash · e49738f0
      Zoltán Böszörményi authored
      screenp->displays[count] (passed to configDisplay() in
      configScreen()) is NULL if there is no Virtual setting
      in the configuration.
      
      Fixes: f8a6be04
      
       ("xfree86: Change
      displays array to pointers array to fix invalid pointer issues
      after table reallocation")
      Signed-off-by: Zoltán Böszörményi's avatarZoltán Böszörményi <zboszor@gmail.com>
      (cherry picked from commit ef89b664)
      e49738f0
    • Olivier Fourdan's avatar
      glx: Fix use after free in MakeCurrent · 9a59631a
      Olivier Fourdan authored
      The fix from commit c468d34c
      
       - "glx: Set ContextTag for all contexts"
      is actually incomplete, it correctly sets the context tag for direct
      contexts as well, but would fail to mark the context's currentClient.
      
      As a result, when the context is destroyed, it would be freed
      immediately rather than being just scheduled for deletion, even though
      it is still current for some client. leading to a use-after-free.
      
      Make sure to also set the context's currentClient for direct contexts as
      well, not just indirect ones.
      Signed-off-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      Fixes: c468d34c - "glx: Set ContextTag for all contexts"
      Closes: #1186
      
      Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      (cherry picked from commit aad61e8e)
      9a59631a
  4. 24 Jun, 2021 1 commit
  5. 15 Jun, 2021 1 commit
  6. 14 Jun, 2021 13 commits
  7. 09 Jun, 2021 1 commit
  8. 08 Jun, 2021 2 commits
  9. 04 May, 2021 1 commit
    • Vasily Khoruzhick's avatar
      glx: fixup symbol name for get_extensions function · 23a53f0d
      Vasily Khoruzhick authored
      
      
      glxProbeDriver() concatenates __DRI_DRIVER_GET_EXTENSIONS with driver name
      to get symbol name for get_extension function. Unfortunately that doesn't
      work for drivers that have hyphen in their name, e.g. sun4i-drm --
      get_extensions() for these uses underscore instead.
      
      As result dlsym() doesn't find get_extension() function and AIGLX
      initialization fails resulting in following message in Xorg.0.log:
      
      (EE) AIGLX error: sun4i-drm does not export required DRI extension
      
      Replace all non-alpha-numeric characters with underscore to fix the issue.
      Signed-off-by: Vasily Khoruzhick's avatarVasily Khoruzhick <anarsoul@gmail.com>
      (cherry picked from commit b56e5010)
      23a53f0d
  10. 13 Apr, 2021 2 commits
  11. 22 Feb, 2021 3 commits
  12. 21 Feb, 2021 2 commits
    • Jeremy Huddleston Sequoia's avatar
    • Jeremy Huddleston Sequoia's avatar
      xquartz: Allocate each fbconfig separately · aa6f8402
      Jeremy Huddleston Sequoia authored
      A change during the 1.20 development cycle resulted in fbconfigs being walked
      and deallocated individually during __glXScreenDestroy.  This change
      now avoids a use-after-free caused by that change.
      
      ==50859==ERROR: AddressSanitizer: heap-use-after-free on address 0x00010d3819c8 at pc 0x0001009d4230 bp 0x00016feca7a0 sp 0x00016feca798
      READ of size 8 at 0x00010d3819c8 thread T5
          #0 0x1009d422c in __glXScreenDestroy glxscreens.c:448
          #1 0x10091cc98 in __glXAquaScreenDestroy indirect.c:510
          #2 0x1009d2734 in glxCloseScreen glxscreens.c:169
          #3 0x100740a24 in dix_main main.c:325
          #4 0x10023ed50 in server_thread quartzStartup.c:65
          #5 0x199ae7fd0 in _pthread_start+0x13c (libsystem_pthread.dylib:arm64e+0x6fd0)
          #6 0x199ae2d38 in thread_start+0x4 (libsystem_pthread.dylib:arm64e+0x1d38)
      
      0x00010d3819c8 is located 200 bytes inside of 12800-byte region [0x00010d381900,0x00010d384b00)
      freed by thread T5 here:
          #0 0x101477ba8 in wrap_free+0x98 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x3fba8)
          #1 0x1009d4240 in __glXScreenDestroy glxscreens.c:449
          #2 0x10091cc98 in __glXAquaScreenDestroy indirect.c:510
          #3 0x1009d2734 in glxCloseScreen glxscreens.c:169
          #4 0x100740a24 in dix_main main.c:325
          #5 0x10023ed50 in server_thread quartzStartup.c:65
          #6 0x199ae7fd0 in _pthread_start+0x13c (libsystem_pthread.dylib:arm64e+0x6fd0)
          #7 0x199ae2d38 in thread_start+0x4 (libsystem_pthread.dylib:arm64e+0x1d38)
      
      previously allocated by thread T5 here:
          #0 0x101477e38 in wrap_calloc+0x9c (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x3fe38)
          #1 0x100925a40 in __glXAquaCreateVisualConfigs visualConfigs.c:116
          #2 0x10091cb24 in __glXAquaScreenProbe+0x224 (X11.bin:arm64+0x100730b24)
          #3 0x1009cd840 in xorgGlxServerInit glxext.c:528
          #4 0x10074539c in _CallCallbacks dixutils.c:743
          #5 0x100932a70 in CallCallbacks callback.h:83
          #6 0x100932478 in GlxExtensionInit vndext.c:244
          #7 0x10020a364 in InitExtensions miinitext.c:267
          #8 0x10073fe7c in dix_main main.c:197
          #9 0x10023ed50 in server_thread quartzStartup.c:65
          #10 0x199ae7fd0 in _pthread_start+0x13c (libsystem_pthread.dylib:arm64e+0x6fd0)
          #11 0x199ae2d38 in thread_start+0x4 (libsystem_pthread.dylib:arm64e+0x1d38)
      
      Regressed-in: 4b0a3cba
      
      
      CC: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
      Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      (cherry picked from commit 487286d4)
      aa6f8402
  13. 20 Feb, 2021 2 commits
  14. 19 Feb, 2021 6 commits