1. 18 Jun, 2022 2 commits
  2. 17 Jun, 2022 2 commits
    • Jan Palus's avatar
      bluetooth/gst: Correct var type for GST_TYPE_BITMASK · dd4dc5e8
      Jan Palus authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      GST_TYPE_BITMASK is 64-bit bit mask while corresponding channel_mask in
      pulseaudio is int therefore usually 32-bit. Switch to uint64_t instead
      to match internal representation in gstreamer.
      
      Fixes pulseaudio crash on ARM 32-bit when pulseaudio is compiled with
      gstreamer and either LDAC or aptX support is available.
      
      Part-of: <!723>
      dd4dc5e8
    • Georg Chini's avatar
      combine-sink: Fix threading issue during underrun · ee8bfb49
      Georg Chini authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      A recent commit added i->origin sink for the sink inputs of the combine sinks.
      Therefore pa_sink_process_input_underruns() treated the combine sink like
      filter sinks. pa_sink_process_input_underruns() calls itself with the
      origin sink, which is only correct for filter sinks because they run in the
      thread context of the origin sink. The combine sink however has its own
      thread context, so pa_sink_process_input_underruns() was executed in the
      wrong context.
      This patch fixes the issue by skipping the section for module-combine-sink.
      
      Part-of: <pulseaudio/pulseaudio!722>
      ee8bfb49
  3. 13 Jun, 2022 3 commits
    • Igor Kovalenko's avatar
      build-sys: meson: Make module-console-kit optional · 823e46fb
      Igor Kovalenko authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      Default build configuration would fail to run on a system without systemd-logind
      (or elogind) and without ConsoleKit daemon responding on dbus interface. Here,
      module-console-kit would fail to initialize, preventing daemon from starting.
      
      Make module-console-kit an optional build feature to allow opt-out.
      
      Part-of: <!719>
      823e46fb
    • redfast00's avatar
      rtp: fix 'size mismatch' on BSD style operating systems · 9f32b7d7
      redfast00 authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      On FreeBSD (and probably other BSDs as well), the FIONREAD ioctl
      on UDP sockets does not return the size of the next datagram (like
      it does on Linux), but returns the size of the output buffer: this
      count contain multiple datagrams and also contains the headers.
      
      We fixed this by taking the result of the FIONREAD as lower bound
      for the size, adding an upper bound and then removing the check
      that the sizes should be exactly the same.
      
      Part-of: <pulseaudio/pulseaudio!718>
      9f32b7d7
    • Igor Kovalenko's avatar
      rtp: Initialize SDP info struct field added for OPUS · d7a633df
      Igor Kovalenko authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      Turned out that pa_sdp_info::enable_opus is never initialized, which seldom
      makes module-rtp-recv believe it will be playing OPUS-encoded stream even though
      discovered SDP record does not indicate OPUS codec in metadata.
      
      Fix this by adding missing initializer.
      
      Part-of: <pulseaudio/pulseaudio!720>
      d7a633df
  4. 09 Jun, 2022 1 commit
    • Jaechul Lee's avatar
      sound-file-stream: Fix crash when playing a file which is not aligned · a8a2a314
      Jaechul Lee authored
      
      
      pulseaudio crash occurred when I play a file using pacmd play-file command.
      The file is not aligned with its frame size and the last rendering size
      is also not aligned. Thus, an assertion was generated at the end of the
      file as the following.
      
      memblockq.c: Assertion 'uchunk->length % bq->base == 0' failed at
      ../src/pulsecore/memblockq.c:288, function pa_memblockq_push(). Aborting.
      
      When I play the file using paplay, it works good. So, I changed to
      pa_memblockq_push_align instead of pa_memblockq_push to prevent the
      assertion.
      
      Signed-off-by: Jaechul Lee's avatarJaechul Lee <jcsing.lee@samsung.com>
      Part-of: <!717>
      a8a2a314
  5. 04 Jun, 2022 1 commit
    • Sean Greenslade's avatar
      pactl: fix parsing of percentages with decimal points · 05c06afa
      Sean Greenslade authored
      The logic for detecting which type of volume was given incorrectly interpreted
      any value with a decimal as a VOL_LINEAR. It also could set multiple flags,
      which would put the flags variable into an indeterminate state. Additionally,
      the flags stack variable was uninitialized which could also lead to an
      indeterminate flag state.
      
      Percentages are now prioritized over all other types, and only one type flag
      can be set.
      05c06afa
  6. 30 May, 2022 1 commit
  7. 28 May, 2022 14 commits
  8. 27 May, 2022 1 commit
    • Igor Kovalenko's avatar
      bluetooth: mSBC: Decode packets larger than mSBC frame · 9916f0ea
      Igor Kovalenko authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      Bluetooth transport layer already allows for packets larger than mSBC frame, and
      there are up to 1 + MTU / (mSBC packet size) complete frames to be decoded from
      each incoming SCO packet.
      
      Now decoder fails when there is more than one complete frame available, which
      could happen if MTU size is larger than 1.5 * (mSBC packet size) = 90
      
      Fix this by adding a loop over avialable frames, and adjust decoded buffer size
      to allow decoding up to 1 + MTU / (mSBC packet size) frames at once.
      
      Part-of: <!706>
      9916f0ea
  9. 26 May, 2022 1 commit
    • Georg Chini's avatar
      zeroconf-publish: Fix crash when avahi_client_new() fails · 65889fbd
      Georg Chini authored and PulseAudio Marge Bot's avatar PulseAudio Marge Bot committed
      When the module is loaded and avahi_client_new() fails because the client cannot
      connect, a shutdown of the module is scheduled. In parallel, the client_callback
      is called with AVAHI_ERR_DISCONNECTED and another connection attempt is made
      which also fails and triggers a second unload of the module. This crashes PA,
      because there is already an unload in progress.
      This patch fixes the problem by checking if an unload is already scheduled.
      
      Part-of: <pulseaudio/pulseaudio!710>
      65889fbd
  10. 25 May, 2022 3 commits
  11. 23 May, 2022 1 commit
  12. 22 May, 2022 1 commit
  13. 17 May, 2022 2 commits
  14. 16 May, 2022 7 commits