1. 06 Jun, 2019 1 commit
  2. 12 Dec, 2018 3 commits
    • Bastien Nocera's avatar
      elan: Fix "garbage value" errors in elan_cmd_cb() · 69fe7a1b
      Bastien Nocera authored
      libfprint/drivers/elan.c:351:4: warning: 2nd function call argument is an uninitialized value
                              dbg_buf(elandev->last_read, transfer->actual_length);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/drivers/elan.c:46:5: note: expanded from macro 'dbg_buf'
          fp_dbg("%02x", buf[0]);                                  \
          ^~~~~~~~~~~~~~~~~~~~~~
      ../../../../../../Projects/jhbuild/libfprint/libfprint/fpi-log.h:52:16: note: expanded from macro 'fp_dbg'
       #define fp_dbg g_debug
                     ^
      libfprint/drivers/elan.c:351:4: warning: The left operand of '<<' is a garbage value
                              dbg_buf(elandev->last_read, transfer->actual_length);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/drivers/elan.c:48:27: note: expanded from macro 'dbg_buf'
          fp_dbg("%04x", buf[0] << 8 | buf[1]);                    \
                         ~~~~~~ ^
      libfprint/drivers/elan.c:351:4: warning: The left operand of '<<' is a garbage value
                              dbg_buf(elandev->last_read, transfer->actual_length);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/drivers/elan.c:50:41: note: expanded from macro 'dbg_buf'
          fp_dbg("%04x... (%d bytes)", buf[0] << 8 | buf[1], len)
                                       ~~~~~~ ^
      69fe7a1b
    • Bastien Nocera's avatar
      elan: Assert on a possible division by zero in elan_need_calibration() · ce856efa
      Bastien Nocera authored
      libfprint/drivers/elan.c:598:10: warning: Division by zero
              bg_mean /= frame_size;
              ~~~~~~~~^~~~~~~~~~~~~
      ce856efa
    • Bastien Nocera's avatar
      elan: Assert on a possible division by zero in elan_process_frame_linear() · b54514df
      Bastien Nocera authored
      libfprint/drivers/elan.c:249:26: warning: Division by zero
                      px = (px - min) * 0xff / (max - min);
                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
      b54514df
  3. 13 Nov, 2018 1 commit
    • Bastien Nocera's avatar
      elan: Fix format mismatch warnings in debug output · 9da69dfc
      Bastien Nocera authored
      libfprint/drivers/elan.c:351:12: warning: format specifies type 'unsigned short' but the argument has type 'unsigned char' [-Wformat]
                              dbg_buf(elandev->last_read, transfer->actual_length);
                              ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/drivers/elan.c:46:21: note: expanded from macro 'dbg_buf'
          fp_dbg("%02hx", buf[0]);                                  \
          ~~~~~~~~~~~~~~~~^~~~~~~
      include/glib-2.0/glib/gmessages.h:345:32: note: expanded from macro 'g_debug'
                                     __VA_ARGS__)
                                     ^~~~~~~~~~~
      libfprint/drivers/elan.c:351:12: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                              dbg_buf(elandev->last_read, transfer->actual_length);
                              ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/drivers/elan.c:48:21: note: expanded from macro 'dbg_buf'
          fp_dbg("%04hx", buf[0] << 8 | buf[1]);                    \
          ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
      include/glib-2.0/glib/gmessages.h:345:32: note: expanded from macro 'g_debug'
                                     __VA_ARGS__)
                                     ^~~~~~~~~~~
      libfprint/drivers/elan.c:351:12: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                              dbg_buf(elandev->last_read, transfer->actual_length);
                              ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      libfprint/drivers/elan.c:50:35: note: expanded from macro 'dbg_buf'
          fp_dbg("%04hx... (%d bytes)", buf[0] << 8 | buf[1], len)
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
      include/glib-2.0/glib/gmessages.h:345:32: note: expanded from macro 'g_debug'
                                     __VA_ARGS__)
                                     ^~~~~~~~~~~
      libfprint/drivers/elan.c:413:10: warning: format specifies type 'unsigned short' but the argument has type 'unsigned char' [-Wformat]
              dbg_buf(cmd->cmd, 2);
              ~~~~~~~~^~~~~~~~~~~~
      libfprint/drivers/elan.c:46:21: note: expanded from macro 'dbg_buf'
          fp_dbg("%02hx", buf[0]);                                  \
          ~~~~~~~~~~~~~~~~^~~~~~~
      include/glib-2.0/glib/gmessages.h:345:32: note: expanded from macro 'g_debug'
                                     __VA_ARGS__)
                                     ^~~~~~~~~~~
      libfprint/drivers/elan.c:413:10: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
              dbg_buf(cmd->cmd, 2);
              ~~~~~~~~^~~~~~~~~~~~
      libfprint/drivers/elan.c:48:21: note: expanded from macro 'dbg_buf'
          fp_dbg("%04hx", buf[0] << 8 | buf[1]);                    \
          ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
      include/glib-2.0/glib/gmessages.h:345:32: note: expanded from macro 'g_debug'
                                     __VA_ARGS__)
                                     ^~~~~~~~~~~
      libfprint/drivers/elan.c:413:10: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
              dbg_buf(cmd->cmd, 2);
              ~~~~~~~~^~~~~~~~~~~~
      libfprint/drivers/elan.c:50:35: note: expanded from macro 'dbg_buf'
          fp_dbg("%04hx... (%d bytes)", buf[0] << 8 | buf[1], len)
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
      include/glib-2.0/glib/gmessages.h:345:32: note: expanded from macro 'g_debug'
                                     __VA_ARGS__)
                                     ^~~~~~~~~~~
      9da69dfc
  4. 27 Sep, 2018 3 commits
  5. 19 Sep, 2018 2 commits
  6. 18 Sep, 2018 5 commits
  7. 14 Sep, 2018 3 commits
  8. 05 Sep, 2018 2 commits
  9. 10 Aug, 2018 7 commits
  10. 09 Aug, 2018 1 commit
    • Igor Filatov's avatar
      elan: Change command structs, support more devices · bccff4ff
      Igor Filatov authored
      Make each command a separate struct to get finer control over which
      commands are called on which devices. Update ssm's accordingly. Add
      sensor_reset and fuse_load commands.
      
      Support 0x0903, 0x0c03, 0x0c16, 0x0c1a, 0x0c26
      bccff4ff
  11. 18 Jun, 2018 1 commit
  12. 13 Jun, 2018 1 commit
  13. 29 May, 2018 4 commits
  14. 24 May, 2018 1 commit
    • Bastien Nocera's avatar
      drivers: Simplify headers · 994061af
      Bastien Nocera authored
      Remove all the headers already included through "fp_internal.h" such as
      <libusb.h> and <errno.h>, include "assembling.h" and "driver_ids.h" there
      as well to avoid doing it in (almost) every driver.
      994061af
  15. 23 May, 2018 2 commits
  16. 03 Dec, 2017 1 commit