• Thomas Haller's avatar
    device: fix reapplying changes to connection ID and UUID · 9c72ca5e
    Thomas Haller authored
    4 properties are not really relevant for an already activated connection
    or it makes not sense to change them. These are connection.id, connection.uuid,
    connection.autoconnect and connection.stable-id.
    
    For convenience, we allow to reapply these. This way, one can take
    a different setting (e.g. with a different connection.id or
    connection.uuid) and reapply them, but such changes are silently
    ignored.
    
    However this was done wrongly. Instead of reverting the change to the new
    applied connection, we would change the input connection.
    
    This is bad, for example with
    
      nmcli connection up uuid cb922f18-e99a-49c6-b200-1678b5070a82
      nmcli connection modify cb922f18-e99a-49c6-b200-1678b5070a82 con-name "bogus"
      nmcli device reapply eth0
    
    the last re-apply would reset the settings-connection's connection ID to
    what was before, while accepting the new name on the applied-connection
    (while it should have been rejected).
    
    Fixes: bf3b3d44 ('device: avoid changing immutable properties during reapply')
    
    (cherry picked from commit adb51c2a)
    (cherry picked from commit 09f37d5b)
    9c72ca5e
Name
Last commit
Last update
clients Loading commit data...
contrib Loading commit data...
data Loading commit data...
dispatcher Loading commit data...
docs Loading commit data...
examples Loading commit data...
introspection Loading commit data...
libnm Loading commit data...
libnm-core Loading commit data...
libnm-glib Loading commit data...
libnm-util Loading commit data...
m4 Loading commit data...
man Loading commit data...
po Loading commit data...
shared Loading commit data...
src Loading commit data...
tools Loading commit data...
vapi Loading commit data...
.dir-locals.el Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING Loading commit data...
COPYING Loading commit data...
ChangeLog Loading commit data...
MAINTAINERS Loading commit data...
Makefile.am Loading commit data...
Makefile.examples Loading commit data...
Makefile.glib Loading commit data...
Makefile.vapigen Loading commit data...
NEWS Loading commit data...
NetworkManager.pc.in Loading commit data...
README Loading commit data...
TODO Loading commit data...
autogen.sh Loading commit data...
config-extra.h.meson Loading commit data...
config.h.meson Loading commit data...
configure.ac Loading commit data...
linker-script-binary.ver Loading commit data...
linker-script-devices.ver Loading commit data...
linker-script-settings.ver Loading commit data...
meson.build Loading commit data...
meson_options.txt Loading commit data...
valgrind.suppressions Loading commit data...
zanata.xml Loading commit data...