• Francesco Giudici's avatar
    dhclient: fix updating the DUID in multiline lease files · 56865366
    Francesco Giudici authored
    The nm_dhcp_dhclient_save_duid() function will save a newly generated
    DUID to a previously existing lease file. The function will only save
    the DUID if not present in the lease file: in this case, should preserve
    the other contents of the lease file.
    A dhclient lease file for IPv6 generated by NetworkManager will always
    add the DUID as a first item: so in practice finding a lease file
    without DUID will never happen.
    This has hidden a bug in the function: the loop that is meant to append
    the non-duid lines in the lease file would strip all the newlines,
    mangling the lease file.
    Fix the function allowing to keep the original lines and add a test to
    check this functionality is kept well functioning.
    
    FIXME: the new test and the other duid ones already there  store the file
    in the current working-directory. Tests should not do that.
    56865366
Name
Last commit
Last update
clients Loading commit data...
contrib Loading commit data...
data Loading commit data...
dispatcher Loading commit data...
docs Loading commit data...
examples Loading commit data...
introspection Loading commit data...
libnm Loading commit data...
libnm-core Loading commit data...
libnm-glib Loading commit data...
libnm-util Loading commit data...
m4 Loading commit data...
man Loading commit data...
po Loading commit data...
shared Loading commit data...
src Loading commit data...
tools Loading commit data...
vapi Loading commit data...
.dir-locals.el Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING Loading commit data...
COPYING Loading commit data...
ChangeLog Loading commit data...
MAINTAINERS Loading commit data...
Makefile.am Loading commit data...
Makefile.examples Loading commit data...
Makefile.glib Loading commit data...
Makefile.vapigen Loading commit data...
NEWS Loading commit data...
NetworkManager.pc.in Loading commit data...
README Loading commit data...
TODO Loading commit data...
autogen.sh Loading commit data...
config.h.meson Loading commit data...
configure.ac Loading commit data...
linker-script-binary.ver Loading commit data...
linker-script-devices.ver Loading commit data...
linker-script-settings.ver Loading commit data...
meson.build Loading commit data...
meson_options.txt Loading commit data...
meson_post_install.py Loading commit data...
valgrind.suppressions Loading commit data...
zanata.xml Loading commit data...