device: ppp: check that connection has a PPPoE parent

NMDevicePPP only handles connections with the pppoe.parent property
set. match_connection() already checks this when we creating a new
device. We should also perform the same check in
check_connection_compatible().

Fixes: 6c319593 ('core: implement activation of PPP devices')

#203
14 jobs for bg/pppoe-issue203 in 43 minutes and 46 seconds (queued for 1 minute and 57 seconds)
latest
Status Job ID Name Coverage
  Test
passed #396380
allowed to fail
checkpatch

00:01:16

manual #396385
allowed to fail manual
t_centos:7.5.1804
passed #396386
t_centos:7.6.1810

00:19:04

failed #396389
t_debian:9

00:14:52

passed #396391
t_debian:sid

00:19:25

manual #396390
allowed to fail manual
t_debian:testing
passed #396381
t_fedora:28

00:36:57

passed #396382
t_fedora:29

00:42:03

passed #396383
t_fedora:30

00:29:19

manual #396384
allowed to fail manual
t_fedora:rawhide
passed #396387
t_ubuntu:16.04

00:20:04

passed #396388
t_ubuntu:18.04

00:20:10

 
  External
passed NetworkManager test verification

passed NetworkManager test verification

05:55:44

 
Name Stage Failure
failed
t_debian:9 Test
+ xargs -0 grep -H '^'
>>>> PRINT VALGRIND LOGS (valgrind test) (done)
valgrind test failed
+ true
+ echo '>>>> PRINT VALGRIND LOGS (valgrind test) (done)'
+ die 'valgrind test failed'
+ printf '%s\n' 'valgrind test failed'
+ exit 1
ERROR: Job failed: exit code 1