wwan/modem-broadband: look up default APN if GSM conneciton lacks one

This allows the GSM connection to Just Work most of the time, as in:
"nmcli d connect ttyUSB0".
14 jobs for lr/gsm-default-apn in 21 minutes and 38 seconds (queued for 1 second)
Status Job ID Name Coverage
  Test
failed #368646
allowed to fail
checkpatch

00:01:27

manual #368651
allowed to fail manual
t_centos:7.5.1804
failed #368652
t_centos:7.6.1810

00:21:34

failed #368655
t_debian:9

00:18:43

failed #368657
t_debian:sid

00:19:00

manual #368656
allowed to fail manual
t_debian:testing
failed #368647
t_fedora:28

00:20:40

failed #368648
t_fedora:29

00:21:02

failed #368649
t_fedora:30

00:17:48

manual #368650
allowed to fail manual
t_fedora:rawhide
failed #368653
t_ubuntu:16.04

00:10:35

failed #368654
t_ubuntu:18.04

00:12:38

 
  External
failed NetworkManager test verification

failed NetworkManager test verification

03:17:43

 
Name Stage Failure
failed
t_centos:7.6.1810 Test
SOURCE_CONFIG_CONNECTIVITY_REDHAT=/builds/NetworkManager/NetworkManager/contrib/fedora/rpm/20-connectivity-redhat.conf
BUILDTYPE=
NM_RPMBUILD_ARGS=--with crypto_gnutls --with debug --with iwd --with test --without meson

UUID=332cda87-f14d-4ddd-9b31-d42c0813f610
BASEDIR=/builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105733.5ED70y
error: /builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105733.5ED70y/SPECS/NetworkManager.spec:226: Got a %endif with no %if
ERROR: rpmbuild FAILED
ERROR: Job failed: exit code 1
failed
t_fedora:29 Test
NM_RPMBUILD_ARGS=--with crypto_gnutls --with debug --with iwd --with test --without meson

UUID=dd0f8006-955c-4d27-b8d5-dd1a0accde93
BASEDIR=/builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105658.8oNqCm
warning: Macro expanded in comment on line 139: %{real_version_major}/%{name}-%{real_version}.tar.xz

error: /builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105658.8oNqCm/SPECS/NetworkManager.spec:226: Got a %endif with no %if
ERROR: rpmbuild FAILED
ERROR: Job failed: exit code 1
failed
t_fedora:28 Test
NM_RPMBUILD_ARGS=--with crypto_gnutls --with debug --with iwd --with test --without meson

UUID=8d44521b-d5f2-425e-8050-d7fecbe8bf7d
BASEDIR=/builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105639.t0PMoK
warning: Macro expanded in comment on line 139: %{real_version_major}/%{name}-%{real_version}.tar.xz

error: /builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105639.t0PMoK/SPECS/NetworkManager.spec:226: Got a %endif with no %if
ERROR: rpmbuild FAILED
ERROR: Job failed: exit code 1
failed
t_debian:sid Test
Has header "pppd/pppd.h" : YES
Program pppd found: YES (/usr/sbin/pppd)
Dependency mm-glib found: YES 1.10.0
Dependency mobile-broadband-provider-info found: NO (tried pkgconfig)

meson.build:509:2: ERROR: Dependency "mobile-broadband-provider-info" not found, tried pkgconfig

A full log can be found at /builds/NetworkManager/NetworkManager/build/meson-logs/meson-log.txt
ERROR: Job failed: exit code 1
failed
t_debian:9 Test
Has header "pppd/pppd.h" : YES 
Program pppd found: YES (/usr/sbin/pppd)
Run-time dependency mm-glib found: YES 1.6.4
Run-time dependency mobile-broadband-provider-info found: NO (tried pkgconfig)

meson.build:509:2: ERROR: Dependency "mobile-broadband-provider-info" not found, tried pkgconfig

A full log can be found at /builds/NetworkManager/NetworkManager/build/meson-logs/meson-log.txt
ERROR: Job failed: exit code 1
failed
t_fedora:30 Test
NM_RPMBUILD_ARGS=--with crypto_gnutls --with debug --with iwd --with test --without meson

UUID=639bc973-3964-469d-8294-8e58851fe193
BASEDIR=/builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105338.kRRtDE
warning: Macro expanded in comment on line 139: %{real_version_major}/%{name}-%{real_version}.tar.xz

error: /builds/NetworkManager/NetworkManager/contrib/fedora/rpm/NetworkManager.20190619-105338.kRRtDE/SPECS/NetworkManager.spec:226: Got a %endif with no %if
ERROR: rpmbuild FAILED
ERROR: Job failed: exit code 1
failed
t_ubuntu:18.04 Test
Has header "pppd/pppd.h" : YES 
Program pppd found: YES (/usr/sbin/pppd)
Run-time dependency mm-glib found: YES 1.10.0
Run-time dependency mobile-broadband-provider-info found: NO (tried pkgconfig)

meson.build:509:2: ERROR: Dependency "mobile-broadband-provider-info" not found, tried pkgconfig

A full log can be found at /builds/NetworkManager/NetworkManager/build/meson-logs/meson-log.txt
ERROR: Job failed: exit code 1
failed
t_ubuntu:16.04 Test
Has header "pppd/pppd.h" : YES 
Program pppd found: YES (/usr/sbin/pppd)
Run-time dependency mm-glib found: YES 1.6.4
Run-time dependency mobile-broadband-provider-info found: NO (tried pkgconfig)

meson.build:509:2: ERROR: Dependency "mobile-broadband-provider-info" not found, tried pkgconfig

A full log can be found at /builds/NetworkManager/NetworkManager/build/meson-logs/meson-log.txt
ERROR: Job failed: exit code 1
failed
checkpatch Test

src/devices/wwan/nm-service-providers.h:33: Don't use glib typedefs for char/short/int/long/float/double:
> const gchar *mccmnc,

The patch does not validate.
Uploading artifacts...
checkpatch-out.txt: found 1 matching files
Uploading artifacts to coordinator... ok id=368646 responseStatus=201 Created token=tpu8PtVa
ERROR: Job failed: exit code 1