cli: verify connections before sending them over to daemon

This way we generate the error messages on the client side and therefore
can localize them.
7 jobs for lr/sae in 21 minutes and 31 seconds (queued for 1 minute and 1 second)
latest
Status Job ID Name Coverage
  Test
failed #99104
allowed to fail
checkpatch

00:05:06

failed #99105
f28_build_autotools

00:15:37

passed #99106
f28_build_meson

00:05:21

passed #99107
f28_rpm_autotools_dbg

00:07:54

passed #99108
f28_rpm_meson_dbg

00:13:04

failed #99109
f_latest_build_autotools

00:20:21

failed #99110
allowed to fail
f_rawhide_build_autotools

00:04:13

 
Name Stage Failure
failed
f_latest_build_autotools Test
(./src/platform/tests/test-link-linux:5918): NetworkManager-DEBUG: 09:41:37.250: <trace> [1549359697.2507] platform-linux: delayed-action: handle read-netlink
# NetworkManager-DEBUG: <trace> [1549359697.2508] platform-linux: netlink: recvmsg: new message RTM_NEWLINK, flags 0, seq 0
(./src/platform/tests/test-link-linux:5918): NetworkManager-DEBUG: 09:41:37.250: <trace> [1549359697.2508] platform-linux: netlink: recvmsg: new message RTM_NEWLINK, flags 0, seq 0
# NetworkManager-DEBUG: <trace> [1549359697.2508] platform-linux: event-notification: RTM_NEWLINK, flags 0, seq 0: 126: t-00012 <NOARP,DOWN;broadcast,noarp> mtu 1500 arp 1 dummy* not-init addrgenmode eui64 addr 9E:18:21:04:D7:FE rx:0,0 tx:0,0
(./src/platform/tests/test-link-linux:5918): NetworkManager-DEBUG: 09:41:37.250: <trace> [1549359697.2508] platform-linux: event-notification: RTM_NEWLINK, flags 0, seq 0: 126: t-00012 <NOARP,DOWN;broadcast,noarp> mtu 1500 arp 1 dummy* not-init addrgenmode eui64 addr 9E:18:21:04:D7:FE rx:0,0 tx:0,0
# NetworkManager-DEBUG: <trace> [1549359697.2509] platform-linux: update-cache-link: ADD: [link,0x1bf4140,4,+alive,+visible,+in-nl,(nil); 126: t-00012 <NOARP,DOWN;broadcast,noarp> mtu 1500 arp 1 dummy* init addrgenmode eui64 addr 9E:18:21:04:D7:FE driver dummy rx:0,0 tx:0,0]
(./src/platform/tests/test-link-linux:5918): NetworkManager-DEBUG: 09:41:37.250: <trace> [1549359697.2509] platform-linux: update-cache-link: ADD: [link,0x1bf4140,4,+alive,+visible,+in-nl,(nil); 126: t-00012 <NOARP,DOWN;broadcast,noarp> mtu 1500 arp 1 dummy* init addrgenmode eui64 addr 9E:18:21:04:D7:FE driver dummy rx:0,0 tx:0,0]
# NetworkManager-DEBUG: <trace> [1549359697.2509] platform: (t-00012) emit signal link-changed added: 126: t-00012 <NOARP,DOWN;broadcast,noarp> mtu 1500 arp 1 dummy* init addrgenmode eui64 addr 9E:18:21:04:D7:FE driver dummy rx:0,0 tx:0,0
(./src/platform/tests/test-link-linux:5918): NetworkManager-DEBUG: 09:41:37.250
Job's log exceeded limit of 8388608 bytes.
failed
f28_build_autotools Test
(./src/platform/tests/test-link-linux:6004): NetworkManager-DEBUG: 09:35:12.592: <debug> [1549359312.5922] platform-test[13.985760297]: Command finished: result=0
# NetworkManager-DEBUG: <trace> [1549359312.5924] platform-linux: delayed-action: schedule read-netlink
(./src/platform/tests/test-link-linux:6004): NetworkManager-DEBUG: 09:35:12.592: <trace> [1549359312.5924] platform-linux: delayed-action: schedule read-netlink
# NetworkManager-DEBUG: <trace> [1549359312.5925] platform-linux: delayed-action: handle read-netlink
(./src/platform/tests/test-link-linux:6004): NetworkManager-DEBUG: 09:35:12.592: <trace> [1549359312.5925] platform-linux: delayed-action: handle read-netlink
# NetworkManager-DEBUG: <trace> [1549359312.5925] platform-linux: netlink: recvmsg: new message RTM_NEWLINK, flags 0, seq 0
(./src/platform/tests/test-link-linux:6004): NetworkManager-DEBUG: 09:35:12.592: <trace> [1549359312.5925] platform-linux: netlink: recvmsg: new message RTM_NEWLINK, flags 0, seq 0
# NetworkManager-DEBUG: <trace> [1549359312.5926] platform-linux: event-notification: RTM_NEWLINK, flags 0, seq 0: 124: t-00010 <NOARP,DOWN;broadcast,noarp> mtu 1500 arp 1 dummy* not-init addrgenmode eui64 addr 82:0B:A9:F9:27:9C rx:0,0 tx:0,0
(./src/p
Job's log exceeded limit of 8388608 bytes.
failed
f_rawhide_build_autotools Test
  CC       src/devices/bluetooth/libnm_device_plugin_bluetooth_la-nm-bluez-device.lo
cc1: all warnings being treated as errors
make[2]: *** [Makefile:14560: src/devices/wwan/libnm_wwan_la-nm-modem-broadband.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/builds/NetworkManager/NetworkManager/build'
make[1]: *** [Makefile:18308: all-recursive] Error 1
make[1]: Leaving directory '/builds/NetworkManager/NetworkManager/build'
make: *** [Makefile:8167: all] Error 2
ERROR: Job failed: exit code 1
failed
checkpatch Test

clients/cli/connections.c:4866: Bad indentation:
> return;

The patch does not validate.
Uploading artifacts...
checkpatch-out.txt: found 1 matching files
Uploading artifacts to coordinator... ok
id=99104 responseStatus=201 Created token=xfYUYRxN
ERROR: Job failed: exit code 1