1. 04 Dec, 2014 1 commit
  2. 13 Nov, 2014 1 commit
    • Dan Winship's avatar
      libnm*: fix library gettext usage · 53f5e9af
      Dan Winship authored
      Libraries need to include <gi18n-lib.h>, not <gi18n.h>, so that _()
      will get defined to "dgettext (GETTEXT_DOMAIN, string)" rather than
      "gettext (string)" (which will use the program's default domain, which
      works fine for programs in the NetworkManager tree, but not for
      external users). Likewise, we need to call bindtextdomain() so that
      gettext can find the translations if the library is installed in a
      different prefix from the program using it (and
      bind_textdomain_codeset(), so it will know the translations are in
      UTF-8 even if the locale isn't).
      (The fact that no one noticed this was broken before is because the
      libraries didn't really start returning useful translated strings much
      until 0.9.10, and none of the out-of-tree clients have been updated to
      actually show those strings to users yet.)
  3. 15 Jul, 2014 2 commits
    • Dan Winship's avatar
      libnm-util, libnm-glib: whitespace fixes · 2570c5a1
      Dan Winship authored
      Fix indentation, kill trailing whitespace, split some long lines.
    • Dan Winship's avatar
      libnm-util, libnm-glib: standardize copyright/license headers · cb7e1893
      Dan Winship authored
      - Remove list of authors from files that had them; these serve no
        purpose except to quickly get out of date (and were only used in
        libnm-util and not libnm-glib anyway).
      - Just say "Copyright", not "(C) Copyright" or "Copyright (C)"
      - Put copyright statement after the license, not before
      - Remove "NetworkManager - Network link manager" from the few files
        that contained it, and "libnm_glib -- Access network status &
        information from glib applications" from the many files that
        contained it.
      - Remove vim modeline from nm-device-olpc-mesh.[ch], add emacs modeline
        to files that were missing it.
  4. 12 May, 2014 2 commits
  5. 02 May, 2014 1 commit
  6. 13 Feb, 2013 1 commit
    • Dan Winship's avatar
      all: remove pointless NULL checks · d04f2863
      Dan Winship authored
      g_malloc(), etc, never return NULL, by API contract. Likewise, by
      extension, no other glib function ever returns NULL due to lack of
      memory. So remove lots of unnecessary checks (the vast majority of
      which would have immediately crashed had they ever run anyway, since
      g_set_error(), g_warning(), and nm_log_*() all need to allocate
  7. 13 May, 2011 1 commit
  8. 31 Mar, 2011 1 commit
    • Dan Williams's avatar
      libnm-util: don't ever deinit crypto methods (bgo #646300) · 5b0ef4c2
      Dan Williams authored
      Because we can't ever know if we're the last user of NSS or gnutls
      when nm_utils_deinit() is called, just don't bother deiniting
      the crypto providers.  And atexit handlers are generally frowned
      upon for the exact same reason.  You never know what library linked
      into your process might be also using NSS or gnutls, so basically
      if these libraries suck enough to use global data and not reference
      count it, just let the data leak.  If we do clean stuff up that
      can lead to crashes when other libraries might try to use NSS or
      gnutls after the atexit handler or nm_utils_deinit() has been run.
      See also:  https://bugzilla.mozilla.org/show_bug.cgi?id=54189#c1
  9. 21 Jan, 2010 1 commit
  10. 02 Oct, 2009 1 commit
  11. 15 Sep, 2009 1 commit
    • Dan Williams's avatar
      libnm-util: add nm_utils_rsa_key_encrypt() and fix crypto padding mixups · 8c35e96b
      Dan Williams authored
      To be backwards compatible clients need to handle both paths to private
      keys and the decrypted private key data, which is what used to get passed
      in the private-key and phase2-private-key attributes of the 802.1x setting.
      When moving a connection around between system-settings and user-settings,
      if the private key is decrypted data, the settings service needs to store
      that decrypted data somewhere so that the key can be sent to NM during
      the connection process.
      But we don't want to store the decrypted private key data, so we have to
      re-encrypt it (possibly generating a private key password if one wasn't
      sent with the decrypted data) and save it to disk, then send NM a path
      to that private key during connection.
      To help clients do this, and so that they don't have to carry around
      multiple crypto implementations depending on whether they want to use
      NSS or gnutls/gcrypt, add a helper to libnm-util.
      Furthermore, I misunderstood a bunch of stuff with crypto padding when
      writing the encrypt/decrypt functions long ago, so fix that up.  Don't
      return padding as part of the decrypted data, and make sure to verify
      the padding's expected lengths and values when decrypting.  Many thanks
      to Nalin Dahyabhai for pointing me in the right direction.
  12. 14 Nov, 2008 1 commit
  13. 13 Nov, 2008 1 commit
    • Dan Williams's avatar
      2008-11-13 Dan Williams <dcbw@redhat.com> · e2f65ce1
      Dan Williams authored
      	Add support for PKCS#12 private keys (bgo #558982)
      	* libnm-util/crypto.c
      		- (parse_old_openssl_key_file): rename from parse_key_file(); adapt to
      			take a GByteArray instead of a filename
      		- (file_to_g_byte_array): handle private key files too
      		- (decrypt_key): take a GByteArray rather than data + len
      		- (crypto_get_private_key_data): refactor crypto_get_private_key() into
      			one function that takes a filename, and one that takes raw data;
      			detect pkcs#12 files as well
      		- (crypto_load_and_verify_certificate): detect file type
      		- (crypto_is_pkcs12_data, crypto_is_pkcs12_file): add pkcs#12 detection
      	* libnm-util/crypto_gnutls.c
      		- (crypto_decrypt): take GByteArray rather than data + len; fix a bug
      			whereby tail padding was incorrectly handled, leading to erroneous
      			successes when trying to decrypt the data
      		- (crypto_verify_cert): rework somewhat
      		- (crypto_verify_pkcs12): validate pkcs#12 keys
      	* libnm-util/crypto_nss.c
      		- (crypto_init): enable various pkcs#12 ciphers
      		- (crypto_decrypt): take a GByteArray rather than data + len
      		- (crypto_verify_cert): clean up
      		- (crypto_verify_pkcs12): validate pkcs#12 keys
      	* libnm-util/test-crypto.c
      		- Handle pkcs#12 keys
      	* libnm-util/nm-setting-8021x.c
      		- Add two new properties, 'private-key-password' and
      			'phase2-private-key-password', to be used in conjunction with
      			pkcs#12 keys
      		- (nm_setting_802_1x_set_ca_cert_from_file,
      		   nm_setting_802_1x_set_phase2_client_from_file): return certificate
      		- (nm_setting_802_1x_get_private_key_password,
      		   nm_setting_802_1x_get_phase2_private_key_password): return private
      			key passwords
      		- (nm_setting_802_1x_set_private_key_from_file,
      		   nm_setting_802_1x_set_phase2_private_key_from_file): set the private
      			key from a file, and update the private key password at the same time
      		- (nm_setting_802_1x_get_private_key_type,
      		   nm_setting_802_1x_get_phase2_private_key_type): return the private
      			key type
      	* src/supplicant-manager/nm-supplicant-settings-verify.c
      		- Whitelist private key passwords
      	* src/supplicant-manager/nm-supplicant-config.c
      		- (nm_supplicant_config_add_setting_8021x): for pkcs#12 private keys,
      			add the private key password to the supplicant config, but do not
      			add the client certificate (as required by wpa_supplicant)
      git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@4280 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
  14. 08 Sep, 2008 1 commit
    • Dan Williams's avatar
      2008-09-08 Dan Williams <dcbw@redhat.com> · 796829ce
      Dan Williams authored
      	Patch from Alexander Sack <asac@ubuntu.com>
      	* libnm-util/crypto_gnutls.c
      		- (crypto_init, crypto_deinit): just use a boolean instead of a refcount
      	* libnm-util/nm-utils.c
      		- (nm_utils_init): initialize libnm-util
      		- (nm_utils_deinit): de-initialize libnm-util and clean up resources
      	* libnm-util/nm-setting-8021x.c
      		- (nm_setting_802_1x_class_init): init libnm-util when needed
      git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@4047 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
  15. 05 Sep, 2008 1 commit
  16. 26 Aug, 2008 1 commit
  17. 27 Jul, 2008 1 commit
  18. 26 Jun, 2008 1 commit
  19. 19 May, 2008 1 commit
    • Tambet Ingo's avatar
      2008-05-15 Tambet Ingo <tambet@gmail.com> · 40a69f98
      Tambet Ingo authored
      	Move crypto functions from nm-applet to libnm-util.
      	* libnm-util/nm-setting-8021x.c (nm_setting_802_1x_set_ca_cert)
      	(nm_setting_802_1x_set_phase2_private_key): Implement. Given a certificate
      	file (or private key and it's password), read the certificate data.
      	* libnm-util/crypto_nss.c:
      	* libnm-util/crypto_gnutls.c:
      	* libnm-util/crypto.[ch]: Move here from nm-applet.
      	* configure.in: Check for NSS and gnutls here (moved here from nm-applet).
      	* system-settings/plugins/ifcfg-suse/parser.c (read_wpa_eap_settings):
      	Imlement WPA-EAP configuration reading from sysconfig.
      git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@3673 4912f4e0-d625-0410-9fb7-b9a5a253dbdc