1. 30 Aug, 2019 4 commits
  2. 29 Aug, 2019 1 commit
  3. 28 Aug, 2019 29 commits
  4. 27 Aug, 2019 6 commits
    • Thomas Haller's avatar
      acd: fix memleak in acd_event() · 0300c182
      Thomas Haller authored
      Only happens with debug logging enabled. So, not a large problem.
      
      Found by Coverity.
      
      Fixes: d9a4b59c ('acd: adapt NM code and build options')
      0300c182
    • Thomas Haller's avatar
      contrib/rpm: explicitly set runstatedir to "/run" when building release tarball · 081b16cd
      Thomas Haller authored
      Nowadays, we should prefer "/run" over "/var/run". When not specifying
      during ./configure, autotools however still defaults to "/var/run".
      
      This default is also visible in the pre-generated documenation, for
      example `man NetworkManager.conf` says
      
        Unless the symlink points to the internal file /run/NetworkManager/resolv.conf,
        in which case the ...
      081b16cd
    • Thomas Haller's avatar
      01ef7c40
    • Thomas Haller's avatar
      keyfile: let keyfile writer serialize setting with all default values · ddd148e0
      Thomas Haller authored
      It's important whether a setting is present or not. Keyfile writer
      omits properties that have a default value, that means, if the setting
      has all-default values, it would be dropped. For [proxy] that doesn't
      really matter, because we tend to normalize it back. For some settings
      it matters:
      
        $ nmcli connection add type bluetooth con-name bt autoconnect no bluetooth.type dun bluetooth.bdaddr aa:bb:cc:dd:ee:ff gsm.apn a
        Connection 'bt' (652cabd8-d350-4246-a6f3-3dc17eeb028f) successfully added.
      
        $ nmcli connection modify bt gsm.apn ''
      
      When storing this to keyfile, the [gsm] section was dropped
      (server-side) and we fail an nm_assert() (omitted from the example
      output below).
      
        <error> [1566732645.9845] BUG: failure to normalized profile that we just wrote to disk: bluetooth: 'dun' connection requires 'gsm' or 'cdma' setting
        <trace> [1566732645.9846] keyfile: commit: "/etc/NetworkManager/system-connections/bt.nmconnection": profile 652cabd8-d350-4246-a6f3-3dc17eeb028f (bt) written
        <trace> [1566732645.9846] settings: update[652cabd8-d350-4246-a6f3-3dc17eeb028f]: update-from-dbus: update profile "bt"
        <trace> [1566732645.9849] settings: storage[652cabd8-d350-4246-a6f3-3dc17eeb028f,3e504752a4a78fb3/keyfile]: change event with connection "bt" (file "/etc/NetworkManager/system-connections/>
        <trace> [1566732645.9849] settings: update[652cabd8-d350-4246-a6f3-3dc17eeb028f]: updating connection "bt" (3e504752a4a78fb3/keyfile)
        <debug> [1566732645.9857] ++ connection 'update connection' (0x7f7918003340/NMSimpleConnection/"bluetooth" < 0x55e1c52480e0/NMSimpleConnection/"bluetooth") [/org/freedesktop/NetworkManager>
        <debug> [1566732645.9857] ++ gsm                       [ 0x55e1c5276f80 < 0x55e1c53205f0 ]
        <debug> [1566732645.9858] ++ gsm.apn                   < 'a'
      
      Of course, after reload the connection on disk is no loner valid.
      Keyfile writer wrote an invalid setting.
      
        # nmcli connection reload
      
      Logfile:
      
        <warn>  [1566732775.4920] keyfile: load: "/etc/NetworkManager/system-connections/bt.nmconnection": failed to load connection: invalid connection: bluetooth: 'dun' connection requires 'gsm' or 'cdma' setting
        ...
        <trace> [1566732775.5432] settings: update[652cabd8-d350-4246-a6f3-3dc17eeb028f]: delete connection "bt" (3e504752a4a78fb3/keyfile)
        <debug> [1566732775.5434] Deleting secrets for connection /org/freedesktop/NetworkManager/Settings (bt)
        <trace> [1566732775.5436] dbus-object[9a402fbe14c8d975]: unexport: "/org/freedesktop/NetworkManager/Settings/55"
      ddd148e0
    • Thomas Haller's avatar
      keyfile: refactor _parse_info_find() to get ParseInfoSetting · e6eb01c1
      Thomas Haller authored
      I thought I would need this, but ended up not using it.
      
      Anyway, it makes sense in general that the function can lookup
      all relevant information, so merge it.
      e6eb01c1
    • Thomas Haller's avatar