1. 26 Mar, 2018 1 commit
  2. 13 Apr, 2017 2 commits
  3. 03 Oct, 2016 1 commit
  4. 29 Mar, 2016 1 commit
  5. 03 Mar, 2016 2 commits
    • Thomas Haller's avatar
      all: don't include error->code in log messages · cd4f84b7
      Thomas Haller authored
      GError codes are only unique per domain, so logging the code without
      also indicating the domain is not helpful. And anyway, if the error
      messages are not distinctive enough to tell the whole story then we
      should fix the error messages.
      Based-on-patch-by: Dan Winship's avatarDan Winship <danw@gnome.org>
      cd4f84b7
    • Thomas Haller's avatar
      all: clean-up usage of GError · 01b9b410
      Thomas Haller authored
      Functions that take a GError** MUST fill it in on error. There is no
      need to check whether error is NULL if the function it was passed to
      had a failing return value.
      
      Likewise, a proper GError must have a non-NULL message, so there's no
      need to double-check that either.
      Based-on-patch-by: Dan Winship's avatarDan Winship <danw@gnome.org>
      01b9b410
  6. 19 Feb, 2016 1 commit
    • Thomas Haller's avatar
      all: cleanup includes and let "nm-default.h" include "config.h" · 8bace23b
      Thomas Haller authored
      - All internal source files (except "examples", which are not internal)
        should include "config.h" first. As also all internal source
        files should include "nm-default.h", let "config.h" be included
        by "nm-default.h" and include "nm-default.h" as first in every
        source file.
        We already wanted to include "nm-default.h" before other headers
        because it might contains some fixes (like "nm-glib.h" compatibility)
        that is required first.
      
      - After including "nm-default.h", we optinally allow for including the
        corresponding header file for the source file at hand. The idea
        is to ensure that each header file is self contained.
      
      - Don't include "config.h" or "nm-default.h" in any header file
        (except "nm-sd-adapt.h"). Public headers anyway must not include
        these headers, and internal headers are never included after
        "nm-default.h", as of the first previous point.
      
      - Include all internal headers with quotes instead of angle brackets.
        In practice it doesn't matter, because in our public headers we must
        include other headers with angle brackets. As we use our public
        headers also to compile our interal source files, effectively the
        result must be the same. Still do it for consistency.
      
      - Except for <config.h> itself. Include it with angle brackets as suggested by
        https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
      8bace23b
  7. 05 Aug, 2015 1 commit
  8. 24 Jul, 2015 2 commits
    • Dan Winship's avatar
      libnm-glib: drop private bus support · ee707ba9
      Dan Winship authored
      Anything that actually *needs* private bus support will be built
      against libnm these days anyway.
      ee707ba9
    • Dan Winship's avatar
      all: rename nm-glib-compat.h to nm-glib.h, use everywhere · 3452ee2a
      Dan Winship authored
      Rather than randomly including one or more of <glib.h>,
      <glib-object.h>, and <gio/gio.h> everywhere (and forgetting to include
      "nm-glib-compat.h" most of the time), rename nm-glib-compat.h to
      nm-glib.h, include <gio/gio.h> from there, and then change all .c
      files in NM to include "nm-glib.h" rather than including the glib
      headers directly.
      
      (Public headers files still have to include the real glib headers,
      since nm-glib.h isn't installed...)
      
      Also, remove glib includes from header files that are already
      including a base object header file (which must itself already include
      the glib headers).
      3452ee2a
  9. 13 Nov, 2014 1 commit
    • Dan Winship's avatar
      all: consistently include config.h · 3bfb163a
      Dan Winship authored
      config.h should be included from every .c file, and it should be
      included before any other include. Fix that.
      
      (As a side effect of how I did this, this also changes us to
      consistently use "config.h" rather than <config.h>. To the extent that
      it matters [which is not much], quotes are more correct anyway, since
      we're talking about a file in our own build tree, not a system
      include.)
      3bfb163a
  10. 27 Aug, 2014 1 commit
  11. 15 Jul, 2014 2 commits
    • Dan Winship's avatar
      libnm-util, libnm-glib: whitespace fixes · 2570c5a1
      Dan Winship authored
      Fix indentation, kill trailing whitespace, split some long lines.
      2570c5a1
    • Dan Winship's avatar
      libnm-util, libnm-glib: standardize copyright/license headers · cb7e1893
      Dan Winship authored
      - Remove list of authors from files that had them; these serve no
        purpose except to quickly get out of date (and were only used in
        libnm-util and not libnm-glib anyway).
      
      - Just say "Copyright", not "(C) Copyright" or "Copyright (C)"
      
      - Put copyright statement after the license, not before
      
      - Remove "NetworkManager - Network link manager" from the few files
        that contained it, and "libnm_glib -- Access network status &
        information from glib applications" from the many files that
        contained it.
      
      - Remove vim modeline from nm-device-olpc-mesh.[ch], add emacs modeline
        to files that were missing it.
      cb7e1893
  12. 19 Jun, 2014 1 commit
  13. 31 Jul, 2013 1 commit
  14. 08 May, 2013 1 commit
  15. 19 Apr, 2013 1 commit
  16. 08 Apr, 2013 3 commits
    • Dan Williams's avatar
      libnm-glib: never call NM D-Bus methods if NM isn't running · 110a4035
      Dan Williams authored
      Though the client shouldn't be calling anything when NM isn't running
      (because clients have nm_client_get_manager_running()), make sure
      that NMClient never calls a NetworkManager method when NM isn't
      on the bus.
      
      Next, ensure NMObject doesn't try to refresh properties when NM isn't
      running.  Creating an NMClient may trigger a property refresh request,
      but if NM isn't running, defer that until NM starts, to ensure that
      we don't D-Bus autostart NM.
      
      Third, ensure NMRemoteSettings doesn't attempt to list connections
      unless NM is running.
      
      This prevents service activation of NetworkManager in lieu of dbus-glib
      learning about DBUS_HEADER_FLAG_NO_AUTO_START.
      110a4035
    • Dan Williams's avatar
      libnm-glib: use private connection before trying the system bus · a87b5a15
      Dan Williams authored
      Use the D-Bus connection helper whenever we need a connection to
      NM, which by default tries to use a private connection instead of
      the shared bus connection whenever the user is root.  Doing this
      by default will not change the behavior of libnm-glib, and allows
      tools like nmcli and libnm-glib-using clients to work in minimal
      environments (those without a bus daemon) by default.
      a87b5a15
    • Dan Williams's avatar
      libnm-glib: use helpers to create dbus proxies · 661d0985
      Dan Williams authored
      When using a private connection, we need to use dbus_g_proxy_new_for_peer()
      because the bus isn't involved.  Since many parts of libnm-glib create a
      proxy for their corresponding remote object, consolidate the proxy creation
      logic.
      
      A later patch will add logic to use a private connection versus a bus-based
      one.
      661d0985
  17. 07 Mar, 2013 1 commit
  18. 04 Dec, 2012 1 commit
    • Dan Williams's avatar
      core: fix agent secret cancelation · 8b7287ab
      Dan Williams authored
      Two issues here: first, the daemon code was using the wrong D-Bus type
      (strings instead of object-path) to send the connection path to the
      secret agent, which resulted in a method-not-found error and nothing
      happening in the agent.
      
      Second, the agent-side method call verification code would fail the
      request anyway, becuase verify_request() determined success based
      on the reconstructed connection, which isn't given when canceling
      secrets requests.
      8b7287ab
  19. 26 Sep, 2012 1 commit
    • Dan Winship's avatar
      all: Don't use ctype.h macros · 6878d20a
      Dan Winship authored
      The ctype macros (eg, isalnum(), tolower()) are locale-dependent. Use
      glib's ASCII-only versions instead.
      
      Also, replace isascii() with g_ascii_isprint(), since isascii()
      accepts control characters, which isn't what the code wanted in any of
      the places where it was using it.
      6878d20a
  20. 27 Apr, 2012 1 commit
  21. 23 Apr, 2012 1 commit
  22. 19 Mar, 2012 1 commit
  23. 15 Feb, 2012 1 commit
    • Dan Winship's avatar
      Use glib-mkenums to generate enum types · 839eab55
      Dan Winship authored
      Rather than generating enum classes by hand (and complaining in each
      file that "this should really be standard"), use glib-mkenums.
      
      Unfortunately, we need a very new version of glib-mkenums in order to
      deal with NM's naming conventions and to fix a few other bugs, so just
      import that into the source tree temporarily.
      
      Also, to simplify the use of glib-mkenums, import Makefile.glib from
      https://bugzilla.gnome.org/654395.
      
      To avoid having to run glib-mkenums for every subdirectory of src/,
      add a new "generated" directory, and put the generated enums files
      there.
      
      Finally, use Makefile.glib for marshallers too, and generate separate
      ones for libnm-glib and NetworkManager.
      839eab55
  24. 26 Jan, 2012 1 commit
  25. 26 Oct, 2011 1 commit
  26. 17 Mar, 2011 1 commit
  27. 10 Mar, 2011 1 commit
  28. 02 Mar, 2011 1 commit
  29. 22 Feb, 2011 1 commit
  30. 19 Jan, 2011 1 commit
  31. 18 Jan, 2011 3 commits
  32. 13 Jan, 2011 1 commit