1. 13 Apr, 2018 1 commit
  2. 22 Mar, 2017 2 commits
  3. 20 Mar, 2017 1 commit
  4. 08 Mar, 2017 1 commit
  5. 21 Jun, 2016 1 commit
  6. 03 Mar, 2016 2 commits
    • Thomas Haller's avatar
      all: don't include error->code in log messages · cd4f84b7
      Thomas Haller authored
      GError codes are only unique per domain, so logging the code without
      also indicating the domain is not helpful. And anyway, if the error
      messages are not distinctive enough to tell the whole story then we
      should fix the error messages.
      Based-on-patch-by: Dan Winship's avatarDan Winship <danw@gnome.org>
      cd4f84b7
    • Thomas Haller's avatar
      all: clean-up usage of GError · 01b9b410
      Thomas Haller authored
      Functions that take a GError** MUST fill it in on error. There is no
      need to check whether error is NULL if the function it was passed to
      had a failing return value.
      
      Likewise, a proper GError must have a non-NULL message, so there's no
      need to double-check that either.
      Based-on-patch-by: Dan Winship's avatarDan Winship <danw@gnome.org>
      01b9b410
  7. 23 Feb, 2016 2 commits
  8. 19 Feb, 2016 1 commit
    • Thomas Haller's avatar
      all: cleanup includes and let "nm-default.h" include "config.h" · 8bace23b
      Thomas Haller authored
      - All internal source files (except "examples", which are not internal)
        should include "config.h" first. As also all internal source
        files should include "nm-default.h", let "config.h" be included
        by "nm-default.h" and include "nm-default.h" as first in every
        source file.
        We already wanted to include "nm-default.h" before other headers
        because it might contains some fixes (like "nm-glib.h" compatibility)
        that is required first.
      
      - After including "nm-default.h", we optinally allow for including the
        corresponding header file for the source file at hand. The idea
        is to ensure that each header file is self contained.
      
      - Don't include "config.h" or "nm-default.h" in any header file
        (except "nm-sd-adapt.h"). Public headers anyway must not include
        these headers, and internal headers are never included after
        "nm-default.h", as of the first previous point.
      
      - Include all internal headers with quotes instead of angle brackets.
        In practice it doesn't matter, because in our public headers we must
        include other headers with angle brackets. As we use our public
        headers also to compile our interal source files, effectively the
        result must be the same. Still do it for consistency.
      
      - Except for <config.h> itself. Include it with angle brackets as suggested by
        https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
      8bace23b
  9. 09 Dec, 2015 1 commit
  10. 04 Dec, 2015 1 commit
  11. 01 Dec, 2015 1 commit
  12. 25 Nov, 2015 2 commits
    • Beniamino Galvani's avatar
      libnm-glib: add support for TUN devices · 8ca6e412
      Beniamino Galvani authored
      Since libnm is the preferred way to interact with NM now, we don't
      want to add new device types to libnm-glib.
      
      Make libnm-glib recognize TUN devices as generic ones and modify
      NMDeviceGeneric to use the correct D-Bus interface based on the actual
      device type.
      8ca6e412
    • Beniamino Galvani's avatar
      libnm-glib: refactor _nm_device_type_for_path() · 33e76cf0
      Beniamino Galvani authored
      Refactor nm-device.c to expose a private _nm_device_type_for_path()
      function which can be used by subclasses to query the actual device
      type. In particular, NMDeviceGeneric will use the result of this
      function to figure out which interface to use for the D-Bus proxy.
      33e76cf0
  13. 18 Sep, 2015 1 commit
  14. 05 Aug, 2015 2 commits
  15. 24 Jul, 2015 2 commits
    • Dan Winship's avatar
      all: rename nm-glib-compat.h to nm-glib.h, use everywhere · 3452ee2a
      Dan Winship authored
      Rather than randomly including one or more of <glib.h>,
      <glib-object.h>, and <gio/gio.h> everywhere (and forgetting to include
      "nm-glib-compat.h" most of the time), rename nm-glib-compat.h to
      nm-glib.h, include <gio/gio.h> from there, and then change all .c
      files in NM to include "nm-glib.h" rather than including the glib
      headers directly.
      
      (Public headers files still have to include the real glib headers,
      since nm-glib.h isn't installed...)
      
      Also, remove glib includes from header files that are already
      including a base object header file (which must itself already include
      the glib headers).
      3452ee2a
    • Dan Winship's avatar
      include: add nm-dbus-compat.h · dd0e1989
      Dan Winship authored
      Add a file containing the defines like DBUS_INTERFACE_DBUS from
      dbus-shared.h, and use it from the gdbus-using files.
      
      Also, convert a bunch of other places that were previously hardcoding
      the string values to use the defines instead, and fix the ifcfg-rh
      plugin to properly namespace its own D-Bus-related defines.
      dd0e1989
  16. 18 Dec, 2014 1 commit
  17. 13 Nov, 2014 2 commits
    • Dan Winship's avatar
      libnm*: fix library gettext usage · 53f5e9af
      Dan Winship authored
      Libraries need to include <gi18n-lib.h>, not <gi18n.h>, so that _()
      will get defined to "dgettext (GETTEXT_DOMAIN, string)" rather than
      "gettext (string)" (which will use the program's default domain, which
      works fine for programs in the NetworkManager tree, but not for
      external users). Likewise, we need to call bindtextdomain() so that
      gettext can find the translations if the library is installed in a
      different prefix from the program using it (and
      bind_textdomain_codeset(), so it will know the translations are in
      UTF-8 even if the locale isn't).
      
      (The fact that no one noticed this was broken before is because the
      libraries didn't really start returning useful translated strings much
      until 0.9.10, and none of the out-of-tree clients have been updated to
      actually show those strings to users yet.)
      53f5e9af
    • Dan Winship's avatar
      all: consistently include config.h · 3bfb163a
      Dan Winship authored
      config.h should be included from every .c file, and it should be
      included before any other include. Fix that.
      
      (As a side effect of how I did this, this also changes us to
      consistently use "config.h" rather than <config.h>. To the extent that
      it matters [which is not much], quotes are more correct anyway, since
      we're talking about a file in our own build tree, not a system
      include.)
      3bfb163a
  18. 22 Jul, 2014 2 commits
  19. 15 Jul, 2014 3 commits
    • Dan Winship's avatar
      libnm-util, libnm-glib: whitespace fixes · 2570c5a1
      Dan Winship authored
      Fix indentation, kill trailing whitespace, split some long lines.
      2570c5a1
    • Dan Winship's avatar
      libnm-util, libnm-glib: standardize copyright/license headers · cb7e1893
      Dan Winship authored
      - Remove list of authors from files that had them; these serve no
        purpose except to quickly get out of date (and were only used in
        libnm-util and not libnm-glib anyway).
      
      - Just say "Copyright", not "(C) Copyright" or "Copyright (C)"
      
      - Put copyright statement after the license, not before
      
      - Remove "NetworkManager - Network link manager" from the few files
        that contained it, and "libnm_glib -- Access network status &
        information from glib applications" from the many files that
        contained it.
      
      - Remove vim modeline from nm-device-olpc-mesh.[ch], add emacs modeline
        to files that were missing it.
      cb7e1893
    • Dan Winship's avatar
      libnm-util, libnm-glib: tweak (element-type) annotations in docs · 4223fa47
      Dan Winship authored
      g-i allows you to specify types in annotations using either their
      fully-qualified introspected names (eg, "NMClient.Device") or their
      plain C names ("NMDevice"). Switch from the former to the latter (so
      that they'll still be correct when migrated to libnm later).
      4223fa47
  20. 19 Jun, 2014 2 commits
  21. 05 Jun, 2014 1 commit
  22. 06 Mar, 2014 1 commit
  23. 13 Feb, 2014 1 commit
  24. 27 Jan, 2014 1 commit
  25. 20 Dec, 2013 2 commits
  26. 19 Dec, 2013 1 commit
  27. 06 Nov, 2013 1 commit
  28. 19 Oct, 2013 1 commit