1. 20 Jan, 2015 1 commit
  2. 19 Jan, 2015 1 commit
    • Lubomir Rintel's avatar
      cli: fix client bond option count · 1bc942b1
      Lubomir Rintel authored
      Looks more like 5, not 7, unless a particular mode is selected:
      
      There are 7 optional arguments for 'bond' connection type.
      Do you want to provide them? (yes/no) [yes]
      Bonding mode [balance-rr]:
      Bonding monitoring mode (miimon/arp) [miimon]:
      Bonding miimon [100]:
      Bonding downdelay [0]:
      Bonding updelay [0]:
      1bc942b1
  3. 11 Jan, 2015 1 commit
  4. 07 Jan, 2015 2 commits
    • Jiří Klimeš's avatar
      tui: fix crash when editing DSL connection · cf0a87c5
      Jiří Klimeš authored
       Program received signal SIGSEGV, Segmentation fault.
       0x000000000041b3e5 in nmt_page_dsl_constructed (object=0x7fffec0228c0 [NmtPageDsl]) at nmt-page-dsl.c:109
       109		priv->ethernet_page = nmt_page_ethernet_new (conn, nmt_editor_page_device_get_device_entry (NMT_EDITOR_PAGE_DEVICE (dsl)));
       Missing separate debuginfos, use: debuginfo-install libffi-3.0.10-3.fc18.x86_64 newt-0.52.15-1.fc19.x86_64
       (gdb) bt
       #0  0x000000000041b3e5 in nmt_page_dsl_constructed (object=0x7fffec0228c0 [NmtPageDsl]) at nmt-page-dsl.c:109
       #1  0x0000003e9ac161e3 in g_object_newv (object_type=1, object_type@entry=16203872, n_parameters=n_parameters@entry=2, parameters=parameters@entry=0xf74350)
          at gobject.c:1741
       #2  0x0000003e9ac16560 in g_object_new_valist (object_type=object_type@entry=16203872, first_property_name=first_property_name@entry=0x42e524 "connection",
          var_args=var_args@entry=0x7fffffffcef8) at gobject.c:1830
       #3  0x0000003e9ac16894 in g_object_new (object_type=16203872, first_property_name=first_property_name@entry=0x42e524 "connection") at gobject.c:1545
       #4  0x000000000041b504 in nmt_page_dsl_new (conn=<optimized out>, deventry=deventry@entry=0x974690 [NmtDeviceEntry]) at nmt-page-dsl.c:47
       #5  0x000000000041808e in nmt_editor_constructed (object=<optimized out>) at nmt-editor.c:355
       #6  0x0000003e9ac161e3 in g_object_newv (object_type=1, object_type@entry=16174256, n_parameters=n_parameters@entry=4, parameters=parameters@entry=0xf6cec0)
           at gobject.c:1741
       ...
       (gdb) p priv
       $1 = (NmtPageDslPrivate *) 0x0
      cf0a87c5
    • Jiří Klimeš's avatar
      675d545b
  5. 22 Dec, 2014 2 commits
  6. 12 Dec, 2014 2 commits
    • Jiří Klimeš's avatar
      cli: fix DEADCODE (CWE-561) found by coverity · bcd5b2cd
      Jiří Klimeš authored
      Error: DEADCODE (CWE-561): [#def3]
      NetworkManager-0.9.11.0/clients/cli/utils.c:488: cond_notnull: Condition "input", taking true branch. Now the value of "input" is not "NULL".
      NetworkManager-0.9.11.0/clients/cli/utils.c:517: notnull: At condition "input", the value of "input" cannot be "NULL".
      NetworkManager-0.9.11.0/clients/cli/utils.c:517: dead_error_condition: The condition "input" must be true.
      NetworkManager-0.9.11.0/clients/cli/utils.c:517: dead_error_line: Execution cannot reach the expression """" inside this statement: "g_set_error(error, 1U, 0, d...".
      bcd5b2cd
    • Jiří Klimeš's avatar
      cli: mute coverity for Error: DEADCODE (CWE-561) · ed088b0d
      Jiří Klimeš authored
      It can't recognize that the variables are set when parsing arguments.
      ed088b0d
  7. 11 Dec, 2014 1 commit
  8. 05 Dec, 2014 3 commits
  9. 03 Dec, 2014 3 commits
  10. 01 Dec, 2014 2 commits
  11. 28 Nov, 2014 1 commit
  12. 25 Nov, 2014 1 commit
  13. 24 Nov, 2014 1 commit
  14. 21 Nov, 2014 9 commits
    • Dan Winship's avatar
      libnm: rename NMSecretAgent to NMSecretAgentOld · 71b4c05f
      Dan Winship authored
      As with NMVpnPluginOld, rename NMSecretAgent to NMSecretAgentOld, to
      leave the name "NMSecretAgent" open for a new-and-improved version in
      NM 1.2.
      71b4c05f
    • Dan Williams's avatar
      clients: merge nm_secret_agent_simple_set_connection_path() into nm_secret_agent_simple_enable() · 88c9c6a6
      Dan Williams authored
      set_connection_path() is almost always called right before enable(),
      and it's unclear why it would be called anywhere else.  So just
      merge the two methods.
      88c9c6a6
    • Dan Winship's avatar
      clients: NMSecretAgentSimple API fixups · a1f74635
      Dan Winship authored
      nm_secret_agent_simple_*() functions should take an
      NMSecretAgentSimple, not an NMSecretAgent.
      
      The type macros were incorrectly validating against
      NM_TYPE_SECRET_AGENT rather than NM_TYPE_SECRET_AGENT_SIMPLE.
      a1f74635
    • Lubomir Rintel's avatar
      nmtui: Add a not reached assert to make compiler happy · 13beedc8
      Lubomir Rintel authored
      nmt-editor.c: In function ‘nmt_editor_constructed’:
      nmt-editor.c:365:2: error: ‘page’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
        add_sections_for_page (editor, grid, page);
        ^
      13beedc8
    • Dan Winship's avatar
      tui: tweak NmtEditorGrid column rules · 04ef74b1
      Dan Winship authored
      If an NmtEditorGrid row has a widget, but no label, then we make the
      widget span both the label and widget columns. But previously we
      weren't doing the same for rows with labels but no widgets. (In fact,
      we didn't even allow rows with no widgets; label-only rows had to
      specify dummy widgets.)
      
      Fix it so that labels will span into an empty widget column. (This
      ensures that a long section name won't force the entire grid to have
      an overwide label column).
      
      Also, in both the "no label" and "no widget" cases, still show the
      "extra" column if it's present.
      04ef74b1
    • Dan Winship's avatar
      tui: simplify DSL page handling · 5f6b0be5
      Dan Winship authored
      Rather than having NmtEditor need to know that DSL requires a DSL
      page, and Ethernet page, and a PPP page, just have the DSL page itself
      return multiple sections.
      5f6b0be5
    • Dan Winship's avatar
      tui: rework how editor pages work · 2afb1acb
      Dan Winship authored
      Instead of having NmtEditorPage be a widget itself, have it just be an
      object that returns a list of NmtEditorSections, where
      NmtEditorSection is a subclass of NmtNewtSection.
      
      (This will be important when adding VPN pages, which will be split up
      into multiple sections, but with the different sections needing to
      cooperate on updating the NMSettingVpn. This reorganization lets us
      have an NMPageVpn containing multiple sections, with the NMPageVpn
      object handling the coordination between the sections.)
      2afb1acb
    • Dan Winship's avatar
      tui: merge NmtPageMain into NmtEditor · 84d87554
      Dan Winship authored
      All page types except NmtPageMain are displayed as collapsible
      sections. NmtPageMain behaved quite differently from everything else.
      So merge it into its container, NmtEditor.
      84d87554
    • Dan Winship's avatar
      tui: rename two classes · 277ed5be
      Dan Winship authored
      Rename NmtPageDevice to NmtEditorPageDevice, and rename NmtPageGrid to
      NmtEditorGrid.
      
      Now all types with names starting with "NmtPage" are instantiable page
      types, not abstract classes or low-level widgets.
      277ed5be
  15. 20 Nov, 2014 4 commits
  16. 19 Nov, 2014 6 commits