1. 22 Jan, 2019 1 commit
  2. 28 Nov, 2018 1 commit
  3. 25 Oct, 2018 1 commit
  4. 19 Sep, 2018 1 commit
  5. 18 Sep, 2018 3 commits
  6. 17 Sep, 2018 1 commit
  7. 14 Sep, 2018 3 commits
  8. 13 Sep, 2018 14 commits
  9. 08 Sep, 2018 2 commits
  10. 04 Sep, 2018 2 commits
    • Thomas Haller's avatar
      libnm/crypto: rework endianness detection for crypto_verify_pkcs12() · 08c80dd2
      Thomas Haller authored
      At other places, we already use __BYTE_ORDER define to detect endianness.
      We don't need multiple mechanisms.
      
      Also note that meson did not do the correct thing as AC_C_BIGENDIAN,
      so meson + nss + big-endian was possibly broken.
      08c80dd2
    • Thomas Haller's avatar
      build: enable building both crypto backends for tests · e01f7f2c
      Thomas Haller authored
      If the library is available, let's at least compile both
      crypto backends.
      
      That is helpful when developing on crypto backends, so that
      one does not have to configure the build twice.
      
      With autotools, the build is only run during `make check`.
      Not for meson, but that is generally the case with our meson
      setup, that it also builds tests during the regular build step.
      e01f7f2c
  11. 27 Aug, 2018 2 commits
    • Thomas Haller's avatar
      build: cleanup build defines for session-tracking · 1a9bc224
      Thomas Haller authored
      - always define the SESSION_TRACKING_* defines to replace
        "#ifdef" with "#if".
      
      - drop defining the consolekit database path CKDB_PATH in
        config.h. The path was not customizable via configure/meson.
      
      - fix meson build to enable consolekit support for session tracking
        without also enabling logind/elogind session tracking.
        logind/elogind is mutually exclusive, but consolekit session tracking
        goes together just fine.
      1a9bc224
    • Thomas Haller's avatar
      build: always define NM_MORE_LOGGING define and don't check with #ifdef · 3b5f8c91
      Thomas Haller authored
      Using '#ifdef' is generally error prone. It's better to always define
      a define and check for it explicitly. This way, the compiler can issue
      a warning if the define does not exist.
      
      Also, note how meson would always define NM_MORE_LOGGING, possibly to
      "0". That means, for meson, we unintentionally always enabled more
      logging because the define was always present.
      
      Fix that.
      3b5f8c91
  12. 13 Aug, 2018 1 commit
  13. 26 Jul, 2018 1 commit
    • Thomas Haller's avatar
      build: avoid AC_CHECK_FILE() due to problems with cross-compilation · 81e5b262
      Thomas Haller authored
      AC_CHECK_FILE() does not work for cross compilation. Autoconf
      documentation says:
      
        Be aware that, like most Autoconf macros, they test a feature of the
        host machine, and therefore, they die when cross-compiling. [1]
      
      Test for the existance of the file directly. Of course, when cross
      compiling, it's not at all clear that the host machine will run the same
      distribution. And thus detecting --enable-ifcfg-rh based on the build
      machine is likely wrong. Note, that we already did
      
          AS_IF([test -z "$hostname_persist" -a -f /etc/SuSE-release], hostname_persist=suse)
      
      which has the same problem.
      
      At least, build no longer fails, and the user can inspect the ./configure
      summary and see which features were misdetected.
      
      [1] https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Files.html
      81e5b262
  14. 25 Jul, 2018 1 commit
  15. 29 Jun, 2018 1 commit
  16. 27 Jun, 2018 2 commits
    • Thomas Haller's avatar
      logging: warn about invalid logging backends and drop "debug" backend · dbd48f26
      Thomas Haller authored
      "debug" was documentation in `man NetworkManager.conf` as a valid
      logging backend. However, it was completely ignored by
      nm_logging_syslog_openlog().
      In fact, it makes not sense. Passing debug = TRUE to
      nm_logging_syslog_openlog(), means that all messages will be
      printed to stderr in addition to syslog/journal. However, when
      NetworkManager is daemonizing, stderr is closed.
      Whether NetworkManager is daemonizing depends entirely on command
      line options --no-daemon and --debug. Hence, the logging backend "debug"
      from the configuration file either conflicts or is redundant.
      
      Also, adjust logging backend description in `man NetworkManager.conf`.
      
      Also, log a warning about invalid/unsupported logging backend.
      
      (cherry picked from commit 2ccf6168)
      dbd48f26
    • Thomas Haller's avatar
      logging: warn about invalid logging backends and drop "debug" backend · 2ccf6168
      Thomas Haller authored
      "debug" was documentation in `man NetworkManager.conf` as a valid
      logging backend. However, it was completely ignored by
      nm_logging_syslog_openlog().
      In fact, it makes not sense. Passing debug = TRUE to
      nm_logging_syslog_openlog(), means that all messages will be
      printed to stderr in addition to syslog/journal. However, when
      NetworkManager is daemonizing, stderr is closed.
      Whether NetworkManager is daemonizing depends entirely on command
      line options --no-daemon and --debug. Hence, the logging backend "debug"
      from the configuration file either conflicts or is redundant.
      
      Also, adjust logging backend description in `man NetworkManager.conf`.
      
      Also, log a warning about invalid/unsupported logging backend.
      2ccf6168
  17. 15 Jun, 2018 3 commits