1. 08 Jan, 2015 1 commit
  2. 05 Jan, 2015 1 commit
  3. 18 Dec, 2014 2 commits
  4. 15 Dec, 2014 1 commit
  5. 25 Nov, 2014 1 commit
  6. 24 Nov, 2014 1 commit
  7. 13 Nov, 2014 2 commits
    • Dan Winship's avatar
      libnm*: fix library gettext usage · 53f5e9af
      Dan Winship authored
      Libraries need to include <gi18n-lib.h>, not <gi18n.h>, so that _()
      will get defined to "dgettext (GETTEXT_DOMAIN, string)" rather than
      "gettext (string)" (which will use the program's default domain, which
      works fine for programs in the NetworkManager tree, but not for
      external users). Likewise, we need to call bindtextdomain() so that
      gettext can find the translations if the library is installed in a
      different prefix from the program using it (and
      bind_textdomain_codeset(), so it will know the translations are in
      UTF-8 even if the locale isn't).
      
      (The fact that no one noticed this was broken before is because the
      libraries didn't really start returning useful translated strings much
      until 0.9.10, and none of the out-of-tree clients have been updated to
      actually show those strings to users yet.)
      53f5e9af
    • Dan Winship's avatar
      all: consistently include config.h · 3bfb163a
      Dan Winship authored
      config.h should be included from every .c file, and it should be
      included before any other include. Fix that.
      
      (As a side effect of how I did this, this also changes us to
      consistently use "config.h" rather than <config.h>. To the extent that
      it matters [which is not much], quotes are more correct anyway, since
      we're talking about a file in our own build tree, not a system
      include.)
      3bfb163a
  8. 24 Oct, 2014 1 commit
    • Lubomir Rintel's avatar
      tests: Don't run session-long dbus daemons for tests · e9bfd0e2
      Lubomir Rintel authored
      They require a tty or X11 displays, thus are not suitable for headless runs
      (such as in mock). Furthermore, they die with the tty or X11 session, which
      is somehow late -- a lot of them may accumulate. Let's kill them right away.
      e9bfd0e2
  9. 17 Oct, 2014 1 commit
    • Florian Muellner's avatar
      remote-settings: Mark service as running when using private bus · 261a3924
      Florian Muellner authored
      When using a private bus connection, the service is never marked
      as running when settings are initialized asynchronously. Successfully
      opening a socket in NM's runtime directory should already imply
      a running service, so just mark it as such (as we already do in
      the synchronous path).
      261a3924
  10. 05 Oct, 2014 1 commit
  11. 27 Aug, 2014 1 commit
  12. 18 Aug, 2014 1 commit
  13. 07 Aug, 2014 1 commit
  14. 01 Aug, 2014 10 commits
  15. 30 Jul, 2014 1 commit
    • Dan Winship's avatar
      tools: move libnm-glib's fake NM service implementations here · 5432ef5e
      Dan Winship authored
      Move libnm-glib's test-fake-nm.py and test-remote-settings-service.py
      to tools/, merge them together into a single program, and fix a few
      bugs (notably some missing signal emissions in the Settings service).
      
      Although they are currently only used by libnm-glib's tests, they are
      generic enough that they could be used by other code in the future
      (and in particular, they will be used by libnm's tests as well).
      5432ef5e
  16. 27 Jul, 2014 1 commit
    • Thomas Haller's avatar
      libnm-glib: fix gtk-doc for NMClient:active-connections · 7f35d808
      Thomas Haller authored
      Since previous commit dafe51e8,
      the gtk-doc is no longer ignored. However, the angle brackets
      add invalid XML characters to ./docs/libnm-glib/xml/nm-client.xml
      This breaks the build.
      
          make[3]: Entering directory `./NetworkManager/docs/libnm-glib'
            DOC   Scanning header files
            DOC   Introspecting gobjects
            DOC   Building HTML
          ../xml/nm-client.xml:1110: parser error : Opening and ending tag mismatch: NMActiveConnection line 1109 and para
          </para></refsect2>
                 ^
          ../xml/nm-client.xml:1110: parser error : Opening and ending tag mismatch: para line 1107 and refsect2
          </para></refsect2>
                            ^
          ../xml/nm-client.xml:1211: parser error : Opening and ending tag mismatch: refsect2 line 1104 and refsect1
          </refsect1>
                     ^
          ../xml/nm-client.xml:1262: parser error : Opening and ending tag mismatch: refsect1 line 1095 and refentry
          </refentry>
                     ^
          ../xml/nm-client.xml:1263: parser error : Premature end of data in tag refentry line 7
      
          ^
          ../libnm-glib-docs.xml:67: element include: XInclude error : could not load ../xml/nm-client.xml, and no fallback was found
          make[3]: *** [html-build.stamp] Error 6
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      7f35d808
  17. 25 Jul, 2014 1 commit
    • Dan Winship's avatar
      libnm-glib: document some properties · dafe51e8
      Dan Winship authored
      Some libnm-glib object properties were only documented in the
      GParamSpec strings, not via gtk-doc comments, so they became
      undocumented when the paramspec strings went away. Fix that.
      
      (Also fix incorrect gtk-doc syntax with several NMClient properties.)
      dafe51e8
  18. 22 Jul, 2014 2 commits
  19. 21 Jul, 2014 1 commit
  20. 20 Jul, 2014 1 commit
    • Dan Winship's avatar
      libnm-glib: fix assertion-failure messages in test-remote-settings-client · 396610d1
      Dan Winship authored
      test-remote-setting-client uses a macro:
      
          #define test_assert(condition) \
          do { \
              if (!G_LIKELY (condition)) \
                  cleanup (); \
              g_assert (condition); \
          } while (0)
      
      where cleanup() kills the fake remote-settings service and unrefs
      settings. However, in many cases, "condition" would involve a test
      against a connection that was owned by settings, so if the check
      failed, the connection would end up getting freed by cleanup(), and so
      then the second invocation of condition would result in the program
      aborting on a failed check somewhere else (eg, "invalid unclassed
      pointer in cast to 'NMConnection'") rather than displaying the failed
      assertion that had gotten us to that point.
      
      Fix this by not unreffing settings from cleanup(); in the normal exit
      case we can just have main() unref it, and in the assertion-failed
      case, we don't need to free things anyway.
      396610d1
  21. 15 Jul, 2014 5 commits
    • Dan Winship's avatar
      build: more srcdir!=builddir fixes · 30c74c60
      Dan Winship authored
      nm-version.h was getting disted, making srcdir!=builddir work for
      tarball builds, but not for git builds.
      
      Also, remove "-I${top_builddir}/include" from all Makefile.ams, since
      there's nothing generated in include/ any more.
      30c74c60
    • Dan Winship's avatar
      libnm-glib: drop separate test library · 3aad3124
      Dan Winship authored
      Previously, we built a second copy of libnm-glib that was hacked to
      use the session bus rather than the system bus, for use by the test
      programs. Rather than doing that, just have test-nm-client explicitly
      override the choice of bus. (test-remote-settings-client was actually
      already doing this, although it leaked the bus after.)
      3aad3124
    • Dan Winship's avatar
      libnm-util, libnm-glib: whitespace fixes · 2570c5a1
      Dan Winship authored
      Fix indentation, kill trailing whitespace, split some long lines.
      2570c5a1
    • Dan Winship's avatar
      libnm-util, libnm-glib: standardize copyright/license headers · cb7e1893
      Dan Winship authored
      - Remove list of authors from files that had them; these serve no
        purpose except to quickly get out of date (and were only used in
        libnm-util and not libnm-glib anyway).
      
      - Just say "Copyright", not "(C) Copyright" or "Copyright (C)"
      
      - Put copyright statement after the license, not before
      
      - Remove "NetworkManager - Network link manager" from the few files
        that contained it, and "libnm_glib -- Access network status &
        information from glib applications" from the many files that
        contained it.
      
      - Remove vim modeline from nm-device-olpc-mesh.[ch], add emacs modeline
        to files that were missing it.
      cb7e1893
    • Dan Winship's avatar
      libnm-util, libnm-glib: tweak (element-type) annotations in docs · 4223fa47
      Dan Winship authored
      g-i allows you to specify types in annotations using either their
      fully-qualified introspected names (eg, "NMClient.Device") or their
      plain C names ("NMDevice"). Switch from the former to the latter (so
      that they'll still be correct when migrated to libnm later).
      4223fa47
  22. 14 Jul, 2014 2 commits
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      libnm-glib: fix initialization of NMObject type · 568742ed
      Thomas Haller authored
      Ensure that the @type_funcs and @type_async_funcs
      hashes are initialized before running the class
      init function.
      
      libnm-glib-scan hits the following assertion:
        GLib-CRITICAL **: g_hash_table_insert_internal: assertion 'hash_table != NULL' failed
        #0  0x0000003370c504e9 in g_logv (log_domain=0x3370cb2f4e "GLib", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffd1578f70) at gmessages.c:989
        #1  0x0000003370c5063f in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at gmessages.c:1025
        #2  0x00007f2169f42545 in _nm_object_register_type_func (base_type=base_type@entry=13597296, type_func=type_func@entry=0x7f2169f47ae9 <_nm_device_type_for_path>, type_async_func=type_async_func@entry=
            0x7f2169f47880 <_nm_device_type_for_path_async>) at nm-object.c:551
        #3  0x00007f2169f48664 in nm_device_get_type () at nm-device.c:62
        #4  0x0000000000402577 in get_object_types () at libnm-glib-scan.c:46
        #5  0x0000000000404b0b in main (argc=<optimized out>, argv=<optimized out>) at libnm-glib-scan.c:135
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      568742ed
  23. 08 Jul, 2014 1 commit