1. 15 Apr, 2017 1 commit
    • Lubomir Rintel's avatar
      m4: disable -Wmissing-braces for newer clang · 43012156
      Lubomir Rintel authored
        src/NetworkManagerUtils.c:347:18: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
                NMIPAddr a1 = { 0 }, a2 = { 0 };
                                ^
                                {}
      
      Should we initialize unions this way? I think it's all right -- the initializer
      works well and { { { 0 } } } is probably not what we'd like to see.
      43012156
  2. 10 Feb, 2017 2 commits
  3. 06 Feb, 2017 5 commits
  4. 19 Jan, 2017 1 commit
  5. 18 Jan, 2017 1 commit
  6. 10 Nov, 2016 1 commit
    • Thomas Haller's avatar
      build: allow using GCC C99 dialect instead of C89 · ba2b2de3
      Thomas Haller authored
      We already use several GCC extenions, like typeof() and
      __attribute__((cleanup)). They are too convinient to miss
      and every supported compiler must support these.
      Currently, gcc and clang does. Maybe other compilers would
      support that too, but who knows, nobody seems to test that.
      
      We also already use stdbool.h (C99) and the imported systemd
      code is mostly gnu99 too (it's not clear to me, because I don't
      find it precisely documented. Certainly it makes use of C99 features
      too).
      
      C99/gnu99 has some nice improvements that we no longer should miss
      out. For example "flexible array members" or "variable declaration
      in init-part of for loop".
      
      It doesn't mean we have to use every obscure (badly supported?)
      feature, it means we don't have to forgo features that are well
      supported. C99 is 17 years old, I mean, really...
      
      If somebody comes along and ports NM to non-gcc/clang, we can address
      bugs about unsupported language features as they surface.
      But let's not restrict us to some hypothetical compiler (or language
      specification).
      
      Also, NetworkManager is not ported on environment beside Linux.
      We don't have to be so considerate about the required build environment.
      Gcc is probably the most portable compiler out there. I doubt porting
      NetworkManager to *BSD fails due to missing gnu99 features. And if that
      causes issues, we should fix them after they happen in practice.
      ba2b2de3
  7. 14 Sep, 2016 1 commit
    • Thomas Haller's avatar
      build: move detection of NM_GIT_SHA to separate "m4/git-sha-record.m4" · b33aacbc
      Thomas Haller authored
      We want to embed the current commit-id in the ./configure script.
      That way the generated ./configure file in the source tarball
      references the commit-id from which the tarball was created.
      
      Then, in a second step, a script can check ./configure to find
      the parent commit. This is for example done by the 'makerepo.sh'
      script.
      
      This is generally useful, and also done by network-manager-applet
      and libnl3 projects. Move the function to a separate m4 macro
      to reuse it. It should also be re-used in NetworkManager's VPN plugins.
      b33aacbc
  8. 06 Jun, 2016 1 commit
  9. 03 Jun, 2016 3 commits
  10. 18 May, 2016 3 commits
  11. 09 Mar, 2016 1 commit
  12. 04 Mar, 2016 1 commit
  13. 10 Nov, 2015 1 commit
    • Thomas Haller's avatar
      build: hack around compiler warning in g-ir-scanner · f6272144
      Thomas Haller authored
      The autoconf macro for GIR passes $CFLAGS to g-ir-scanner.
      g-ir-scanner extends those flags with the system-default which
      includes -D_FORTIFY_SOURCE=2. Probably it should not do that,
      but if you disable optimization, this results in a compler warning
      in "/usr/include/features.h" [1]
      
          export CFLAGS='-O0'
          # Happens both with clang or gcc.
          #export CC=clang
          git clean -fdx
          ./autogen.sh
          make
      
      Work around that by injecting -Wno-error to $CFLAGS when invoking
      g-ir-scanner.
      
      [1] Related: https://sourceware.org/bugzilla/show_bug.cgi?id=13979
      f6272144
  14. 29 Sep, 2015 1 commit
    • Lubomir Rintel's avatar
      build: set -Werror when checking whether a -W<warning> option works · b38bc157
      Lubomir Rintel authored
      Otherwise the check is effectively a no-op and unknown options still get
      turned on. This results in unknown warnings when build without
      --with-extra-warnings=error:
      
        warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option]
      b38bc157
  15. 02 Jun, 2015 1 commit
    • Lubomir Rintel's avatar
      build: don't default to -Werror · 84021454
      Lubomir Rintel authored
      It seems like a poor default for various downstream toolchains. We can't
      anticipate the compiler warnings for future compiler versions and older
      ones are prone to false positives. Also, older gdbus-codegen is known
      to generate code that triggers compiler warnings.
      
      Let's keep it enabled for maintainer builds and distcheck so that we're
      sure a tool chain that builds releases without warnings exists.
      84021454
  16. 11 May, 2015 1 commit
  17. 19 Mar, 2015 3 commits
  18. 24 Feb, 2015 1 commit
  19. 26 Nov, 2014 1 commit
  20. 07 Nov, 2014 1 commit
    • Dan Williams's avatar
      dhcp: add systemd-based "internal" DHCP client · d2dd3b2c
      Dan Williams authored
      We must also remove -Waggregate-return from m4/compiler-warnings.m4 because systemd
      uses aggregate return (correctly) in a couple cases, and we cannot keep single-level
      makefiles and override aggregate-return only for the systemd sub-library.
      
      This client currently only supports DHCPv4 because the base systemd code
      does not yet fully support DHCPv6.
      d2dd3b2c
  21. 29 Oct, 2014 2 commits
  22. 14 Oct, 2014 1 commit
  23. 01 Aug, 2014 1 commit
    • Thomas Haller's avatar
      build/clang: fix detection of valid warning compiler flags · 5009f2c7
      Thomas Haller authored
      clang does not exit with error when it is called with an
      unrecognized (warning) option. Instead it just prints
      a warning that makes the configure script believe the
      warning is supported. Later, during build we might pass
      -Werror, which causes clang to fail due to unrecognized
      arguments.
      
      Fix the script to detect compiler warnings by passing
      '-Werror=unknown-warning-option', which lets clang fail too.
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      5009f2c7
  24. 27 Jun, 2014 1 commit
  25. 02 Apr, 2014 1 commit
  26. 09 May, 2013 1 commit
    • Dan Winship's avatar
      build: update gnome-code-coverage.m4 · 9008730f
      Dan Winship authored
      Update gnome-code-coverage.m4 from gnome-common to fix some (harmless)
      error messages when coverage is disabled (bug 699943), and to add
      support for lcov 1.10.
      9008730f
  27. 24 Apr, 2013 1 commit
  28. 24 Jan, 2013 1 commit