1. 15 Nov, 2017 1 commit
  2. 17 Oct, 2017 1 commit
    • Thomas Haller's avatar
      test: add gdbus leak to valgrind.suppressions · 1766bbea
      Thomas Haller authored
        ==28576== 78 (72 direct, 6 indirect) bytes in 1 blocks are definitely lost in loss record 843 of 1,311
        ==28576==    at 0x4C2EB6B: malloc (vg_replace_malloc.c:299)
        ==28576==    by 0x6FD0A38: g_malloc (gmem.c:94)
        ==28576==    by 0x6FE8575: g_slice_alloc (gslice.c:1025)
        ==28576==    by 0x6FE8A08: g_slice_alloc0 (gslice.c:1051)
        ==28576==    by 0x7010261: g_system_thread_new (gthread-posix.c:1152)
        ==28576==    by 0x6FF283E: g_thread_new_internal (gthread.c:874)
        ==28576==    by 0x6FF28E7: g_thread_new (gthread.c:827)
        ==28576==    by 0x6FCC4A3: g_get_worker_context (gmain.c:5851)
        ==28576==    by 0x681A814: g_task_thread_pool_init (gtask.c:1977)
        ==28576==    by 0x681A814: g_task_get_type (gtask.c:592)
        ==28576==    by 0x685CB50: ensure_required_types (gdbusprivate.c:231)
        ==28576==    by 0x685CB50: _g_dbus_initialize (gdbusprivate.c:1927)
        ==28576==    by 0x6850CA0: g_bus_get_sync (gdbusconnection.c:7267)
        ==28576==    by 0x10B6AC: nmtstc_service_init (nm-test-utils-impl.c:91)
        ==28576==    by 0x10D261: test_setup (test-secret-agent.c:249)
        ==28576==    by 0x6FF118B: test_case_run (gtestutils.c:2160)
        ==28576==    by 0x6FF118B: g_test_run_suite_internal (gtestutils.c:2244)
        ==28576==    by 0x6FF139A: g_test_run_suite_internal (gtestutils.c:2256)
        ==28576==    by 0x6FF139A: g_test_run_suite_internal (gtestutils.c:2256)
        ==28576==    by 0x6FF1571: g_test_run_suite (gtestutils.c:2332)
        ==28576==    by 0x6FF1590: g_test_run (gtestutils.c:1599)
        ==28576==    by 0x10D0EE: main (test-secret-agent.c:654)
      1766bbea
  3. 14 Nov, 2016 3 commits
  4. 03 Jun, 2016 1 commit
  5. 16 Nov, 2015 2 commits
  6. 11 Nov, 2015 1 commit
  7. 17 Jun, 2015 1 commit
    • Thomas Haller's avatar
      platform: fetch objects via the event socket · 051cf8bb
      Thomas Haller authored
      Use the event socket to request object via NLM_F_DUMP.
      
      No longer use 'priv->nlh' socket to fetch objects.
      Instead fetch them via the priv->nlh_event socket that also
      provides asynchronous events when objects change.
      
      That way, the events are in sync with our explicit requests
      and we can directly use the events. Previously, the events were
      only used to indicate that a refetch must happen, so that every
      event triggered a complete dump of all addresses/routes.
      
      We still use 'priv->nlh' to make synchronous requests such as
      adding/changing/deleting objects. That means, after we send a
      request, we must make sure that the result manifested itself
      at 'nlh_event' socket and the platform cache.
      That's why we sometimes still must force a dump to sync changes.
      That could be improved by using only one netlink socket so that
      we would wait for the ACK of our request.
      
      While not yet perfect, this already significantly reduces the number of
      fetches. Additionally, before, whenever requesting a dump of addresses
      or routes (which we did much more often, search for "get_kernel_object for type"
      log lines), we always dumped IPv4 and IPv6 together. Now only request
      the addr-family in question.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=747985
      https://bugzilla.redhat.com/show_bug.cgi?id=1211133
      051cf8bb
  8. 04 Jun, 2015 1 commit
  9. 03 Jun, 2015 1 commit
    • Thomas Haller's avatar
      valgrind: add valgrind suppression for Fedora 22 · d84ac1ba
      Thomas Haller authored
      Fixes for example valgrind tests for ./libnm/tests/test-nm-client:
      
          ==25772== Conditional jump or move depends on uninitialised value(s)
          ==25772==    at 0x40198D8: index (strchr.S:106)
          ==25772==    by 0x400777C: expand_dynamic_string_token (dl-load.c:369)
          ==25772==    by 0x400777C: fillin_rpath (dl-load.c:439)
          ==25772==    by 0x4007FCF: _dl_init_paths (dl-load.c:816)
          ==25772==    by 0x4002F38: dl_main (rtld.c:1194)
          ==25772==    by 0x401750F: _dl_sysdep_start (dl-sysdep.c:249)
          ==25772==    by 0x4004C20: _dl_start_final (rtld.c:306)
          ==25772==    by 0x4004C20: _dl_start (rtld.c:412)
          ==25772==    by 0x4000C97: ??? (in /usr/lib64/ld-2.21.so)
          ==25772==    by 0x1: ???
          ==25772==    by 0xFFEFFF6B2: ???
          ==25772==    by 0xFFEFFF6EF: ???
          ==25772==
          {
             <insert_a_suppression_name_here>
             Memcheck:Cond
             fun:index
             fun:expand_dynamic_string_token
             fun:fillin_rpath
             fun:_dl_init_paths
             fun:dl_main
             fun:_dl_sysdep_start
             fun:_dl_start_final
             fun:_dl_start
             obj:/usr/lib64/ld-2.21.so
             obj:*
             obj:*
             obj:*
          }
      d84ac1ba
  10. 13 May, 2015 4 commits
  11. 04 May, 2015 1 commit
  12. 17 Apr, 2015 2 commits
  13. 16 Mar, 2015 1 commit
  14. 12 Mar, 2015 2 commits
  15. 09 Feb, 2015 3 commits
    • Thomas Haller's avatar
      libnm/tests: add valgrind suppressions · bf68917c
      Thomas Haller authored
      bf68917c
    • Thomas Haller's avatar
      d5f83129
    • Thomas Haller's avatar
      tests: add valgrind suppression for test-general-with-expect · 171a9eab
      Thomas Haller authored
          ==8781== Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s)
          ==8781==    at 0x5E547DD: __libc_sigaction (sigaction.c:64)
          ==8781==    by 0x8149025: unref_unix_signal_handler_unlocked (gmain.c:4981)
          ==8781==    by 0x81490BF: g_child_watch_finalize (gmain.c:5025)
          ==8781==    by 0x8149535: g_source_unref_internal (gmain.c:1997)
          ==8781==    by 0x814C377: g_main_context_dispatch (gmain.c:3094)
          ==8781==    by 0x814C627: g_main_context_iterate.isra.24 (gmain.c:3713)
          ==8781==    by 0x814CA39: g_main_loop_run (gmain.c:3907)
          ==8781==    by 0x11AC8B: test_nm_utils_kill_child_async_do (test-general-with-expect.c:90)
          ==8781==    by 0x119769: test_nm_utils_kill_child (test-general-with-expect.c:292)
          ==8781==    by 0x81705E0: g_test_run_suite_internal (gtestutils.c:2067)
          ==8781==    by 0x81707A5: g_test_run_suite_internal (gtestutils.c:2138)
          ==8781==    by 0x8170B1A: g_test_run_suite (gtestutils.c:2189)
          ==8781==  Address 0xffeffed28 is on thread 1's stack
          ==8781==
          {
             <insert_a_suppression_name_here>
             Memcheck:Param
             rt_sigaction(act->sa_flags)
             fun:__libc_sigaction
             fun:unref_unix_signal_handler_unlocked
             fun:g_child_watch_finalize
             fun:g_source_unref_internal
             fun:g_main_context_dispatch
             fun:g_main_context_iterate.isra.24
             fun:g_main_loop_run
             fun:test_nm_utils_kill_child_async_do
             fun:test_nm_utils_kill_child
             fun:g_test_run_suite_internal
             fun:g_test_run_suite_internal
             fun:g_test_run_suite
          }
      171a9eab
  16. 18 Feb, 2014 1 commit
  17. 08 Jan, 2014 1 commit
  18. 11 Dec, 2013 1 commit
  19. 06 May, 2013 1 commit
    • Dan Williams's avatar
      valgrind: suppressions update · cefdb51f
      Dan Williams authored
      This suppression didn't work on F17 for some reason, even though the
      stacktrace was the same.  Valgrind wanted some kind of:
      
      obj:<path to libglib>
      
      between the calloc and the g_malloc0 lines; but we don't actually
      care much about the calloc anyway.
      cefdb51f
  20. 10 Apr, 2013 1 commit
    • Pavel Šimerda's avatar
      platform: link management · 15fd7cd7
      Pavel Šimerda authored
      Create the new nm-platform framework and implement link (or interface)
      management. The nm-platform serves as the point of contact between
      the rest of NetworkManager and the operating system.
      
      There are two backends for nm-platform:
      
      * NMFakePlatform: Fake kernel backend for testing purposes
      * NMLinuxPlatform: Linux kernel backend for actual use
      
      A comprehensive testsuite is included and will be extended with new
      feature additions. To enable the Linux part of the testsuite, use
      --enable-tests=root configure options and run 'make check' as root.
      Use --enable-code-coverage for code coverage support.
      
        ./autogen.sh --enable-tests=root --enable-code-coverage
        make
        make -C src/platform check-code-coverage
      
      Link features:
      
      * Retrieve the list of links
      * Translate between indexes and names
      * Discover device type
      * Add/remove dummy interfaces (for testing)
      
      Thanks to Thomas Graf for helping with libnl3 synchronization issues.
      15fd7cd7
  21. 01 Apr, 2013 1 commit
  22. 22 Mar, 2013 1 commit
  23. 16 Feb, 2011 1 commit