1. 25 Jul, 2018 4 commits
  2. 24 Jul, 2018 11 commits
  3. 13 Jul, 2018 2 commits
    • Lubomir Rintel's avatar
      setting-connection: fix ovs-port parent setting verification · 7e8425de
      Lubomir Rintel authored
        $ nmcli c add type ovs-port ifname ovsport0
        Error: Failed to add 'ovs-port-ovsport0' connection: connection.type:
            Only 'ovs-port' connections can be enslaved to 'ovs-bridge'
      
      nm_streq0() is not good here. It fails (with a wrong error message) even
      when the slave_type is not set, which it shouldn't since slave_type can
      be normalized. The real problem is the lack of the master property.
      
      This fixes the condition:
      
        $ nmcli c add type ovs-port ifname ovsport0
        Error: Failed to add 'ovs-port-ovsport0' connection: connection.master:
          A connection with a 'ovs-port' setting must have a master.
      
      Corrects the error message:
      
        $ nmcli c add con-name br0 type bridge
        $ nmcli c add type ovs-port ifname ovsport0 parent br0
        Error: Failed to add 'bridge-slave-ovsport0' connection: connection.slave-type:
          'ovs-port' connections must be enslaved to 'ovs-bridge', not 'bridge'
      
      And gets rid of a confusing nm_streq0 use when comparing the type, since
      at that point type must not be NULL anymore.
      
      Fixes: 4199c976
      (cherry picked from commit 354140e8)
      7e8425de
    • Jan Alexander Steffens's avatar
      wifi/ifd: Allow D-Bus activation to launch iwd · 461f5112
      Jan Alexander Steffens authored
      iwd does not ship activation configuration yet; until then we simply
      fail the way we already do.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=796805
      (cherry picked from commit 21f955b4)
      461f5112
  4. 11 Jul, 2018 2 commits
    • Beniamino Galvani's avatar
      device: destroy pending acd-managers when the device disconnects · 87cd30c7
      Beniamino Galvani authored
      We previously kept any acd-manager running if the device was
      disconnected. It was possible to trigger a crash by setting a long
      dad-timeout and interrupting the activation request:
      
        nmcli con add type ethernet ifname eth0 con-name eth0+ ip4 1.2.3.4/32
        nmcli con mod eth0+ ipv4.dad-timeout 10000
        nmcli -w 2 con up eth0+
        nmcli con down eth0+
      
      After this, the n-acd timer would fire after 10 seconds and try to
      disconnect an already disconnected device, throwing the assertion:
      
        NetworkManager:ERROR:src/devices/nm-device.c:9845:
        activate_stage5_ip4_config_result: assertion failed: (req)
      
      Fixes: 28f6e8b4
      (cherry picked from commit 260cded3)
      87cd30c7
    • Thomas Haller's avatar
      connectivity: downgrade verbosity of error logging · d2b4a6c3
      Thomas Haller authored
      Such failures during connectivity checks, may happen frequently
      and due to external causes. Don't log with error level to avoid
      spamming the logfile.
      
      (cherry picked from commit ca9981eb)
      d2b4a6c3
  5. 09 Jul, 2018 4 commits
  6. 05 Jul, 2018 1 commit
  7. 04 Jul, 2018 1 commit
  8. 01 Jul, 2018 1 commit
  9. 30 Jun, 2018 1 commit
  10. 29 Jun, 2018 13 commits