Commit 7696e6c1 authored by Beniamino Galvani's avatar Beniamino Galvani

manager: fix failed assertion on user activations

We can't use g_steal_pointer(&active) in the argument list if another
argument uses @active because the order of evaluation is not defined.

This fixes the following bug:

 src/nm-manager.c:511:_async_op_complete_ac_auth_cb: assertion failed: (active == async_op_data->ac_auth.active)

Fixes: f4fc62ba

https://bugzilla.redhat.com/show_bug.cgi?id=1585494
parent 3fb4eed3
......@@ -4747,12 +4747,16 @@ impl_manager_activate_connection (NMDBusObject *obj,
if (!active)
goto error;
nm_active_connection_authorize (g_steal_pointer (&active),
nm_active_connection_authorize (active,
NULL,
_async_op_complete_ac_auth_cb,
_async_op_data_new_ac_auth_activate_user (self,
active,
invocation));
/* we passed the pointer on to _async_op_data_new_ac_auth_activate_user() */
g_steal_pointer (&active);
return;
error:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment