Commit 617bf418 authored by Thomas Haller's avatar Thomas Haller

checkpoint/trivial: add fixme comments

parent 735dc41b
......@@ -141,6 +141,8 @@ nm_checkpoint_manager_create (NMCheckpointManager *self,
const CList *tmp_lst;
nm_manager_for_each_device (manager, device, tmp_lst) {
/* FIXME: there is no strong reason to skip over unrealized devices.
* Also, NMCheckpoint anticipates to handle them (in parts). */
if (!nm_device_is_real (device))
continue;
nm_assert (nm_dbus_object_get_path (NM_DBUS_OBJECT (device)));
......
......@@ -593,6 +593,10 @@ nm_checkpoint_new (NMManager *manager, GPtrArray *devices, guint32 rollback_time
for (i = 0; i < devices->len; i++) {
NMDevice *device = devices->pdata[i];
/* FIXME: as long as the check point instance exists, it won't let go
* of the device. That is a bug, for example, if you have a ethernet
* device that gets removed (rmmod), the checkpoint will reference
* a non-existing D-Bus path of a device. */
g_hash_table_insert (priv->devices,
device,
device_checkpoint_create (device));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment