Commit 2666aa0b authored by Beniamino Galvani's avatar Beniamino Galvani

cli: don't wait for connection change on update failure

When saving a connection, we wait the connection-changed signal before
proceeding to ensure that the remote connection is up to date.
However, no signal is emitted if the update fails and so we shouldn't
wait for it.

Fixes: a370faeb ('cli: wait for changed signal after updating a connection'):

!124
https://bugzilla.redhat.com/show_bug.cgi?id=1702203
(cherry picked from commit 2d347e7e)
(cherry picked from commit 3423629f)
parent 61b4f31d
Pipeline #42719 passed with stage
in 30 minutes and 39 seconds
......@@ -7861,8 +7861,10 @@ editor_menu_main (NmCli *nmc, NMConnection *connection, const char *connection_t
while (!nmc_editor_cb_called && !timeout)
g_main_context_iteration (NULL, TRUE);
while (!connection_changed && !timeout)
g_main_context_iteration (NULL, TRUE);
if (!nmc_editor_error) {
while (!connection_changed && !timeout)
g_main_context_iteration (NULL, TRUE);
}
if (handler_id)
g_signal_handler_disconnect (rem_con, handler_id);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment