Skip to content
  • Dan Winship's avatar
    core: drop all remaining core-internal error domains · da8d79f1
    Dan Winship authored
    A number of classes in core had their own error domains that aren't
    really necessary.
    
    In the case of NMDcbError, NMDhcpManagerError, NMDnsManagerError,
    NMDnsmasqManagerError, NMPppManagerError, and NMSessionMonitorError,
    most of the codes they defined weren't even being used, and at any
    rate, the errors were always returned into contexts where they would
    just have their message extracted and then get thrown away without
    anyone ever looking at the domain or code. So all uses of those
    domains can just be replaced with NM_MANAGER_ERROR_FAILED without any
    loss of information.
    
    NMAuthManagerError only had 1 error code, and it just indicated
    "something went wrong", so it can be replaced with
    NM_MANAGER_ERROR_FAILED without loss of information.
    (nm-auth-manager.c has also been fixed to return
    NM_MANAGER_ERROR_FAILED when the CheckAuthorization D-Bus call fails,
    rather than returning whatever error domain/code the D-Bus call
    returned.)
    
    NMVpnManagerError used 2 of its 4 error codes, and they could actually
    end up getting returned across D-Bus in some cases. But there are
    NMManagerError codes that are semantically similar enough to make the
    NMVpnManagerError ones unnecessary.
    da8d79f1