Skip to content
  • Thomas Haller's avatar
    build: pass -std=gnu99 to compiler · b9bc20f4
    Thomas Haller authored
    With --enable-more-warnings, we already used -std=gnu99, see
    commit ba2b2de3.
    
    Compilation may behave differently depending on the selected
    C standard that we choose. It seems wrong, with more-warnings,
    to build against a C standard, while otherwise leaving it undefind.
    
    Indeed, one might argue, that our build system should not use
    such compiler specific options. At least, not without detecting
    support for the compiler option during ./configure.
    
    However:
    
    - we already did this for --enable-more-warnings.
    
    - we should not program against a theoretical compiler. In practice,
      only gcc and clang works to build NetworkManager. Both these compilers
      support this option, so there is no reason to not use it. If we ever
      come into the situation to support another compiler, adjusting -std=gnu99
      will be the smallest problem. Until that happens (and that's far from
      imminent), don't pretend to be portable to non-existing compilers and
      use the flag that in practice is available.
    
    See-also: https://gcc.gnu.org/onlinedocs/gcc/Standards.html
    b9bc20f4