• Dan Winship's avatar
    libnm*: fix library gettext usage · 53f5e9af
    Dan Winship authored
    Libraries need to include <gi18n-lib.h>, not <gi18n.h>, so that _()
    will get defined to "dgettext (GETTEXT_DOMAIN, string)" rather than
    "gettext (string)" (which will use the program's default domain, which
    works fine for programs in the NetworkManager tree, but not for
    external users). Likewise, we need to call bindtextdomain() so that
    gettext can find the translations if the library is installed in a
    different prefix from the program using it (and
    bind_textdomain_codeset(), so it will know the translations are in
    UTF-8 even if the locale isn't).
    (The fact that no one noticed this was broken before is because the
    libraries didn't really start returning useful translated strings much
    until 0.9.10, and none of the out-of-tree clients have been updated to
    actually show those strings to users yet.)
nm-remote-connection.c 30.1 KB