• Thomas Haller's avatar
    all: cleanup includes and let "nm-default.h" include "config.h" · 8bace23b
    Thomas Haller authored
    - All internal source files (except "examples", which are not internal)
      should include "config.h" first. As also all internal source
      files should include "nm-default.h", let "config.h" be included
      by "nm-default.h" and include "nm-default.h" as first in every
      source file.
      We already wanted to include "nm-default.h" before other headers
      because it might contains some fixes (like "nm-glib.h" compatibility)
      that is required first.
    
    - After including "nm-default.h", we optinally allow for including the
      corresponding header file for the source file at hand. The idea
      is to ensure that each header file is self contained.
    
    - Don't include "config.h" or "nm-default.h" in any header file
      (except "nm-sd-adapt.h"). Public headers anyway must not include
      these headers, and internal headers are never included after
      "nm-default.h", as of the first previous point.
    
    - Include all internal headers with quotes instead of angle brackets.
      In practice it doesn't matter, because in our public headers we must
      include other headers with angle brackets. As we use our public
      headers also to compile our interal source files, effectively the
      result must be the same. Still do it for consistency.
    
    - Except for <config.h> itself. Include it with angle brackets as suggested by
      https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
    8bace23b
nm-setting-olpc-mesh.c 8.32 KB