Skip to content
  • Thomas Haller's avatar
    tests: use NMTST_EXPECT*() macros · 25ade397
    Thomas Haller authored
    Tests are commonly created via copy&paste. Hence, it's
    better to express a certain concept explicitly via a function
    or macro. This way, the implementation of the concept can be
    adjusted at one place, without requiring to change all the callers.
    
    Also, the macro is shorter, and brevity is better for tests
    so it's easier to understand what the test does. Without being
    bothered by noise from the redundant information.
    
    Also, the macro knows better which message to expect. For example,
    messages inside "src" are prepended by nm-logging.c with a level
    and a timestamp. The expect macro is aware of that and tests for it
    
      #define NMTST_EXPECT_NM_ERROR(msg)      NMTST_EXPECT_NM (G_LOG_LEVEL_MESSAGE, "*<error> [*] "msg)
    
    This again allows the caller to ignore this prefix, but still assert
    more strictly.
    25ade397