Skip to content
  • Thomas Haller's avatar
    device: refactor setting parent in device's update_connection() · 72de0afa
    Thomas Haller authored
    Add a helper function nm_device_parent_find_for_connection() to
    unify implementations of setting the parent in update_connection().
    
    There is some change in behavior, in particular for nm-device-vlan.c,
    which no longer compares the link information from platform. But
    update_connection() is anyway a questionable concept, only used
    for external assumed connection (which itself, is questionable). Meaning,
    update_connection() is a hack not science, and it's not at all clear
    what the correct behavior is.
    
    Also, note how vlan's implementation differs from all others. Why?
    Should we always resort to also check the information from platform?
    Either way, one of the two approaches should be used consistently and
    nm_device_parent_find_for_connection() opts to not consult platform
    cache.
    72de0afa