nm-lldp-listener.c 32.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
/* NetworkManager -- Network link manager
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Copyright (C) 2015 Red Hat, Inc.
 */

21
#include "nm-default.h"
22

23 24
#include "nm-lldp-listener.h"

25 26
#include <net/ethernet.h>

27
#include "platform/nm-platform.h"
28
#include "nm-utils/unaligned.h"
29
#include "nm-utils/nm-c-list.h"
30 31
#include "nm-utils.h"

32
#include "systemd/nm-sd.h"
33

34
#define MAX_NEIGHBORS         4096
35
#define MIN_UPDATE_INTERVAL_NS (2 * NM_UTILS_NS_PER_SECOND)
36

37 38 39 40
#define LLDP_MAC_NEAREST_BRIDGE          ((const struct ether_addr *) ((uint8_t[ETH_ALEN]) { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x0e }))
#define LLDP_MAC_NEAREST_NON_TPMR_BRIDGE ((const struct ether_addr *) ((uint8_t[ETH_ALEN]) { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x03 }))
#define LLDP_MAC_NEAREST_CUSTOMER_BRIDGE ((const struct ether_addr *) ((uint8_t[ETH_ALEN]) { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 }))

41 42 43 44
typedef enum {
	LLDP_ATTR_TYPE_NONE,
	LLDP_ATTR_TYPE_UINT32,
	LLDP_ATTR_TYPE_STRING,
45
	LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS,
46 47 48 49 50 51 52 53 54
} LldpAttrType;

typedef enum {
	/* the order of the enum values determines the order of the fields in
	 * the variant. */
	LLDP_ATTR_ID_PORT_DESCRIPTION,
	LLDP_ATTR_ID_SYSTEM_NAME,
	LLDP_ATTR_ID_SYSTEM_DESCRIPTION,
	LLDP_ATTR_ID_SYSTEM_CAPABILITIES,
55
	LLDP_ATTR_ID_MANAGEMENT_ADDRESSES,
56 57 58
	LLDP_ATTR_ID_IEEE_802_1_PVID,
	LLDP_ATTR_ID_IEEE_802_1_PPVID,
	LLDP_ATTR_ID_IEEE_802_1_PPVID_FLAGS,
59
	LLDP_ATTR_ID_IEEE_802_1_PPVIDS,
60 61
	LLDP_ATTR_ID_IEEE_802_1_VID,
	LLDP_ATTR_ID_IEEE_802_1_VLAN_NAME,
62
	LLDP_ATTR_ID_IEEE_802_1_VLANS,
Beniamino Galvani's avatar
Beniamino Galvani committed
63
	_LLDP_ATTR_ID_COUNT,
64 65 66 67 68 69 70
} LldpAttrId;

typedef struct {
	LldpAttrType attr_type;
	union {
		guint32 v_uint32;
		char *v_string;
71
		CList v_variant_list;
72 73 74
	};
} LldpAttrData;

75 76 77 78 79 80
/*****************************************************************************/

NM_GOBJECT_PROPERTIES_DEFINE (NMLldpListener,
	PROP_NEIGHBORS,
);

81 82 83 84 85
typedef struct {
	char         *iface;
	int           ifindex;
	sd_lldp      *lldp_handle;
	GHashTable   *lldp_neighbors;
86 87 88 89 90

	/* the timestamp in nsec until which we delay updates. */
	gint64        ratelimit_next;
	guint         ratelimit_id;

91 92 93
	GVariant     *variant;
} NMLldpListenerPrivate;

94 95 96 97 98 99 100 101
struct _NMLldpListener {
	GObject parent;
	NMLldpListenerPrivate _priv;
};

struct _NMLldpListenerClass {
	GObjectClass parent;
};
102 103 104

G_DEFINE_TYPE (NMLldpListener, nm_lldp_listener, G_TYPE_OBJECT)

105 106 107
#define NM_LLDP_LISTENER_GET_PRIVATE(self) _NM_GET_PRIVATE (self, NMLldpListener, NM_IS_LLDP_LISTENER)

/*****************************************************************************/
108 109 110 111 112 113 114

typedef struct {
	guint8 chassis_id_type;
	guint8 port_id_type;
	char *chassis_id;
	char *port_id;

115
	struct ether_addr destination_address;
116

117 118
	bool valid:1;

Beniamino Galvani's avatar
Beniamino Galvani committed
119
	LldpAttrData attrs[_LLDP_ATTR_ID_COUNT];
120 121

	GVariant *variant;
122
} LldpNeighbor;
123

124 125 126 127 128 129 130 131 132 133 134 135
/*****************************************************************************/

#define _NMLOG_PREFIX_NAME                "lldp"
#define _NMLOG_DOMAIN                     LOGD_DEVICE
#define _NMLOG(level, ...) \
    G_STMT_START { \
        const NMLogLevel _level = (level); \
        \
        if (nm_logging_enabled (_level, _NMLOG_DOMAIN)) { \
            char _sbuf[64]; \
            int _ifindex = (self) ? NM_LLDP_LISTENER_GET_PRIVATE (self)->ifindex : 0; \
            \
136
            _nm_log (_level, _NMLOG_DOMAIN, 0, \
137
                     _ifindex > 0 ? nm_platform_link_get_name (NM_PLATFORM_GET, _ifindex) : NULL, \
138
                     NULL, \
139 140 141 142 143 144 145 146 147 148 149
                     "%s%s: " _NM_UTILS_MACRO_FIRST (__VA_ARGS__), \
                     _NMLOG_PREFIX_NAME, \
                     ((_ifindex > 0) \
                        ? nm_sprintf_buf (_sbuf, "[%p,%d]", (self), _ifindex) \
                        : ((self) \
                            ? nm_sprintf_buf (_sbuf, "[%p]", (self)) \
                            : "")) \
                     _NM_UTILS_MACRO_REST (__VA_ARGS__)); \
        } \
    } G_STMT_END \

Thomas Haller's avatar
Thomas Haller committed
150 151 152
#define LOG_NEIGH_FMT        "CHASSIS=%s%s%s PORT=%s%s%s"
#define LOG_NEIGH_ARG(neigh) NM_PRINT_FMT_QUOTE_STRING ((neigh)->chassis_id), NM_PRINT_FMT_QUOTE_STRING ((neigh)->port_id)

153 154
/*****************************************************************************/

155 156 157 158 159 160 161 162 163 164
static gboolean
ether_addr_equal (const struct ether_addr *a1, const struct ether_addr *a2)
{
	nm_assert (a1);
	nm_assert (a2);

	G_STATIC_ASSERT_EXPR (sizeof (*a1) == ETH_ALEN);
	return memcmp (a1, a2, ETH_ALEN) == 0;
}

165 166 167 168
/*****************************************************************************/

NM_UTILS_LOOKUP_STR_DEFINE_STATIC (_lldp_attr_id_to_name, LldpAttrId,
	NM_UTILS_LOOKUP_DEFAULT_WARN (NULL),
169 170 171 172 173 174 175 176 177 178 179 180
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_PORT_DESCRIPTION,         NM_LLDP_ATTR_PORT_DESCRIPTION),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_SYSTEM_NAME,              NM_LLDP_ATTR_SYSTEM_NAME),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_SYSTEM_DESCRIPTION,       NM_LLDP_ATTR_SYSTEM_DESCRIPTION),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_SYSTEM_CAPABILITIES,      NM_LLDP_ATTR_SYSTEM_CAPABILITIES),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_MANAGEMENT_ADDRESSES,     NM_LLDP_ATTR_MANAGEMENT_ADDRESSES),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_PVID,          NM_LLDP_ATTR_IEEE_802_1_PVID),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_PPVID,         NM_LLDP_ATTR_IEEE_802_1_PPVID),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_PPVID_FLAGS,   NM_LLDP_ATTR_IEEE_802_1_PPVID_FLAGS),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_PPVIDS,        NM_LLDP_ATTR_IEEE_802_1_PPVIDS),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_VID,           NM_LLDP_ATTR_IEEE_802_1_VID),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_VLAN_NAME,     NM_LLDP_ATTR_IEEE_802_1_VLAN_NAME),
	NM_UTILS_LOOKUP_STR_ITEM (LLDP_ATTR_ID_IEEE_802_1_VLANS,         NM_LLDP_ATTR_IEEE_802_1_VLANS),
Beniamino Galvani's avatar
Beniamino Galvani committed
181
	NM_UTILS_LOOKUP_ITEM_IGNORE (_LLDP_ATTR_ID_COUNT),
182 183 184 185 186 187 188 189
);

_NM_UTILS_LOOKUP_DEFINE (static, _lldp_attr_id_to_type, LldpAttrId, LldpAttrType,
	NM_UTILS_LOOKUP_DEFAULT_WARN (LLDP_ATTR_TYPE_NONE),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_PORT_DESCRIPTION,            LLDP_ATTR_TYPE_STRING),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_SYSTEM_NAME,                 LLDP_ATTR_TYPE_STRING),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_SYSTEM_DESCRIPTION,          LLDP_ATTR_TYPE_STRING),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_SYSTEM_CAPABILITIES,         LLDP_ATTR_TYPE_UINT32),
190
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_MANAGEMENT_ADDRESSES,        LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS),
191 192 193
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_PVID,             LLDP_ATTR_TYPE_UINT32),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_PPVID,            LLDP_ATTR_TYPE_UINT32),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_PPVID_FLAGS,      LLDP_ATTR_TYPE_UINT32),
194
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_PPVIDS,           LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS),
195 196
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_VID,              LLDP_ATTR_TYPE_UINT32),
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_VLAN_NAME,        LLDP_ATTR_TYPE_STRING),
197
	NM_UTILS_LOOKUP_ITEM (LLDP_ATTR_ID_IEEE_802_1_VLANS,            LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS),
Beniamino Galvani's avatar
Beniamino Galvani committed
198
	NM_UTILS_LOOKUP_ITEM_IGNORE (_LLDP_ATTR_ID_COUNT),
199 200 201 202
);

static void
_lldp_attr_set_str (LldpAttrData *pdata, LldpAttrId attr_id, const char *v_string)
203
{
204 205 206 207
	nm_assert (pdata);
	nm_assert (_lldp_attr_id_to_type (attr_id) == LLDP_ATTR_TYPE_STRING);

	pdata = &pdata[attr_id];
208

209 210 211 212 213
	/* we ignore duplicate fields silently. */
	if (pdata->attr_type != LLDP_ATTR_TYPE_NONE)
		return;
	pdata->attr_type = LLDP_ATTR_TYPE_STRING;
	pdata->v_string = g_strdup (v_string ?: "");
214 215
}

216
static void
217
_lldp_attr_take_str_ptr (LldpAttrData *pdata, LldpAttrId attr_id, char *str)
218
{
219 220 221 222 223 224 225 226 227 228
	nm_assert (pdata);
	nm_assert (_lldp_attr_id_to_type (attr_id) == LLDP_ATTR_TYPE_STRING);

	pdata = &pdata[attr_id];

	/* we ignore duplicate fields silently. */
	if (pdata->attr_type != LLDP_ATTR_TYPE_NONE)
		return;

	pdata->attr_type = LLDP_ATTR_TYPE_STRING;
229
	pdata->v_string = str;
230 231
}

232 233
static void
_lldp_attr_set_uint32 (LldpAttrData *pdata, LldpAttrId attr_id, guint32 v_uint32)
234
{
235 236
	nm_assert (pdata);
	nm_assert (_lldp_attr_id_to_type (attr_id) == LLDP_ATTR_TYPE_UINT32);
237

238
	pdata = &pdata[attr_id];
239

240 241 242 243 244
	/* we ignore duplicate fields silently. */
	if (pdata->attr_type != LLDP_ATTR_TYPE_NONE)
		return;
	pdata->attr_type = LLDP_ATTR_TYPE_UINT32;
	pdata->v_uint32 = v_uint32;
245 246
}

247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264
static void
_lldp_attr_add_vardict (LldpAttrData *pdata, LldpAttrId attr_id, GVariant *variant)
{
	nm_assert (pdata);
	nm_assert (_lldp_attr_id_to_type (attr_id) == LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS);

	g_variant_ref_sink (variant);
	pdata = &pdata[attr_id];

	if (pdata->attr_type == LLDP_ATTR_TYPE_NONE) {
		c_list_init (&pdata->v_variant_list);
		pdata->attr_type = LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS;
	} else
		nm_assert (pdata->attr_type == LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS);

	c_list_link_tail (&pdata->v_variant_list, &nm_c_list_elem_new_stale (variant)->lst);
}

265 266
/*****************************************************************************/

267 268 269
static guint
lldp_neighbor_id_hash (gconstpointer ptr)
{
270
	const LldpNeighbor *neigh = ptr;
271 272 273
	NMHashState h;

	nm_hash_init (&h, 23423423u);
274 275
	nm_hash_update_str0 (&h, neigh->chassis_id);
	nm_hash_update_str0 (&h, neigh->port_id);
276 277 278
	nm_hash_update_vals (&h,
	                     neigh->chassis_id_type,
	                     neigh->port_id_type);
279
	return nm_hash_complete (&h);
280 281
}

282
static int
283
lldp_neighbor_id_cmp (const LldpNeighbor *x, const LldpNeighbor *y)
284
{
285 286 287 288 289 290 291 292 293 294 295 296 297
	NM_CMP_SELF (x, y);
	NM_CMP_FIELD (x, y, chassis_id_type);
	NM_CMP_FIELD (x, y, port_id_type);
	NM_CMP_FIELD_STR0 (x, y, chassis_id);
	NM_CMP_FIELD_STR0 (x, y, port_id);
	return 0;
}

static int
lldp_neighbor_id_cmp_p (gconstpointer a, gconstpointer b, gpointer user_data)
{
	return lldp_neighbor_id_cmp (*((const LldpNeighbor *const*) a),
	                             *((const LldpNeighbor *const*) b));
298
}
299

300 301 302 303
static gboolean
lldp_neighbor_id_equal (gconstpointer a, gconstpointer b)
{
	return lldp_neighbor_id_cmp (a, b) == 0;
304 305 306
}

static void
307
lldp_neighbor_free (LldpNeighbor *neighbor)
308
{
309
	LldpAttrId attr_id;
310
	LldpAttrType attr_type;
311

312 313 314
	if (neighbor) {
		g_free (neighbor->chassis_id);
		g_free (neighbor->port_id);
Beniamino Galvani's avatar
Beniamino Galvani committed
315
		for (attr_id = 0; attr_id < _LLDP_ATTR_ID_COUNT; attr_id++) {
316 317 318 319
			attr_type = neighbor->attrs[attr_id].attr_type;

			switch (attr_type) {
			case LLDP_ATTR_TYPE_STRING:
320
				g_free (neighbor->attrs[attr_id].v_string);
321 322 323 324 325 326 327 328
				break;
			case LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS:
				nm_c_list_elem_free_all (&neighbor->attrs[attr_id].v_variant_list,
				                         (GDestroyNotify) g_variant_unref);
				break;
			default:
				;
			}
329
		}
330
		g_clear_pointer (&neighbor->variant, g_variant_unref);
331
		g_slice_free (LldpNeighbor, neighbor);
332 333 334
	}
}

335
static void
336
lldp_neighbor_freep (LldpNeighbor **ptr)
337 338 339 340
{
	lldp_neighbor_free (*ptr);
}

341
static gboolean
342
lldp_neighbor_equal (LldpNeighbor *a, LldpNeighbor *b)
343
{
344
	LldpAttrId attr_id;
345

346 347
	nm_assert (a);
	nm_assert (b);
348 349 350

	if (   a->chassis_id_type != b->chassis_id_type
	    || a->port_id_type != b->port_id_type
351
	    || ether_addr_equal (&a->destination_address, &b->destination_address)
352 353
	    || !nm_streq0 (a->chassis_id, b->chassis_id)
	    || !nm_streq0 (a->port_id, b->port_id))
354 355
		return FALSE;

Beniamino Galvani's avatar
Beniamino Galvani committed
356
	for (attr_id = 0; attr_id < _LLDP_ATTR_ID_COUNT; attr_id++) {
357
		if (a->attrs[attr_id].attr_type != b->attrs[attr_id].attr_type)
358
			return FALSE;
359 360 361
		switch (a->attrs[attr_id].attr_type) {
		case LLDP_ATTR_TYPE_UINT32:
			if (a->attrs[attr_id].v_uint32 != b->attrs[attr_id].v_uint32)
362
				return FALSE;
363 364 365
			break;
		case LLDP_ATTR_TYPE_STRING:
			if (!nm_streq (a->attrs[attr_id].v_string, b->attrs[attr_id].v_string))
366
				return FALSE;
367 368 369 370 371
			break;
		default:
			nm_assert (a->attrs[attr_id].attr_type == LLDP_ATTR_TYPE_NONE);
			break;
		}
372 373 374 375 376
	}

	return TRUE;
}

377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445
static GVariant *
parse_management_address_tlv (uint8_t *data, gsize len)
{
	GVariantDict dict;
	GVariant *variant;
	gsize addr_len, oid_len;

	/* 802.1AB-2009 - Figure 8-11
	 *
	 * - TLV type / length        (2 bytes)
	 * - address string length    (1 byte)
	 * - address subtype          (1 byte)
	 * - address                  (1 to 31 bytes)
	 * - interface number subtype (1 byte)
	 * - interface number         (4 bytes)
	 * - OID string length        (1 byte)
	 * - OID                      (0 to 128 bytes)
	 */

	if (len < 11)
		goto err;

	nm_assert ((data[0] >> 1) == SD_LLDP_TYPE_MGMT_ADDRESS);
	nm_assert ((((data[0] & 1) << 8) + data[1]) + 2 == len);

	data += 2;
	len -= 2;
	addr_len = *data; /* length of (address subtype + address) */

	if (addr_len < 2 || addr_len > 32)
		goto err;
	if (len < (  1         /* address stringth length */
	           + addr_len  /* address subtype + address */
	           + 5         /* interface */
	           + 1))       /* oid */
		goto err;

	g_variant_dict_init (&dict, NULL);

	data++;
	len--;
	g_variant_dict_insert (&dict, "address-subtype", "u", (guint32) *data);
	variant = g_variant_new_fixed_array (G_VARIANT_TYPE_BYTE, data + 1, addr_len - 1, 1);
	g_variant_dict_insert_value (&dict, "address", variant);

	data += addr_len;
	len -= addr_len;
	g_variant_dict_insert (&dict, "interface-number-subtype", "u", (guint32) *data);

	data++;
	len--;
	g_variant_dict_insert (&dict, "interface-number", "u", unaligned_read_be32 (data));

	data += 4;
	len -= 4;
	oid_len = *data;

	if (len < (1 + oid_len))
		goto err;

	data++;
	variant = g_variant_new_fixed_array (G_VARIANT_TYPE_BYTE, data, oid_len, 1);
	g_variant_dict_insert_value (&dict, "object-id", variant);
	return g_variant_dict_end (&dict);
err:
	g_variant_dict_clear (&dict);
	return NULL;
}

446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
static LldpNeighbor *
lldp_neighbor_new (sd_lldp_neighbor *neighbor_sd, GError **error)
{
	nm_auto (lldp_neighbor_freep) LldpNeighbor *neigh = NULL;
	uint8_t chassis_id_type, port_id_type;
	uint16_t data16;
	uint8_t *data8;
	const void *chassis_id, *port_id;
	gsize chassis_id_len, port_id_len, len;
	const char *str;
	int r;

	r = sd_lldp_neighbor_get_chassis_id (neighbor_sd, &chassis_id_type,
	                                     &chassis_id, &chassis_id_len);
	if (r < 0) {
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
462
		             "failed reading chassis-id: %s", nm_strerror_native (-r));
463 464 465 466 467 468 469 470 471 472 473 474
		return NULL;
	}
	if (chassis_id_len < 1) {
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
		             "empty chassis-id");
		return NULL;
	}

	r = sd_lldp_neighbor_get_port_id (neighbor_sd, &port_id_type,
	                                  &port_id, &port_id_len);
	if (r < 0) {
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
475
		             "failed reading port-id: %s", nm_strerror_native (-r));
476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
		return NULL;
	}
	if (port_id_len < 1) {
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
		             "empty port-id");
		return NULL;
	}

	neigh = g_slice_new0 (LldpNeighbor);
	neigh->chassis_id_type = chassis_id_type;
	neigh->port_id_type = port_id_type;

	r = sd_lldp_neighbor_get_destination_address (neighbor_sd, &neigh->destination_address);
	if (r < 0) {
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
491
		             "failed getting destination address: %s", nm_strerror_native (-r));
492
		goto out;
493 494 495
	}

	switch (chassis_id_type) {
496 497 498 499
	case SD_LLDP_CHASSIS_SUBTYPE_INTERFACE_ALIAS:
	case SD_LLDP_CHASSIS_SUBTYPE_INTERFACE_NAME:
	case SD_LLDP_CHASSIS_SUBTYPE_LOCALLY_ASSIGNED:
	case SD_LLDP_CHASSIS_SUBTYPE_CHASSIS_COMPONENT:
500 501
		neigh->chassis_id = g_strndup ((const char *) chassis_id, chassis_id_len);
		break;
502
	case SD_LLDP_CHASSIS_SUBTYPE_MAC_ADDRESS:
503 504 505 506 507
		neigh->chassis_id = nm_utils_hwaddr_ntoa (chassis_id, chassis_id_len);
		break;
	default:
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
		             "unsupported chassis-id type %d", chassis_id_type);
508
		goto out;
509 510 511
	}

	switch (port_id_type) {
512 513 514 515
	case SD_LLDP_PORT_SUBTYPE_INTERFACE_ALIAS:
	case SD_LLDP_PORT_SUBTYPE_INTERFACE_NAME:
	case SD_LLDP_PORT_SUBTYPE_LOCALLY_ASSIGNED:
	case SD_LLDP_PORT_SUBTYPE_PORT_COMPONENT:
516 517
		neigh->port_id = strndup ((char *) port_id, port_id_len);
		break;
518
	case SD_LLDP_PORT_SUBTYPE_MAC_ADDRESS:
519 520 521 522 523
		neigh->port_id = nm_utils_hwaddr_ntoa (port_id, port_id_len);
		break;
	default:
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
		             "unsupported port-id type %d", port_id_type);
524
		goto out;
525 526
	}

527 528
	if (sd_lldp_neighbor_get_port_description (neighbor_sd, &str) == 0)
		_lldp_attr_set_str (neigh->attrs, LLDP_ATTR_ID_PORT_DESCRIPTION, str);
529

530 531
	if (sd_lldp_neighbor_get_system_name (neighbor_sd, &str) == 0)
		_lldp_attr_set_str (neigh->attrs, LLDP_ATTR_ID_SYSTEM_NAME, str);
532

533 534
	if (sd_lldp_neighbor_get_system_description (neighbor_sd, &str) == 0)
		_lldp_attr_set_str (neigh->attrs, LLDP_ATTR_ID_SYSTEM_DESCRIPTION, str);
535

536 537
	if (sd_lldp_neighbor_get_system_capabilities (neighbor_sd, &data16) == 0)
		_lldp_attr_set_uint32 (neigh->attrs, LLDP_ATTR_ID_SYSTEM_CAPABILITIES, data16);
538 539 540 541

	r = sd_lldp_neighbor_tlv_rewind (neighbor_sd);
	if (r < 0) {
		g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
542
		             "failed reading tlv (rewind): %s", nm_strerror_native (-r));
543
		goto out;
544 545 546
	}
	do {
		guint8 oui[3];
547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
		guint8 type, subtype;
		GVariant *variant;

		if (sd_lldp_neighbor_tlv_get_type (neighbor_sd, &type) < 0)
			continue;

		if (sd_lldp_neighbor_tlv_get_raw (neighbor_sd, (void *) &data8, &len) < 0)
			continue;

		switch (type) {
		case SD_LLDP_TYPE_MGMT_ADDRESS:
			variant = parse_management_address_tlv (data8, len);
			if (variant) {
				_lldp_attr_add_vardict (neigh->attrs,
				                        LLDP_ATTR_ID_MANAGEMENT_ADDRESSES,
				                        variant);
			}
			continue;
		case SD_LLDP_TYPE_PRIVATE:
			break;
		default:
			continue;
		}
570 571 572 573 574 575

		r = sd_lldp_neighbor_tlv_get_oui (neighbor_sd, oui, &subtype);
		if (r < 0) {
			if (r == -ENXIO)
				continue;
			g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN,
576
			             "failed reading tlv: %s", nm_strerror_native (-r));
577
			goto out;
578 579
		}

580
		if (!(   memcmp (oui, SD_LLDP_OUI_802_1, sizeof (oui)) == 0
581
		      && NM_IN_SET (subtype,
582 583 584
		                    SD_LLDP_OUI_802_1_SUBTYPE_PORT_PROTOCOL_VLAN_ID,
		                    SD_LLDP_OUI_802_1_SUBTYPE_PORT_VLAN_ID,
		                    SD_LLDP_OUI_802_1_SUBTYPE_VLAN_NAME)))
585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605
			continue;


		/* skip over leading TLV, OUI and subtype */
#ifdef WITH_MORE_ASSERTS
		{
			guint8 check_hdr[] = {
				0xfe | (((len - 2) >> 8) & 0x01), ((len - 2) & 0xFF),
				oui[0], oui[1], oui[2],
				subtype
			};

			nm_assert (len > 2 + 3 +1);
			nm_assert (memcmp (data8, check_hdr, sizeof check_hdr) == 0);
		}
#endif
		if (len <= 6)
			continue;
		data8 += 6;
		len -= 6;

606
		/*if (memcmp (oui, SD_LLDP_OUI_802_1, sizeof (oui)) == 0)*/
607
		{
608 609
			GVariantDict dict;

610
			switch (subtype) {
611
			case SD_LLDP_OUI_802_1_SUBTYPE_PORT_VLAN_ID:
612 613
				if (len != 2)
					continue;
614
				_lldp_attr_set_uint32 (neigh->attrs, LLDP_ATTR_ID_IEEE_802_1_PVID,
615
				                       unaligned_read_be16 (data8));
616
				break;
617
			case SD_LLDP_OUI_802_1_SUBTYPE_PORT_PROTOCOL_VLAN_ID:
618 619
				if (len != 3)
					continue;
620
				_lldp_attr_set_uint32 (neigh->attrs, LLDP_ATTR_ID_IEEE_802_1_PPVID_FLAGS,
621
				                       data8[0]);
622
				_lldp_attr_set_uint32 (neigh->attrs, LLDP_ATTR_ID_IEEE_802_1_PPVID,
623
				                       unaligned_read_be16 (&data8[1]));
624 625 626 627 628 629 630 631

				g_variant_dict_init (&dict, NULL);
				g_variant_dict_insert (&dict, "ppvid", "u", (guint32) unaligned_read_be16 (&data8[1]));
				g_variant_dict_insert (&dict, "flags", "u", (guint32) data8[0]);

				_lldp_attr_add_vardict (neigh->attrs,
				                        LLDP_ATTR_ID_IEEE_802_1_PPVIDS,
				                        g_variant_dict_end (&dict));
632
				break;
633
			case SD_LLDP_OUI_802_1_SUBTYPE_VLAN_NAME: {
634
				int l;
635 636 637
				guint32 vid;
				const char *name;
				char *name_to_free;
638 639 640 641 642 643 644

				if (len <= 3)
					continue;

				l = data8[2];
				if (len != 3 + l)
					continue;
645 646
				if (l > 32)
					continue;
647

648 649 650 651 652 653 654 655 656 657 658 659 660 661 662
				name = nm_utils_buf_utf8safe_escape (&data8[3], l, 0, &name_to_free);
				vid = unaligned_read_be16 (&data8[0]);

				g_variant_dict_init (&dict, NULL);
				g_variant_dict_insert (&dict, "vid", "u", vid);
				g_variant_dict_insert (&dict, "name", "s", name);

				_lldp_attr_add_vardict (neigh->attrs,
				                        LLDP_ATTR_ID_IEEE_802_1_VLANS,
				                        g_variant_dict_end (&dict));

				_lldp_attr_set_uint32 (neigh->attrs, LLDP_ATTR_ID_IEEE_802_1_VID, vid);
				_lldp_attr_take_str_ptr (neigh->attrs,
				                         LLDP_ATTR_ID_IEEE_802_1_VLAN_NAME,
				                         name_to_free ?: g_strdup (name));
663 664 665 666 667 668 669 670
				break;
			}
			default:
				g_assert_not_reached ();
			}
		}
	} while (sd_lldp_neighbor_tlv_next (neighbor_sd) > 0);

671 672 673
	neigh->valid = TRUE;

out:
674
	return g_steal_pointer (&neigh);
675 676
}

677 678 679 680 681
static GVariant *
lldp_neighbor_to_variant (LldpNeighbor *neigh)
{
	GVariantBuilder builder;
	const char *dest_str;
682
	LldpAttrId attr_id;
683

684 685 686
	if (neigh->variant)
		return neigh->variant;

687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715
	g_variant_builder_init (&builder, G_VARIANT_TYPE ("a{sv}"));

	g_variant_builder_add (&builder, "{sv}",
	                       NM_LLDP_ATTR_CHASSIS_ID_TYPE,
	                       g_variant_new_uint32 (neigh->chassis_id_type));
	g_variant_builder_add (&builder, "{sv}",
	                       NM_LLDP_ATTR_CHASSIS_ID,
	                       g_variant_new_string (neigh->chassis_id));
	g_variant_builder_add (&builder, "{sv}",
	                       NM_LLDP_ATTR_PORT_ID_TYPE,
	                       g_variant_new_uint32 (neigh->port_id_type));
	g_variant_builder_add (&builder, "{sv}",
	                       NM_LLDP_ATTR_PORT_ID,
	                       g_variant_new_string (neigh->port_id));

	if (ether_addr_equal (&neigh->destination_address, LLDP_MAC_NEAREST_BRIDGE))
		dest_str = NM_LLDP_DEST_NEAREST_BRIDGE;
	else if (ether_addr_equal (&neigh->destination_address, LLDP_MAC_NEAREST_NON_TPMR_BRIDGE))
		dest_str = NM_LLDP_DEST_NEAREST_NON_TPMR_BRIDGE;
	else if (ether_addr_equal (&neigh->destination_address, LLDP_MAC_NEAREST_CUSTOMER_BRIDGE))
		dest_str = NM_LLDP_DEST_NEAREST_CUSTOMER_BRIDGE;
	else
		dest_str = NULL;
	if (dest_str) {
		g_variant_builder_add (&builder, "{sv}",
		                       NM_LLDP_ATTR_DESTINATION,
		                       g_variant_new_string (dest_str));
	}

Beniamino Galvani's avatar
Beniamino Galvani committed
716
	for (attr_id = 0; attr_id < _LLDP_ATTR_ID_COUNT; attr_id++) {
717
		const LldpAttrData *data = &neigh->attrs[attr_id];
718

719 720 721
		nm_assert (NM_IN_SET (data->attr_type, _lldp_attr_id_to_type (attr_id), LLDP_ATTR_TYPE_NONE));
		switch (data->attr_type) {
		case LLDP_ATTR_TYPE_UINT32:
722
			g_variant_builder_add (&builder, "{sv}",
723 724 725 726
			                       _lldp_attr_id_to_name (attr_id),
			                       g_variant_new_uint32 (data->v_uint32));
			break;
		case LLDP_ATTR_TYPE_STRING:
727
			g_variant_builder_add (&builder, "{sv}",
728 729 730
			                       _lldp_attr_id_to_name (attr_id),
			                       g_variant_new_string (data->v_string));
			break;
731 732 733 734 735 736 737 738 739 740 741 742 743 744
		case LLDP_ATTR_TYPE_ARRAY_OF_VARDICTS: {
			NMCListElem *elem;
			GVariantBuilder builder2;

			g_variant_builder_init (&builder2, G_VARIANT_TYPE ("aa{sv}"));

			c_list_for_each_entry (elem, &data->v_variant_list, lst)
				g_variant_builder_add_value (&builder2, elem->data);

			g_variant_builder_add (&builder, "{sv}",
			                       _lldp_attr_id_to_name (attr_id),
			                       g_variant_builder_end (&builder2));
			break;
		}
745 746
		default:
			break;
747 748 749
		}
	}

750
	return (neigh->variant = g_variant_ref_sink (g_variant_builder_end (&builder)));
751 752
}

753 754
/*****************************************************************************/

755 756 757 758 759 760 761
static void
data_changed_notify (NMLldpListener *self, NMLldpListenerPrivate *priv)
{
	nm_clear_g_variant (&priv->variant);
	_notify (self, PROP_NEIGHBORS);
}

762
static gboolean
763
data_changed_timeout (gpointer user_data)
764
{
765 766 767 768 769 770
	NMLldpListener *self = user_data;
	NMLldpListenerPrivate *priv;

	g_return_val_if_fail (NM_IS_LLDP_LISTENER (self), G_SOURCE_REMOVE);

	priv = NM_LLDP_LISTENER_GET_PRIVATE (self);
771

772 773 774 775 776
	priv->ratelimit_id = 0;
	priv->ratelimit_next = nm_utils_get_monotonic_timestamp_ns() + MIN_UPDATE_INTERVAL_NS;
	data_changed_notify (self, priv);
	return G_SOURCE_REMOVE;
}
777

778 779 780 781 782 783 784 785 786 787 788 789 790 791
static void
data_changed_schedule (NMLldpListener *self)
{
	NMLldpListenerPrivate *priv = NM_LLDP_LISTENER_GET_PRIVATE (self);
	gint64 now;

	now = nm_utils_get_monotonic_timestamp_ns ();
	if (now >= priv->ratelimit_next) {
		nm_clear_g_source (&priv->ratelimit_id);
		priv->ratelimit_next = now + MIN_UPDATE_INTERVAL_NS;
		data_changed_notify (self, priv);
	} else if (!priv->ratelimit_id)
		priv->ratelimit_id = g_timeout_add (NM_UTILS_NS_TO_MSEC_CEIL (priv->ratelimit_next - now), data_changed_timeout, self);
}
792

793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838
static void
process_lldp_neighbor (NMLldpListener *self, sd_lldp_neighbor *neighbor_sd, gboolean neighbor_valid)
{
	NMLldpListenerPrivate *priv;
	nm_auto (lldp_neighbor_freep) LldpNeighbor *neigh = NULL;
	LldpNeighbor *neigh_old;
	gs_free_error GError *parse_error = NULL;
	GError **p_parse_error;
	gboolean changed = FALSE;

	g_return_if_fail (NM_IS_LLDP_LISTENER (self));

	priv = NM_LLDP_LISTENER_GET_PRIVATE (self);

	g_return_if_fail (priv->lldp_handle);
	g_return_if_fail (neighbor_sd);

	p_parse_error = _LOGT_ENABLED () ? &parse_error : NULL;

	neigh = lldp_neighbor_new (neighbor_sd, p_parse_error);
	if (!neigh) {
		_LOGT ("process: failed to parse neighbor: %s", parse_error->message);
		return;
	}

	if (!neigh->valid)
		neighbor_valid = FALSE;

	neigh_old = g_hash_table_lookup (priv->lldp_neighbors, neigh);
	if (neigh_old) {
		if (!neighbor_valid) {
			_LOGT ("process: %s neigh: "LOG_NEIGH_FMT"%s%s%s",
			       "remove", LOG_NEIGH_ARG (neigh),
			       NM_PRINT_FMT_QUOTED (parse_error, " (failed to parse: ", parse_error->message, ")", ""));

			g_hash_table_remove (priv->lldp_neighbors, neigh_old);
			changed = TRUE;
			goto done;
		} else if (lldp_neighbor_equal (neigh_old, neigh))
			return;
	} else if (!neighbor_valid) {
		if (parse_error)
			_LOGT ("process: failed to parse neighbor: %s", parse_error->message);
		return;
	}

839
	/* ensure that we have at most MAX_NEIGHBORS entries */
840 841 842 843 844 845 846 847 848 849 850
	if (   !neigh_old /* only matters in the "add" case. */
	    && (g_hash_table_size (priv->lldp_neighbors) + 1 > MAX_NEIGHBORS)) {
		_LOGT ("process: ignore neighbor due to overall limit of %d", MAX_NEIGHBORS);
		return;
	}

	_LOGD ("process: %s neigh: "LOG_NEIGH_FMT,
	        neigh_old ? "update" : "new",
	        LOG_NEIGH_ARG (neigh));

	changed = TRUE;
851
	g_hash_table_add (priv->lldp_neighbors, g_steal_pointer (&neigh));
852 853 854 855

done:
	if (changed)
		data_changed_schedule (self);
856 857 858
}

static void
859
lldp_event_handler (sd_lldp *lldp, sd_lldp_event event, sd_lldp_neighbor *n, void *userdata)
860
{
861
	process_lldp_neighbor (userdata, n, event != SD_LLDP_EVENT_REMOVED);
862 863 864
}

gboolean
865
nm_lldp_listener_start (NMLldpListener *self, int ifindex, GError **error)
866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
{
	NMLldpListenerPrivate *priv;
	int ret;

	g_return_val_if_fail (NM_IS_LLDP_LISTENER (self), FALSE);
	g_return_val_if_fail (ifindex > 0, FALSE);
	g_return_val_if_fail (!error || !*error, FALSE);

	priv = NM_LLDP_LISTENER_GET_PRIVATE (self);

	if (priv->lldp_handle) {
		g_set_error_literal (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
		                     "already running");
		return FALSE;
	}

882
	ret = sd_lldp_new (&priv->lldp_handle);
883
	if (ret < 0) {
884 885 886 887 888
		g_set_error_literal (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
		                     "initialization failed");
		return FALSE;
	}

889 890 891 892 893 894 895
	ret = sd_lldp_set_ifindex (priv->lldp_handle, ifindex);
	if (ret < 0) {
		g_set_error_literal (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
		                     "failed setting ifindex");
		goto err;
	}

896
	ret = sd_lldp_set_callback (priv->lldp_handle, lldp_event_handler, self);
897
	if (ret < 0) {
898
		g_set_error_literal (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
899 900
		                     "set callback failed");
		goto err;
901 902
	}

903 904 905
	priv->ifindex = ifindex;

	ret = sd_lldp_attach_event (priv->lldp_handle, NULL, 0);
906
	if (ret < 0) {
907
		g_set_error_literal (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
908 909
		                     "attach event failed");
		goto err_free;
910 911 912
	}

	ret = sd_lldp_start (priv->lldp_handle);
913
	if (ret < 0) {
914 915 916 917 918
		g_set_error_literal (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
		                     "start failed");
		goto err;
	}

919
	_LOGD ("start");
920

921 922 923 924 925
	return TRUE;

err:
	sd_lldp_detach_event (priv->lldp_handle);
err_free:
926
	sd_lldp_unref (priv->lldp_handle);
927
	priv->lldp_handle = NULL;
928
	priv->ifindex = 0;
929 930 931 932 933 934 935 936
	return FALSE;
}

void
nm_lldp_listener_stop (NMLldpListener *self)
{
	NMLldpListenerPrivate *priv;
	guint size;
937
	gboolean changed = FALSE;
938 939 940 941 942

	g_return_if_fail (NM_IS_LLDP_LISTENER (self));
	priv = NM_LLDP_LISTENER_GET_PRIVATE (self);

	if (priv->lldp_handle) {
943
		_LOGD ("stop");
944 945
		sd_lldp_stop (priv->lldp_handle);
		sd_lldp_detach_event (priv->lldp_handle);
946
		sd_lldp_unref (priv->lldp_handle);
947 948 949 950
		priv->lldp_handle = NULL;

		size = g_hash_table_size (priv->lldp_neighbors);
		g_hash_table_remove_all (priv->lldp_neighbors);
951 952
		if (size || priv->ratelimit_id)
			changed = TRUE;
953 954
	}

955 956
	nm_clear_g_source (&priv->ratelimit_id);
	priv->ratelimit_next = 0;
957
	priv->ifindex = 0;
958 959 960

	if (changed)
		data_changed_notify (self, priv);
961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978
}

gboolean
nm_lldp_listener_is_running (NMLldpListener *self)
{
	NMLldpListenerPrivate *priv;

	g_return_val_if_fail (NM_IS_LLDP_LISTENER (self), FALSE);

	priv = NM_LLDP_LISTENER_GET_PRIVATE (self);
	return !!priv->lldp_handle;
}

GVariant *
nm_lldp_listener_get_neighbors (NMLldpListener *self)
{
	NMLldpListenerPrivate *priv;

979 980
	g_return_val_if_fail (NM_IS_LLDP_LISTENER (self), FALSE);

981 982
	priv = NM_LLDP_LISTENER_GET_PRIVATE (self);

983 984 985 986 987
	if (G_UNLIKELY (!priv->variant)) {
		GVariantBuilder array_builder;
		gs_free LldpNeighbor **neighbors = NULL;
		guint i, n;

988
		g_variant_builder_init (&array_builder, G_VARIANT_TYPE ("aa{sv}"));
989 990 991 992 993 994
		neighbors = (LldpNeighbor **) nm_utils_hash_keys_to_array (priv->lldp_neighbors,
		                                                           lldp_neighbor_id_cmp_p,
		                                                           NULL,
		                                                           &n);
		for (i = 0; i < n; i++)
			g_variant_builder_add_value (&array_builder, lldp_neighbor_to_variant (neighbors[i]));
995 996
		priv->variant = g_variant_ref_sink (g_variant_builder_end (&array_builder));
	}
997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022
	return priv->variant;
}

static void
get_property (GObject *object, guint prop_id,
              GValue *value, GParamSpec *pspec)
{
	NMLldpListener *self = NM_LLDP_LISTENER (object);

	switch (prop_id) {
	case PROP_NEIGHBORS:
		g_value_set_variant (value, nm_lldp_listener_get_neighbors (self));
		break;
	default:
		G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
		break;
	}
}

static void
nm_lldp_listener_init (NMLldpListener *self)
{
	NMLldpListenerPrivate *priv = NM_LLDP_LISTENER_GET_PRIVATE (self);

	priv->lldp_neighbors = g_hash_table_new_full (lldp_neighbor_id_hash,
	                                              lldp_neighbor_id_equal,
1023
	                                              (GDestroyNotify) lldp_neighbor_free, NULL);
1024 1025

	_LOGT ("lldp listener created");
1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
}

NMLldpListener *
nm_lldp_listener_new (void)
{
	return (NMLldpListener *) g_object_new (NM_TYPE_LLDP_LISTENER, NULL);
}

static void
dispose (GObject *object)
{
	nm_lldp_listener_stop (NM_LLDP_LISTENER (object));

	G_OBJECT_CLASS (nm_lldp_listener_parent_class)->dispose (object);
}

static void
finalize (GObject *object)
{
	NMLldpListener *self = NM_LLDP_LISTENER (object);
	NMLldpListenerPrivate *priv = NM_LLDP_LISTENER_GET_PRIVATE (self);

	nm_lldp_listener_stop (self);
	g_hash_table_unref (priv->lldp_neighbors);

	nm_clear_g_variant (&priv->variant);

1053 1054
	_LOGT ("lldp listener destroyed");

1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066
	G_OBJECT_CLASS (nm_lldp_listener_parent_class)->finalize (object);
}

static void
nm_lldp_listener_class_init (NMLldpListenerClass *klass)
{
	GObjectClass *object_class = G_OBJECT_CLASS (klass);

	object_class->dispose = dispose;
	object_class->finalize = finalize;
	object_class->get_property = get_property;

1067 1068 1069 1070 1071 1072 1073 1074
	obj_properties[PROP_NEIGHBORS] =
	    g_param_spec_variant (NM_LLDP_LISTENER_NEIGHBORS, "", "",
	                          G_VARIANT_TYPE ("aa{sv}"),
	                          NULL,
	                          G_PARAM_READABLE |
	                          G_PARAM_STATIC_STRINGS);

	g_object_class_install_properties (object_class, _PROPERTY_ENUMS_LAST, obj_properties);
1075 1076
}