Skip to content

[th/platform-ethtool-cleanup] platform: cleanup ethtool calls in "nm-platform-utils.c"

Thomas Haller requested to merge th/platform-ethtool-cleanup into main

  • consistently check for success/failure of _ethtool_call_handle() with "< 0" / ">= 0".

  • drop unnecessary memset(). In the past, I argued to add this because there were obscure cases with valgrind where this made a difference. As it's not clear when/how that is necessary, drop it again. Also, we want to prefer explicit struct initialization over memset(), so if memset() would be necessary, those places would be problematic as well.

  • inline unnecessary helper functions. They had only one caller and only make the code more verbose.

Merge request reports