Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 198
    • Issues 198
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !794

ifcfg-rh: add "VLAN_ID_USE" flag to prefer VLAN_ID variable

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Thomas Haller requested to merge th/ifcfg-vlan-id-use into master Mar 25, 2021
  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 6

For backward compatibility, the reader ignores VLAN_ID= if DEVICE= has a name with a suffix that looks like a vlan-id.

This was introduced by commit 10b32be3 ('ifcfg-rh: various VLAN cleanups').

In particular, when NetworkManager writes a profile to ifcfg format, then the profile must be encodable without modification. Since a NetworkManager profile has on consistency requirement that the vlan-id and the interface-name resemble each other, this requires a workaround.

Add a VLAN_ID_USE= flag. If that is true, then VLAN_ID= is preferred (if present).

https://bugzilla.redhat.com/show_bug.cgi?id=1907960

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/ifcfg-vlan-id-use